Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

number of 2d fields in DDT sfcprop is not right in FV3GFS_io.F90 #418

Closed
HelinWei-NOAA opened this issue Nov 6, 2021 · 1 comment · Fixed by #417
Closed

number of 2d fields in DDT sfcprop is not right in FV3GFS_io.F90 #418

HelinWei-NOAA opened this issue Nov 6, 2021 · 1 comment · Fixed by #417
Labels
bug Something isn't working

Comments

@HelinWei-NOAA
Copy link
Contributor

The number is messed up with the recent commits. The bug will have some impact on the initial fields
@HelinWei-NOAA HelinWei-NOAA added the bug Something isn't working label Nov 6, 2021
@HelinWei-NOAA HelinWei-NOAA mentioned this issue Nov 6, 2021
Closed
@HelinWei-NOAA
Copy link
Contributor Author

Just discussed with Moorthi. I agreed with him that the bug will not have any impact on the forecast. temp2d is only used for diagnostic only.

@climbfuji climbfuji mentioned this issue Nov 10, 2021
Merged
SamuelTrahanNOAA pushed a commit to SamuelTrahanNOAA/fv3atm that referenced this issue Jun 13, 2022
@dustinswales
Update ccpp-physics. Make RRTMGP thread safe (NOAA-EMC#418)
4c3b6d5 
Changes to the initialization and setup of the RRTMGP radiation scheme to allow for use across multiple OpenMP threads.
* Moved Interstitial RRTMGP DDTs (ty_rrtmgp_gas_optics, ty_cloud_optics) to static fields defined during initialization in module memory.
* Add "$omp critical" statements around the calling type-bound procedures during initialization.
* Move allocation of ty_gas_conc from Interstitial to GFS_typedefs. Initialize ty_gas_concs for all blocks during initialization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@HelinWei-NOAA