Restarting model changes final result #42
Comments
|
One thing that comes to my mind is to check the interval for resetting the diagnostic variables (fhzero). Restarts only work if they coincide with a multiple of fhzero. I see that your fhzero value is 0.25, which would be ok, but I never tried using a fractional fhzero value in the first place. This wouldn't explain the differences for the dycore-only run, though.
|
|
The restart flags are: config['namelist']['fv_core_nml']['external_ic'] = False
config['namelist']['fv_core_nml']['nggps_ic'] = False
config['namelist']['fv_core_nml']['make_nh'] = False
config['namelist']['fv_core_nml']['mountain'] = True
config['namelist']['fv_core_nml']['warm_start'] = True
config['namelist']['fv_core_nml']['na_init'] = 0All prognostic and diagnostic variables written out by the restart routines differ. We're using our own docker setup, not the ufs-weather-model repo. I checked the restart tests (e.g. this one) and my impression is the tests are checking something different than what we've tested. In the ufs-weather-model regression tests, the test checks that when you initialize the model from a restart file and run it, it produces the same output as when this process was done earlier. What we have tested is that when you initialize the model from any condition and run it for a set period continuously, the result should be the same as when you interrupt and restart the run halfway through. None of the tests seem do this in the ufs-weather-model repo. |
NOAA-GSD is testing what you are trying to do for the GSD physics suite: https://github.com/NOAA-GSD/ufs-weather-model (branch gsd/develop). You are right about the way the regression tests are set up for the EMC branches, but as far as I know EMC tests the restart capabilities as you described them from time to time. Last I tested it successfully for the GFS suite is a few months back. |
Where are those tests defined? As far as I can tell the tests with "restart" in the filename in |
|
https://github.com/NOAA-GSD/ufs-weather-model/blob/gsd/develop/tests/tests/fv3_ccpp_gsd runs a 48h forecast. https://github.com/NOAA-GSD/ufs-weather-model/blob/gsd/develop/tests/tests/fv3_ccpp_gsd_coldstart runs a 24h forecast from the same initial conditions, and https://github.com/NOAA-GSD/ufs-weather-model/blob/gsd/develop/tests/tests/fv3_ccpp_gsd_warmstart uses the restart files from https://github.com/NOAA-GSD/ufs-weather-model/blob/gsd/develop/tests/tests/fv3_ccpp_gsd_coldstart to run another 24h forecast/warmstart. The results of the warmstart run are compared to the 48h single integration. |
|
I do not see similar automated tests for the GFS physics (without ccpp), which we are using (and which is causing the issue). You said
It would be helpful to get the build and run configuration used so I can test them with our set-up. |
|
I will see if I find time this week to create those tests. Essentially I'd use a setup similar to the GSD tests described above but with the GFSv15p2 physics. |
|
Just to give you an update, with the AMS this week I haven't been able to set up these tests yet. |
|
I can confirm that with the namelist settings in the ufs_public_release branches for the GFS_v15p2 tests the restarts do not work. I am now trying to fix this, I've got a few ideas what may be the difference to the tests that we know are b4b reproducible in restart runs. |
|
See also here for a similar report - ufs-community/ufs-mrweather-app#62 |
|
See here for an update ufs-community/ufs-mrweather-app#62 . |
|
Please take a look at this branch https://github.com/DusanJovic-NOAA/ufs-weather-model/tree/ctrl_rest. I modified fv3_restart test slightly to use 12h restart files from a previous fv3_control run and compare 24h outputs against 24h outputs from a fv3_control run. I believe this is the actual restart test that verifies that the restart run is b4b identical to the cold start run. If you have access to one of the supported platforms, clone this branch and run: This is in develop branch but I hope it will help you figure out why your tests are not bit-reproducible. |
|
Ok, I got this figured out. The culprit was the For restarts, this would have to be but it doesn't work. I changed this back to the default value in all incoupled ufs-weather-model regression tests in the develop branch or, for restarts, and then I get b4b identical results for both v15p2 and v16beta in PROD mode (cheyenne.intel, hera.intel, cheyenne.gnu). I created a PR for ufs_public_release here: ufs-community/ufs-weather-model#33. |
|
Attached is a tarball with the run directories of the full |
Thanks for fixing this. We need to commit this change. |
|
Great, thanks! This is exactly what I have done for GSD's restart test in the past (https://github.com/NOAA-GSD/ufs-weather-model, branch gsd/develop; modulo that I am running 48h forecasts when creating baselines and then two 24h forecasts, a coldstart and a restart, comparing against the 48h runs). I created a PR for ufs_public_release that does the same thing this evening. Yes, please create a PR for "develop" so that we can fix the restart tests. |
|
@mcgibbon is this problem resolved? |
|
It is not, thanks for the ping. I haven't had time to test the fixes. I'll give it higher priority so we can ideally close this issue. |
|
The If you're curious, the test I have written is here and the install procedure I'm using is here. I assumed |
|
@mcgibbon FYU, the ufs_public_release branches give b4b identical results for restart runs with GNU 8.3.0 on Cheyenne. |
|
It's difficult to tell the cause of this difference, because I don't have any way to reproduce the configuration you have on Cheyenne. |
|
Where are you running on? Is there a shared platform that we may be able to use? Do you have access to Amazon Web Service? If everything else fails, I can - time permitting - fire up an instance there, run the restart tests and give you access to the instance to look at the code/rundirs (and download it). You could also upload your stuff and we could take a look. But this can't happen this week I am afraid. |
|
If you have a Docker file or image somewhere that includes the necessary run data I could use that. I've just been running locally for development, though we also do jobs on Google cloud. I got the ufs-weather-model to build in docker and could upload that to github if you'd like, it would just take some time to make proper forks because I had to make some small changes to the submodule repos to get it building. Our stuff is all uploaded in this repo for the fortran model. It makes use of this tool we've made for setting up run directories, which will grab our run data from the web. Assuming docker is installed and you have a python 3 environment, everything should build and the tests should run with the following in the root directory: $ make build
$ pip3 install -r requirements.txt
$ python3 -m fv3config.download_data
$ python3 tests/test_fv3_exe_restart.pyThe final script spits out the run directories inside the root directory. The pip line will grab a particular commit of our fv3config tool. The download_data command puts data in your system-dependent user cache directory, which you can locate by looking at the symlink target in the resulting run directory. The cases run at C48 for a total of 8 hours, which finishes in a couple minutes on 6 cores on my machine and uses slightly more than 4GB of memory. You may need to increase the default docker memory allocation (I think I have mine set to 8GB). If the test fails with a message about a missing output file or |
climbfuji
added a commit
to climbfuji/fv3atm
that referenced
this issue
Apr 14, 2020
- RRTMGP in CCPP
- build system improvement: get CCPP kind and type definitions from CCPP framework, remove libxml2 from static CCPP build
- cleanup radiation tendencies in CCPP
- required cmake version now 3.0
- missing code changes for MG-IN-CCN update (from code review)
Squashed commit of the following:
commit 50c6de3fe781acb861cac617296380b571c3fd27
Merge: f089bbf 9cec3b5
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Tue Apr 14 06:59:19 2020 -0600
Merge pull request #42 from climbfuji/update_dtc_develop_from_emc_develop_and_missing_ccnin_updates
Update NCAR dtc/develop from EMC master, apply missing updates from CCN/IN commit
commit 9cec3b5f0f7a527a6496380442f7c5a4f32d1852
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Tue Apr 14 06:56:46 2020 -0600
Revert change to .gitmodules and update submodule pointer for ccpp-physics
commit 27ce0d4f6d45fef08ba8ea040fef5cdb1e9f42b7
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Fri Apr 10 14:21:54 2020 -0600
Update .gitmodules and submodule pointer for ccpp-physics for code review and testing
commit 50501ec2b925fb2ffd6f4ff6c61c08801c334933
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Fri Apr 10 14:21:26 2020 -0600
Apply missing updates for MG-IN-CCN changes
commit 2130922d485efe285b099c08c400d77b601dd1fe
Merge: f089bbf 9b5a420
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Fri Apr 10 13:55:33 2020 -0600
Merge branch 'develop' of https://github.com/NOAA-emc/fv3atm into HEAD
commit f089bbfd58e1e59662b28a1437f1fa570b55e0ac
Merge: f0e8d7c 96be1d3
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Fri Apr 10 11:36:13 2020 -0600
Merge pull request #40 from climbfuji/update_dtc_develop_from_emc_develop_and_other_updates_20200409
Update dtc/develop from develop and other updates 2020/04/09
commit 96be1d3acc831eadc7ad656aa99438d93847514c
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Fri Apr 10 11:34:34 2020 -0600
Revert change to .gitmodules and update submodule pointers for GFDL_atmos_cubed_sphere, ccpp-framework and ccpp-physics
commit 2e8645640d0ff6ddf74b9c66b2fa32dd2b823cb2
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Apr 9 20:23:32 2020 -0600
Update .gitmodules and submodule pointers for ccpp-framework, ccpp-physics, GFDL_atmos_cubed_sphere for code review and testing
commit 931dc325ab37a0a2dc8d20ebad0e777084694619
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Apr 9 20:22:56 2020 -0600
ccpp/CMakeLists.txt: require cmake 3.0, remove legacy syntax for policy CMP0048
commit 2f1a5c56a7d45a0de58ba47624f25a4be5e143e1
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Apr 9 20:21:20 2020 -0600
gfsphysics/physics/ugwp_driver_v0.f: comment out unnecessary prints to stdout that pollute the model output
commit 13cc9eae66932f93baefc4a18508c264f72d5c59
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Tue Jan 21 08:14:41 2020 -0700
CMakeLists.txt: add dependency on CCPP for fv3cap library
commit cfa55411f69c3c3000f7f3f5211c9b0c1bfd96e6
Merge: f0e8d7c 7c3eade
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Apr 9 10:34:58 2020 -0600
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into HEAD
commit f0e8d7cede7c82feaff332f000661e01ae61490a
Merge: 485de28 d444a9a
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Fri Apr 3 15:32:38 2020 -0600
Merge pull request #36 from climbfuji/update_submodule_pointer_ccpp_physics_20200403
dtc/develop: update submodule pointer for ccpp-physics 2020/04/03
commit d444a9a402a9110474a528abe4564d1fc5e6ddfe
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Fri Apr 3 15:29:52 2020 -0600
Update submodule pointer for ccpp-physics
commit 485de283183371f91a7ce454cc3186690bbef427
Merge: 59e02cc 053edd9
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Fri Apr 3 11:46:54 2020 -0600
Merge pull request #35 from climbfuji/avoid_recompile_without_change
dtc/develop: speed up static compilation
commit 053edd9103e23479601f7e5f2473bd4e767b5656
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Fri Apr 3 11:45:49 2020 -0600
Revert change to .gitmodules, update submodule pointers for ccpp-framework and ccpp-physics
commit f95cedbbbf0eb864bb5c78063757816de2fb22b8
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Apr 2 13:56:45 2020 -0600
Update .gitmodules and submodule pointers for ccpp-framework and ccpp-physics for code review and testing
commit 59e02cc293f488c04d9969a834ae75a78a40ce2a
Merge: 3ffe2b4 18f7cef
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu Apr 2 08:13:37 2020 -0600
Merge pull request #34 from climbfuji/cleanup_radiation_tendencies
Cleanup radiation tendencies (standard names and allocation)
commit 18f7cef3a2d411206a3e05194516ed851d9db6d4
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Apr 2 08:12:17 2020 -0600
Revert change to .gitmodules and update submodule pointer for ccpp-physics
commit e05ad13ee0d9aceb6b5990d4abe6363e6665c7e7
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Wed Apr 1 10:09:04 2020 -0600
Clean up of radiation tendencies standard names as described in issue https://github.com/NCAR/ccpp-physics/issues/179; move radiation tendencies on radiation timestep and radiation levels from GFS_tbd_type to GFS_interstitial_type
commit 14becd4000df1702e5e40c21614199b8376c3721
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Wed Apr 1 10:07:37 2020 -0600
Update .gitmodules and submodule pointer for ccpp-physics for code review and testing
commit 3ffe2b42702f0bd001a1b57fe8caf680548e08c1
Merge: 8672795 d1b1548
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu Mar 26 10:34:46 2020 -0600
Merge pull request #32 from climbfuji/add_rrtmgp_dom
RRTMGP in fv3atm (#26 - based on latest code)
commit d1b15481b46fed96c3665a1e0874b19baf202d16
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Mar 26 10:33:34 2020 -0600
Revert change .gitmodules and update submodule pointers for ccpp-framework and ccpp-physics
commit cc4b75d65a9047d261bd172c3d7e7e7cea1a8caf
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Mar 26 10:10:42 2020 -0600
Add guard to GFS_typedefs.F90 to prevent running RRTMGP with levr<levs
commit c678c68cf3b29fd238d0d9145f77627a346f03e5
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Wed Mar 25 14:39:45 2020 -0600
gfsphysics/GFS_layer/GFS_typedefs.F90: re-enable initialization/resetting of Diag%rain and Diag%rainc
commit 3815ff163afcea2f400114d06c2a37600fc6d6d8
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Wed Mar 25 06:24:37 2020 -0600
Update submodule pointer for ccpp-framework after merging Python 3 compatibility PR
commit 8f9871e5c6e86f4b593b67303dba65ba389f17c7
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Mon Mar 23 18:43:02 2020 +0000
Cleanup RRTMGP optional argument logic.
commit 0af00782d5cc4a1068b3e6c6a130e702e805b801
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Mar 19 20:32:07 2020 -0600
From @dustinswales: bugfix for optional arguments for RRTMGP in ccpp/config/ccpp_prebuild_config.py
commit 041ea4c5188958fa34c3efe08cd0cec7dac86877
Merge: 51ffb8e 515a83f
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Mar 19 11:53:12 2020 -0600
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into add_rrtmgp_dom
commit 51ffb8eb2c8bc2740f89b08b00a755e58f4e620d
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Mar 19 11:29:16 2020 -0600
Update to CCPP prebuild config and make/cmake build systems to accommodate latest changes in ccpp-framework
commit 58977b70feaec4dfa87457e47c917a01622ba235
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Mar 19 11:28:36 2020 -0600
Remove dcyc2t3_post from RRTMGP SDF, rename doRRTMGP to do_RRTMGP to be consistent with other do_XYZ flags in GFS_typedefs
commit b14368a04112d8fd9ad45801c356025e23c3bd6a
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Tue Mar 17 15:49:29 2020 -0600
Formatting changes to several files; reversal of changes to gfsphysics/makefile; update .gitmodules for code review and testing; update submodule pointer for ccpp-physics and ccpp-framework
commit d196b0e0fdf086bb72ae2579544369ffd2b66500
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Tue Mar 17 15:36:12 2020 -0600
Squashed commit of the following:
commit 6266b7bd7f9cefdbacf6ec03be74e1b998ab7fd5
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Fri Mar 6 18:53:55 2020 +0000
Zeroed out rrtmgp fields in GFS_typedefs.F90
commit be22b66f67078e0e29906f686328ea7a6e47d06a
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Fri Mar 6 16:58:20 2020 +0000
Added logic so that RRTMGP fields are only allocated if RRTMGP is used.
commit bbd4bbc6033977dca139b73b8794fa2edafaf63c
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Thu Mar 5 21:41:41 2020 +0000
Reverted some changes.
commit 7d784e424762211d81b54236c1e686422b392eb8
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Thu Mar 5 21:30:52 2020 +0000
Some housekeeping...
commit 40697859947f13ac0f204a93d75b30c4f79bae7a
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Thu Mar 5 21:14:29 2020 +0000
Updated ccpp submodules. Synced w/ upstream
commit 14be13f19f93f3b22aa76503fc9ed208a65364a2
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Wed Feb 19 18:16:51 2020 +0000
Some cleaning up. Updated submodules.
commit 84c18bd9cf0489a49866a8990469fdd5a630e3d8
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Sat Feb 15 00:01:16 2020 +0000
Updated submodules.
commit 1e05a16ac48101064e46937552355e0751ca09ce
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Mon Feb 10 23:49:16 2020 +0000
Updated submodules.
commit 6959f09095ba386ccb6a4f79ff4e2b0b50a672d0
Merge: a3c1cd8a 756ef51a
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Mon Feb 10 17:56:49 2020 +0000
Merge branch 'dtc/develop' of https://github.com/NCAR/fv3atm into rrtmgp-dev
commit a3c1cd8a2d6cbe38fe67372d0ef5e1a43370f09f
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Mon Feb 10 17:47:17 2020 +0000
Updated ccpp-physics submodule.
commit a255a636357584db690e810a0977277805f054a0
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Fri Dec 13 22:16:07 2019 +0000
Updated submodules
commit 0aea78e5ce8e4218c90ac4bdebdca04679811177
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Tue Dec 10 22:55:26 2019 +0000
Updated ccpp-physics submodule.
commit 09c2d77171e5ea0d1550f9f2d95120c0e7075e51
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Thu Dec 5 01:47:56 2019 +0000
Small change to GFS_typedefs.F90
commit 4de65fd50d87ce529e2403d5b1c1fc2b45a52c35
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Wed Dec 4 21:20:49 2019 +0000
Omission from previous commit.
commit 05179a163f8a1659ee8dcabc52ecdca1a1a7f9d1
Merge: ab209723 88e87e9b
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Wed Dec 4 21:08:27 2019 +0000
Merge branch 'dtc/develop' of https://github.com/NCAR/fv3atm into rrtmgp-dev
commit ab209723dd75f49ba99cdadbb4dad4a077a9a975
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Wed Dec 4 21:05:46 2019 +0000
Updated submodules.
commit 945ba98dc1100f2d08b6e804784ce5f4f5df8c96
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Thu Nov 21 21:33:28 2019 +0000
Cleaning up my mess.
commit 541a2800e695eb9c0e956d65e4f8388344eca47f
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Thu Nov 21 20:48:13 2019 +0000
Update submodule
commit 7566264e6e02ade0f8f40bfe9c4735f944a43e31
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Thu Nov 21 17:26:50 2019 +0000
Updated .gitmodule
commit 47418d31cca36db3c405be1a0c58448885ae371f
Merge: 221faed5 53e6b771
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Thu Nov 21 17:18:21 2019 +0000
Merge branch 'rrtmgp-dev2' of https://github.com/dustinswales/FV3 into rrtmgp-dev
commit 221faed57683d85d93a3f7b26ac032c2ec845b11
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Thu Nov 21 16:55:50 2019 +0000
Initial commit. Switched ccpp/physics to rrtmgp-dev repository
commit 53e6b771de7668c25b417f0d6d35ce9bb8898574
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Thu Nov 7 23:14:05 2019 +0000
Moved field from radtedn type to interstitial type.
commit c0f195758b91dce864487780d847bac226139797
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Tue Oct 29 14:19:07 2019 +0000
Moved RRTMGP active gases from GFS_radtend_type to GFS_control_type.
commit 323dfc61d3656c5330152acdcc7a19f35b263ccf
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Mon Oct 21 20:41:08 2019 +0000
gfsphysics building!
commit 0f38e6b700c34046cb3823ca806418d40e3bf6a3
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Fri Oct 18 17:21:49 2019 +0000
Reverted makefile
commit 226124b938decd3419e34b5ca2b1f50250b74851
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Thu Oct 17 17:49:10 2019 +0000
-
commit 7ae1b6e9cd0075e8443ce10b7c8ea6b0ccc3d22d
Merge: 474dfaf0 2f738680
Author: dustinswales <dustin.swales@noaa.gov>
Date: Thu Oct 17 10:46:13 2019 -0600
Merge pull request #1 from NCAR/gmtb/develop
Gmtb/develop
commit 2f73868081547b7373f7d47558fd96e9a42ae5e6
Merge: 2fbfebec 5c67f0a9
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Wed Oct 16 07:36:10 2019 +0900
Merge pull request #218 from climbfuji/update_gmtb_develop_from_vlab_master_20191003
Update GitHub NCAR gmtb/develop from VLab EMC master 2019/10/13
commit 5c67f0a979c5a0405a5eaffaa014b9457210e7f7
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Tue Oct 15 09:20:31 2019 +0900
Add stub post_gfs module that is used if -DNO_INLINE_POST is specified, this causes any test using inline post to fail
commit 29ac2cbc8c7a2cc3f0403b1f6bdbe7c738497d51
Author: Jun.Wang <Jun.Wang@noaa.gov>
Date: Mon Oct 7 17:55:48 2019 +0000
FV3: this commits #refs 66932, inline post
Change-Id: I9e685a7b5d4b6b8535fc5f107b42bbdaed47c443
commit 2fbfebec19443fe717e8add62d0a127e5415a188
Merge: 84434e25 9fb8cbbd
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Sun Oct 13 14:41:38 2019 +0900
Merge pull request #217 from climbfuji/fv3_update_submodule_pointer_2019101
Update submodule pointer for atmos_cubed_sphere
commit 9fb8cbbdc0ed081e6172bb15a93b60754d9d889d
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Sun Oct 13 14:40:02 2019 +0900
Update submodule pointer for atmos_cubed_sphere
commit 84434e2586127ca85845623b9370f9e0053d877f
Merge: 474dfaf0 b81b8191
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Sat Oct 12 08:45:10 2019 +0900
Merge pull request #213 from climbfuji/update_gmtb_develop_with_vlab_master_20191006
Update NCAR gmtb/develop with EMC Vlab master 2019/10/06
commit b81b8191dbb81aa9dd24ec00be953649454764c2
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Oct 10 20:38:44 2019 +0900
gfsphysics/GFS_layer/GFS_physics_driver.F90: bugfix for PBL post for MG2/MG3
commit bea8d7e3f4ec06bbf923f00098622be493ba6579
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Oct 10 10:59:07 2019 +0900
gfsphysics/physics/sfcsub.F: transferring bugfix for lbms allocation from CCPP to IPD
commit 48f24c8dfc3853ac9faacd2c182c3dfd3348caa7
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Wed Oct 9 11:05:51 2019 +0900
gfsphysics/GFS_layer/GFS_physics_driver.F90: bugfix, remove if(cplchem) test for Zhao-Carr MP
commit b12b93b76da7de53cc7fa6f3faf0bf3333e45274
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Tue Oct 8 09:03:11 2019 +0900
gfsphysics/GFS_layer/GFS_typedefs.F90: reintroduce interstitial variables for NoahMP, change existing IPD type for Julian day from 'integer' to 'real(kind_phys)' remove redundant CCPP definitions
commit d5101c8229483a44af508170747f7c1454bae9dd
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Mon Oct 7 12:16:23 2019 +0900
Updates for CCPP GFSv16
commit 415c943a9b81258b691b036cd097e0b8384d9e0c
Author: Jun.Wang <Jun.Wang@noaa.gov>
Date: Wed Oct 2 19:27:36 2019 +0000
FV3: this commits the missed code changes in #68128
commit 5b5107fe68dad4825c78cc2eab74ee1c779467a6
Author: Jun.Wang <Jun.Wang@noaa.gov>
Date: Thu Sep 26 20:12:38 2019 +0000
FV3: this commits #refs: #68678,#68141,#68128,#68694,#68982,#67925
Change-Id: Ie4b75858dadbe1975449b9d734a1c6f1e6541b89
commit 474dfaf0a7a76912fc674b8d68877919b0e69aa8
Merge: d7699bab 36f4fb80
Author: grantfirl <grantf@ucar.edu>
Date: Thu Oct 3 11:12:04 2019 -0600
Merge pull request #211 from climbfuji/drag_suite_dom
gmtb/develop: follow-up PR for GSD drag suite
commit 36f4fb80f534f69baddf47b7660b44205366e85a
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Sep 27 16:41:43 2019 -0600
Reapply metadata cleanup work
commit 2e74a5104034dc3dbe263266c19a801158422fde
Author: Michael Toy <michael.toy@noaa.gov>
Date: Tue Sep 24 21:23:56 2019 +0000
Added changes to gfsphysics/GFS_layer/GFS_typdefs.meta that didn't get included in yesterdays PR.
commit 336b6d038db9698da944a1bd8cecf93a31f5cf54
Author: Michael Toy <michael.toy@noaa.gov>
Date: Mon Sep 23 13:30:59 2019 +0000
Added GSD drag suite to ccpp.
commit d7699bab4b20211db4a8ca3988e3ee8a744ab46f
Merge: 86ad37a1 fadbbda0
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Mon Sep 23 10:13:22 2019 -0600
Merge pull request #209 from climbfuji/update_submodule_pointer_atmos_cubed_sphere_20190923
Update submodule pointer for atmos_cubed_sphere 2019/09/23
commit fadbbda009dfccf66cecf814bf1c5475329e1a71
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Mon Sep 23 10:11:18 2019 -0600
Update submodule pointer for atmos_cubed_sphere
commit 86ad37a15dbd7e99f732c80cb758fad541535326
Merge: d02e260c ef0469fc
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Mon Sep 23 09:33:13 2019 -0600
Merge pull request #207 from climbfuji/gmtb_develop_update_from_master_20190920
gmtb/develop update from master 2019/09/20, remove TRANSITION mode
commit ef0469fcb5345d472324720e3c0043b65507c0bd
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Sep 20 08:53:31 2019 -0600
Remove TRANSITION mode
commit 65bfa600345eed605ac580fd35c984c1d915d405
Merge: 545a5ab4 b67d9a39
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Sep 20 07:23:01 2019 -0600
Merge branch 'master' of gerrit:FV3 into gmtb_develop_update_from_master_20190920
commit 545a5ab4fb70f5c7e9164107fb6f77d5ea94128e
Merge: d02e260c 42915ea8
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Sep 20 06:59:23 2019 -0600
Merge branch 'master' of https://github.com/NCAR/FV3 into HEAD
commit d02e260c161addf0bc6589b8f91a6098c4cd57ab
Merge: 9ad93730 fd8f98a4
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu Sep 19 14:40:14 2019 -0600
Merge pull request #206 from climbfuji/myj_with_dom_mods
gmtb/develop: MYJ PBL/SFC, Noah MP
commit fd8f98a43258d9f593fff11f14c4216fca484cfd
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Mon Sep 16 15:30:40 2019 -0600
gfsphysics/GFS_layer/GFS_driver.F90, gfsphysics/makefile, io/FV3GFS_io.F90: re-enable calculation of snocvr in FV3-IPD to avoid b4b issues when 32BIT=Y
commit daab7457cf08c205c5016c8ec7865fbb08b8495f
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Sep 13 16:29:43 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.{F90,meta}: introduce lower bound variable for snow-related arrays in NoahMP, use in metadata table
commit 243977dd91ea022a76dd799f5810357117af13ad
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Sep 13 16:28:01 2019 -0600
gfsphysics/GFS_layer/GFS_driver.F90: update comment on CCPP code
commit 03b00f445c72e1617bef13971cf2b5dd2c4e412f
Merge: 1bb9ab50 c83f1f73
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Sep 13 15:28:19 2019 -0600
Merge branch 'noahmp' of https://github.com/grantfirl/FV3 into myj_with_dom_mods
commit 1bb9ab5097d9906db571d4b4f40211646e23b3a2
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Sep 13 15:28:16 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.F90: remove empty line
commit 1627b2359bc490d4cce58a47ffccbc1c27a61ad9
Merge: 7da9ed85 9ad93730
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Sep 13 15:00:37 2019 -0600
Merge branch 'gmtb/develop' of https://github.com/NCAR/FV3 into myj_with_dom_mods
commit 9ad93730b81314d1ffaf0b98cd81e7d442ccf874
Merge: 1fa34bc4 43544887
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Fri Sep 13 15:00:08 2019 -0600
Merge pull request #204 from climbfuji/correct_longnames_20190909
gmtb/develop: correct long names, align with SCM
commit 7da9ed859921d2ffe1ffdcf6f17ae2ae58449050
Merge: 43544887 bcfed5b2
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Sep 13 10:49:16 2019 -0600
Merge branch 'myj_from_qingfu' into correct_longnames_20190909
commit 43544887d2b6624606dc82f30e4854dc49f23d20
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Sep 12 21:11:20 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.meta: correct longnames and align with SCM
commit c83f1f738b60772b2ae4dff6f6e2434ccc42bc04
Author: Grant Firl <grantf@ucar.edu>
Date: Tue Sep 10 17:37:42 2019 -0600
update comments in GFS_physics_driver.F90 for locations of NoahMP-related code
commit b4a674d9ae4144f25261943bf8a4481d09debe96
Merge: 36ab5be0 1fa34bc4
Author: Grant Firl <grantf@ucar.edu>
Date: Tue Sep 10 17:26:13 2019 -0600
Merge branch 'gmtb/develop' into noahmp
commit 1fa34bc41fe59e9efbb12aeab474c83bf7670420
Merge: 028a54ec 67db064b
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Sun Sep 8 20:32:08 2019 -0600
Merge pull request #203 from climbfuji/gmtb_develop_monster_merge_20190904
Merge gsd/develop, update from Vlab, separate stochastic physics from IPD and CCPP
commit 36ab5be04ffa4e0aabbe7cdae36c378881513739
Author: Grant Firl <grantf@ucar.edu>
Date: Fri Sep 6 15:15:24 2019 -0600
change location of interstitial calculation for NoahMP in comments
commit c1d7a918a84ea7cf64f0b63948be73253584663a
Author: Grant Firl <grantf@ucar.edu>
Date: Fri Sep 6 12:06:09 2019 -0600
fix bugs in FV3GFS_io.F90 related to #ifdef CCPP directives and noahmp
commit 6e8b0cedd9d98ed469366603bae0bb95bc68a9b2
Author: Grant Firl <grantf@ucar.edu>
Date: Wed Sep 4 22:09:28 2019 -0600
add t2mmp and q2mp to interstitial variables for noahmp
commit 42915ea8e753f8be859f6ebf4f5983b4c78b695f
Merge: b30a69a1 1d823f84
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Wed Sep 4 16:41:50 2019 -0600
Merge pull request #202 from climbfuji/github_master_update_from_vlab_master_20190904
Update GitHub master from Vlab master 2019/09/04
commit 67db064b8d7b2e4b8692c8d5927a6897d49607d3
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Sep 4 15:39:01 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.F90, gfsphysics/GFS_layer/GFS_typedefs.meta: add interstitial variables and their initialization, add metadata
commit 635bd9f4f39f219fd6599ab724819db0279bc537
Author: Grant Firl <grantf@ucar.edu>
Date: Wed Sep 4 13:05:15 2019 -0600
swap metadata for a couple of NoahMP precip variables
commit 0b385edcb8344f0e2f515c63d91c27f43155d351
Author: Jun.Wang <Jun.Wang@noaa.gov>
Date: Tue Sep 3 01:37:04 2019 +0000
FV3: this commits #refs 67151, Add aerosol transport to SAMF deep convection scheme, #refs 67152, Export instantaneous convective specific humidity tendency
commit 599dd26768fb988763d6ad2c887432dbfe540d0b
Author: Grant Firl <grantf@ucar.edu>
Date: Wed Sep 4 10:52:25 2019 -0600
remove accidentally reverted change in GFS_physics_driver.F90
commit 1d823f846d64a4c6155565042c36f93a281a6887
Author: Jun.Wang <Jun.Wang@noaa.gov>
Date: Tue Sep 3 01:37:04 2019 +0000
FV3: this commits #refs 67151, Add aerosol transport to SAMF deep convection scheme, #refs 67152, Export instantaneous convective specific humidity tendency
commit f3b64a02ce0f6703b2b0ff60265a91f896e2a0c7
Author: Grant Firl <grantf@ucar.edu>
Date: Wed Sep 4 10:40:11 2019 -0600
remove conversion factor-based directives in GFS_diagnostics.F90
commit 39667a94d78187149a373029ac5bf008ab434fcc
Merge: 5babb964 028a54ec
Author: Grant Firl <grantf@ucar.edu>
Date: Wed Sep 4 10:31:50 2019 -0600
Merge branch 'gmtb/develop' into noahmp
commit fedc6695589c70f0415f9c8914d4e91b649fe937
Merge: 3332314b 179cbe76
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Sep 4 09:08:10 2019 -0600
Merge branch 'gsd/develop' of https://github.com/NCAR/FV3 into gmtb_develop_update_from_master_20190830
commit 3332314b09fa3a373e0ab132165a1453f6b23fa3
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Sep 4 08:27:44 2019 -0600
Bugfixes in gfsphysics/GFS_layer/GFS_driver.F90, gfsphysics/GFS_layer/GFS_typedefs.F90 and gfsphysics/GFS_layer/GFS_typedefs.meta following the merge of the stochastic_physics separation PR
commit 5babb964462e6913e3093462522b2430483905ea
Author: Grant Firl <grantf@ucar.edu>
Date: Tue Sep 3 15:50:59 2019 -0600
remove directives in FV3GFS_io.F90 limiting NoahMP to non-CCPP build; add noahmp_tables.f90 (data only) to makefile for CCPP build (needed in FV3GFS_io.F90 for noahmp cold starts)
commit ede4f37077c866bffb87261edf38e7a8ee388b67
Merge: a721e0d3 45ceeac4
Author: Grant Firl <grantf@ucar.edu>
Date: Tue Sep 3 14:26:19 2019 -0600
Merge branch 'fix_sncovr' into noahmp
commit dbef968c7985c72dc9eabf75f5e65141506dbd38
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Jul 10 08:04:32 2019 -0600
namphysics/NAM_layer/NAM_typedefs.F90, namphysics/NAM_layer/NAM_driver.F90: add new component blksz(:) to NAM_control (GFS_control) DDT, pass to init routine
commit c79b844b35a101db7ed3971d0be7c6077c085cb7
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Jul 9 14:57:36 2019 -0600
makefile: build_stochastic physics independently of IPD or CCPP in directory ../stochastic_physics
commit 278a1f1aa0915b1bcccc86779cc7bd65ee42bc3b
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Jul 9 14:56:42 2019 -0600
atmos_model.F90: call stochastic physics independently of IPD or CCPP
commit 24543a1c4365485d782fa29de647512ef384ec81
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Jul 9 14:41:17 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.F90: remove variables for CCPP that are no longer required, add blksz as component to GFS_control also for IPD (is already for CCPP)
commit 76dccf55128cd961461688f2df3a3bd88d5189e0
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Jul 9 14:38:40 2019 -0600
(1) remove directory stochastic_physics
(2) gfsphysics/GFS_layer/GFS_driver.F90: remove calls to stochastic_physics, make Init_parm%blksz an input argument to Model%init for both IPD and CCPP
commit 028a54ec8e0596892f9bc01d63df7a1c4867ec41
Merge: d04664e7 62fb7fb3
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Tue Sep 3 09:20:05 2019 -0600
Merge pull request #199 from climbfuji/gmtb_develop_update_from_master_20190830
gmtb/develop: update from master 2019/08/30
commit b30a69a16b0b9cd91b49fe20ea4cf5773e65f26e
Merge: 127baf51 a47b7fc2
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Tue Sep 3 08:21:34 2019 -0600
Merge pull request #200 from climbfuji/update_submodule_pointer_in_FV3_20190903
master: update submodule pointer for atmos_cubed_sphere
commit a47b7fc2dfe3612b8d0ee8af6d523e3995cc93d8
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Sep 3 08:19:46 2019 -0600
Update submodule pointer for atmos_cubed_sphere
commit 127baf51f612a7c7f04ebe160b28657773840bac
Merge: ef8bb547 088e5fa1
Author: Laurie Carson <carson@ucar.edu>
Date: Mon Sep 2 14:12:30 2019 -0600
Merge pull request #198 from climbfuji/update_from_noaaemc_dev_20190830
Update GitHub NCAR master from Vlab master
commit 45ceeac46d3f3f6dbdcef9bfd9cd43bdc2b1c92c
Author: Grant Firl <grantf@ucar.edu>
Date: Fri Aug 30 16:04:41 2019 -0600
remove calculation of sncovr from FV3GFS_io.F90 and from the makefile (for CCPP build)
commit 62fb7fb3cf5900e6f71c4a7a52f6d6fbc3b629a1
Author: Jun.Wang <Jun.Wang@noaa.gov>
Date: Tue Aug 27 20:17:31 2019 +0000
FV3: This commits #refs 66699, Calling radiative transfer parameterizations on each physics time step and #refs 66931,fix time window for accumulated fields in fv3 with IAU
commit 9265ae03ec7af41420210a427149268118d81846
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Aug 30 12:04:36 2019 -0600
Update .gitmodules and set default branch for atmos_cubed_sphere to gmtb/develop, update submodule pointer
commit 1028b3f905d7f74f173a854d55fdc0a2ca6b7c82
Author: Jun.Wang <Jun.Wang@noaa.gov>
Date: Sun Aug 25 02:54:03 2019 +0000
FV3: this commits #59519, separate FV3 dynamical core repository from FV3
commit 088e5fa16afc1b3ffd3932294de83aa72c7971ac
Author: Jun.Wang <Jun.Wang@noaa.gov>
Date: Tue Aug 27 20:17:31 2019 +0000
FV3: This commits #refs 66699, Calling radiative transfer parameterizations on each physics time step and #refs 66931,fix time window for accumulated fields in fv3 with IAU
commit cf98bfae384ee3cb2969c69fafa19f79156ed15d
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Aug 30 08:36:09 2019 -0600
Update .gitmodules to point to NCAR fork of GFDL_atmos_cubed_sphere
commit 31e13942a8e543e365216b134895e6ceffef8a83
Author: Jun.Wang <Jun.Wang@noaa.gov>
Date: Sun Aug 25 02:54:03 2019 +0000
FV3: this commits #59519, separate FV3 dynamical core repository from FV3
commit d04664e793f8cff5502a5127ce03f1e19352f676
Merge: 47fa9fbb a5d2226d
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Fri Aug 30 07:39:08 2019 -0600
Merge pull request #195 from climbfuji/github_gmtb_develop_address_physics_issue_300_and_coupled_code
GitHub gmtb develop address physics issue 300 and coupled code
commit ef8bb5470f7d53b4afc6087f7f601f4b8cd8ee80
Merge: 8a863586 bd46b82d
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu Aug 29 15:33:03 2019 -0600
Merge pull request #197 from grantfirl/master
add Julie as codeowner
commit 47fa9fbb67fdfe1d7ace52282fc8974eea9b1a03
Merge: 21fdde6b 561eb79d
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu Aug 29 15:32:36 2019 -0600
Merge pull request #196 from grantfirl/gmtb/develop
add Julie as codeowner
commit bd46b82d013091fcf36f75ab04624c55efd96dd3
Author: Grant Firl <grantf@ucar.edu>
Date: Thu Aug 29 15:07:57 2019 -0600
add Julie as codeowner
commit 561eb79d9133f1b285eb1503bbad5c24d6f460dc
Author: Grant Firl <grantf@ucar.edu>
Date: Thu Aug 29 15:05:15 2019 -0600
add Julie as codeowner
commit a5d2226d5d37464e9feea05b32db08572468fb16
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Aug 28 17:29:25 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.meta: rename instantaneous_upward_sensible_heat_flux to instantaneous_surface_upward_sensible_heat_flux_for_chemistry_coupling
commit 5fac92183886479afc473bd01b9cd70840bd54fc
Merge: b803db91 7ffc16a7
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Aug 28 10:03:12 2019 -0600
Merge branch 'gmtb/develop' of https://github.com/panll/FV3 into HEAD
commit b803db9182aad295b64e9d62052a4e601dd029fe
Merge: 21fdde6b fd929f17
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Aug 28 10:02:36 2019 -0600
Merge branch 'fix_LSM_units' of https://github.com/grantfirl/FV3 into HEAD
commit 179cbe760b1d06960fecafb811241f0a6f2293d4
Merge: 0591b5c5 7994ef98
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Tue Aug 27 16:38:23 2019 -0600
Merge pull request #190 from grantfirl/fix_RUC_LSM_precip_partitioning
Address ccpp-physics issue #301
commit 21fdde6b7db39fa24ff667a42b3f79edeab50e1e
Merge: a26436be 2f5bd1ef
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Tue Aug 27 16:29:54 2019 -0600
Merge pull request #194 from climbfuji/gmtb_develop_fix_RUC_LSM_precip_partitioning
gmtb/develop: address issue #301 (fix RUC LSM precip partitioning)
commit fd929f175da3b3e3ba16c0984f46f97e6246c1be
Author: Grant Firl <grantf@ucar.edu>
Date: Tue Aug 27 16:27:48 2019 -0600
fix soil moisture units in non-CCPP sfc_drv.f and sfc_noahmp_drv.f
commit a721e0d3c2913dd1fa174b0fb3741b802e5b4c4f
Author: Grant Firl <grantf@ucar.edu>
Date: Tue Aug 27 15:02:51 2019 -0600
remove stop for NoahMP LSM through CCPP in GFS_typedefs.F90
commit dcd9771211b2476000e968b02ebedc7e35f0f4a7
Author: Grant Firl <grantf@ucar.edu>
Date: Tue Aug 27 13:43:37 2019 -0600
wrap removal of conversion factors for 3 variables in GFS_diagnostics.F90 in #ifndef CCPP directives
commit 2f5bd1ef13db0b857b03b2e43f7b5bfb930d8470
Author: Grant Firl <grantf@ucar.edu>
Date: Tue Aug 20 14:13:34 2019 -0600
fix CCPP metadata for convective/non-convective precip variables used in RUC LSM
commit a26436be1da9816330d375fb111e79204398aaee
Merge: 44d95416 63633922
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Tue Aug 27 07:13:16 2019 -0600
Merge pull request #186 from bluefinweiwei/cires_ugwp
UGWP Version 0
commit bcfed5b20a6b18f5e9ad96b16763889a0fb0c4b6
Author: Qingfu Liu <Qingfu.Liu@noaa.gov>
Date: Tue Aug 27 11:17:39 2019 +0000
add MYJ surface layer scheme and MYJ PBL scheme to CCPP
commit 2f5183ea7052fa39592f8b0fbec36326174526c9
Author: Grant Firl <grantf@ucar.edu>
Date: Mon Aug 26 13:32:59 2019 -0600
move julian and yearlen to GFS_control_type (from interstitial) and add metadata for vars needed in GFS_time_vary_pre_run
commit 636339227e9948feb58e4848a8983c822bbe831a
Merge: 07b2f1f9 0b222938
Author: Weiwei <42526954+bluefinweiwei@users.noreply.github.com>
Date: Fri Aug 23 13:23:21 2019 -0600
Merge pull request #1 from climbfuji/ugwd_dom
UGWD update for open PR to gmtb/develop
commit 0b2229387070e966b5bc6892bd9704d7e57a239c
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Aug 23 11:59:01 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.meta: correct variable dimensions
commit 95071efdde50b128749f5719dce45fc1b2e52729
Author: Grant Firl <grantf@ucar.edu>
Date: Fri Aug 23 11:11:07 2019 -0600
add density of liquid water to constants available to CCPP schemes
commit f7b7df469022a7d74fd43591aabc57ba7e4ddbcf
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Aug 23 08:52:51 2019 -0600
gfsphysics/GFS_layer/GFS_physics_driver.F90: update CCPP comments for UGWP code changes
commit 539d331b5f578dd0c22b2131b54662cfff8839dd
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Aug 23 08:52:22 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.{meta,F90}: import con_p0, use instead of locally defined p_ref, add metadata
commit 5717d0f19ea5b61010910fc0bf50b2529650dd21
Author: Grant Firl <grantf@ucar.edu>
Date: Thu Aug 22 13:32:30 2019 -0600
change comments to reflect locations of NoahMP interstitial code
commit a43041878ed867ec04f3d863559089d2c5d20fef
Merge: 9ffcba3b 44d95416
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Aug 22 11:19:43 2019 -0600
Merge branch 'gmtb/develop' of https://github.com/NCAR/FV3 into ugwd_dom
commit 9ffcba3b817c779dfbd7d7b7fe84d2228b9c652e
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Aug 22 11:19:16 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.F90: remove unnecessary comment
commit 44d95416b0921f5947e93f3aa29ef31ab1b73d4a
Merge: e4e7ee6c cef4ace8
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu Aug 22 11:17:41 2019 -0600
Merge pull request #191 from climbfuji/bugfix_gfdlmp_ccpp
gmtb/develop: bugfix for CCPP GFDL-MP when effective radii are not used
commit 697003f6b26443df0f385b17a2202f70d0f4b476
Merge: e4e7ee6c 07b2f1f9
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Aug 21 14:24:23 2019 -0600
Merge branch 'cires_ugwp' of https://github.com/bluefinweiwei/FV3 into HEAD
commit 04e913f0b90264dc97b122bb1ab789beedde9547
Author: Grant Firl <grantf@ucar.edu>
Date: Wed Aug 21 13:30:00 2019 -0600
initial addition of NoahMP variables to GFS_typedefs.F90
commit 7994ef98ad93bc5999d9a105cba3773ae84da6b5
Author: Grant Firl <grantf@ucar.edu>
Date: Tue Aug 20 14:13:34 2019 -0600
fix CCPP metadata for convective/non-convective precip variables used in RUC LSM
commit ab4264fdd0128ca39897b324ed71aa8b113ed6ad
Author: Grant Firl <grantf@ucar.edu>
Date: Tue Aug 20 13:50:54 2019 -0600
removed conversion factor for soil moisture and runoff diagnostics since they now have the desired units directly in physics code; corrected CCPP units in GFS_typedefs.meta
commit 7ffc16a7ed7f759e414529cd8873417e0dae408d
Author: Linlin.Pan <Linlin.Pan@noaa.gov>
Date: Mon Aug 19 21:52:12 2019 +0000
adding couple option in CCPP with modified variable names.
passed regression tests.
commit 7f7e0a226264cd8928282cabad4822b41f019ddb
Merge: 915dafd4 e4e7ee6c
Author: panll <lpan@ucar.edu>
Date: Mon Aug 19 09:55:48 2019 -0600
Merge pull request #1 from NCAR/gmtb/develop
Gmtb/develop
commit cef4ace8dbb72e551b452743590f1e39739a5c6d
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jul 18 10:58:56 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.F90: bugfix for GFDL-MP in CCPP when effective radii are not used
commit 0591b5c5100d75a79c604d9e91985a8a75aaf60b
Merge: a6ce9d41 c9606fba
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Mon Aug 19 08:48:29 2019 -0600
Merge pull request #188 from climbfuji/update_gsd_develop_with_vlab_master_20190816
Update GitHub gsd/develop with Vlab master 2019/08/16
commit e4e7ee6c640ca64b0ad8915c8ee06631c3c5590c
Merge: 0af7e331 b7b423cb
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Sat Aug 17 16:25:45 2019 -0600
Merge pull request #184 from climbfuji/bugfix_allocating_dtdt_m_non_ccpp_version
Bugfix for allocating dtdt_m in fv_dynamics.F90
commit c9606fba7e19ab86aa60b002f9ccd972b754d219
Author: Dusan Jovic <dusan.jovic@noaa.gov>
Date: Fri Jul 26 13:45:14 2019 +0000
Fix an issue introduced in the previous commit where merge conflict markers were inadvertently committed.
commit 02efdda480a2d1b610e3057d95fa4ac6f21d6ca6
Author: Jun.Wang <Jun.Wang@noaa.gov>
Date: Thu Jul 18 15:21:28 2019 +0000
FV3: This commits #refs 65267 adding obs-based roughness length formulations and adjustment of K for hurricane simulations
Change-Id: Ifea0ed42e7611648f4daa2dc24921561b4080691
commit 8a86358617ff8bc39731b6f8a84128cfb3e74075
Merge: 396b10dc 319bb441
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Fri Aug 16 11:36:41 2019 -0600
Merge pull request #187 from climbfuji/update_github_master_from_vlab_master_20190816
Update GitHub master from Vlab master 2019/08/16
commit 319bb4411a8884493430166b2c4953bd5166e7a2
Author: Dusan Jovic <dusan.jovic@noaa.gov>
Date: Fri Jul 26 13:45:14 2019 +0000
Fix an issue introduced in the previous commit where merge conflict markers were inadvertently committed.
commit b757a06cbb507adcf73b85256cf8ed1869b8e425
Author: Jun.Wang <Jun.Wang@noaa.gov>
Date: Thu Jul 18 15:21:28 2019 +0000
FV3: This commits #refs 65267 adding obs-based roughness length formulations and adjustment of K for hurricane simulations
Change-Id: Ifea0ed42e7611648f4daa2dc24921561b4080691
commit 07b2f1f9e7db1155463698956755cd9b899ce0b7
Author: Weiwei <weiweili@ucar.edu>
Date: Tue Jul 16 14:57:32 2019 -0600
modified: GFS_typedefs.F90
modified: GFS_typedefs.meta
commit 915dafd466c0b7195d1e494d327feb55d4da8981
Author: Linlin.Pan <Linlin.Pan@noaa.gov>
Date: Thu Aug 15 04:43:15 2019 +0000
adding new variables for coupling option in CCPP:
gfsphysics/GFS_layer/GFS_typedefs.F90 -- new variables allocation and initiation included
gfsphysics/GFS_layer/GFS_typedefs.meta -- new variables definiation added
commit b7b423cbf65f30f2c2a2d928c6814d746cbf202e
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Aug 9 11:47:51 2019 -0600
atmos_cubed_sphere/model/fv_dynamics.F90: always allocate dtdt_m, because its dimensions are hardcoded in fv_mapz.F90
commit dfb7db58bd44c48853ae6cd55efeaa731e3afa5f
Merge: 0af7e331 a3ea903d
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Aug 8 14:05:59 2019 -0600
Merge branch 'MG_array_allocation' of https://github.com/grantfirl/FV3 into HEAD
commit 0af7e331bdc79d81a9f0daf6f7a4d64e9170a440
Merge: b1d8ec4d 5b4c6e5e
Author: grantfirl <grantf@ucar.edu>
Date: Tue Aug 6 13:45:45 2019 -0600
Merge pull request #180 from grantfirl/add_interstitial_comments
Document locations of CCPP-implemented code within GFS_physics_driver.F90
commit 5b4c6e5e51738c28fd4616e7cb5ee401817f37b6
Author: Grant Firl <grantf@ucar.edu>
Date: Thu Aug 1 16:35:28 2019 -0600
fix comment related to stochastics in GFS_driver.F90
commit f8f792b889ab19a6c99384c7b1453144ab263bc6
Merge: 4dc853b8 b1d8ec4d
Author: Grant Firl <grantf@ucar.edu>
Date: Thu Aug 1 14:52:11 2019 -0600
Merge branch 'gmtb/develop' into add_interstitial_comments
commit b1d8ec4d6eb4d4f7519c608fe5f76fbacd8e7f6c
Merge: c4712c23 5d14eec3
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu Aug 1 14:46:23 2019 -0600
Merge pull request #181 from climbfuji/new_metadata_format_step1_20190725
Migrate to new metadata format step 1
commit 4dc853b8ca35494376b8e811f1f2916f61b648a6
Merge: 31e0cc65 c4712c23
Author: Grant Firl <grantf@ucar.edu>
Date: Thu Aug 1 14:00:56 2019 -0600
Merge branch 'gmtb/develop' into add_interstitial_comments
commit 31e0cc65bf4eea12e2072c5f3edd9011c99a1bd1
Author: Grant Firl <grantf@ucar.edu>
Date: Thu Aug 1 13:53:25 2019 -0600
add comments in GFS_driver.F90 and GFS_radiation_driver.F90 to tell users locations of code in the CCPP
commit 5d14eec31116d3b2f4902695c9f12a05f6748d70
Merge: f575b620 417f8ce9
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Jul 31 15:47:56 2019 -0600
Merge branch 'master' of gerrit:FV3 into new_metadata_format_step1_20190725
commit f575b6205aafc91e2d37130febe9a6934e2e352b
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Jul 24 16:44:16 2019 -0400
gfsphysics/GFS_layer/GFS_typedefs.F90: add metadata for new HAFS variable GFS_Control%sfc_z0_type
commit 3990afc75001f55529d0be960ad7ea149715f669
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Jul 31 14:17:45 2019 -0600
Convert CCPP type and variable definitions to new metadata format, introduce variables for all dimensions needed, add comments about further work
commit a3ea903db48889bf163b33f7fbc6644fae8f1731
Author: Grant Firl <grantf@ucar.edu>
Date: Wed Jul 31 12:41:08 2019 -0600
conditionally allocate arrays for Morrison-Gettelman microphysics scheme
commit 7b4db3ea1751644174dc22c1d8f5e34c3176bf12
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jul 25 16:31:42 2019 -0600
gfsphysics/CCPP_layer/CCPP_typedefs.F90, gfsphysics/GFS_layer/GFS_typedefs.F90: substitute dashes with underscores in variable standard names
commit 2cdcc3b4d6af372194c52293b537de759d36bed4
Author: Grant Firl <grantf@ucar.edu>
Date: Sun Jul 21 19:13:19 2019 -0600
add comments in GFS_physics_driver.F90 to tell users locations of code in the CCPP
commit a6ce9d412e31a865116183c817fd5f0db40c44db
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jul 18 10:45:01 2019 -0600
Update CODEOWNERS to enable branch protection
commit 9def0cf844a3bc743c842e35a070128b9fc0035d
Merge: a5c8b40e 780d3a87
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Wed Jul 17 20:48:05 2019 -0600
Merge pull request #179 from climbfuji/add_regression_tests_20190717
gsd/develop: add regression tests for Thompson only, GF only, MYNN only & cleanup
commit 780d3a87df3dd7749d960af0bfac876c553c21a7
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Jul 17 14:13:03 2019 -0600
Remove namelist option make_number_concentrations, this will be used by default for Thompson MP
commit a5c8b40e37ebb410e721e00f04350086b27da834
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Jul 16 15:00:57 2019 -0600
Update CODEOWNERS to GSD team
commit 1cfdbb099f5ff7bcc30e0290ea3c8aaf7f0f714b
Merge: 9595fb7c c4712c23
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Jul 16 14:52:54 2019 -0600
Merge branch 'gmtb/develop' of https://github.com/NCAR/FV3 into HEAD
commit c4712c233cb6cb5d68e1dd050fd3a4889c20f53d
Merge: ae1d3d92 d0359b3f
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Tue Jul 16 14:46:17 2019 -0600
Merge pull request #178 from climbfuji/update_gmtb_develop_from_vlab_master_20190716
Update gmtb/develop from Vlab master 2019/07/16
commit d0359b3f8f8ec129b3be65a6aafde203bbfb4f1f
Merge: ae1d3d92 64fc1f1a
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Jul 16 14:41:30 2019 -0600
Merge branch 'master' of gerrit:FV3 into HEAD
commit 396b10dcbd91c577a0dfb3094e2cd0d463f1046a
Merge: c4ef4b09 e0fed0fd
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Tue Jul 16 14:37:34 2019 -0600
Merge pull request #177 from climbfuji/update_master_github_from_master_vlab
Update master GitHub from master Vlab
commit e0fed0fdda5b8d290cae2a5550f1baf9c8977b92
Merge: c4ef4b09 64fc1f1a
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Jul 16 14:33:18 2019 -0600
Merge branch 'master' of gerrit:FV3 into HEAD
commit ae1d3d92ad53af377789e1b353dbdc96e65cb66c
Merge: 5c1fb7dc 92071555
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Tue Jul 16 14:23:13 2019 -0600
Merge pull request #176 from climbfuji/bugfix_gf_conv_AND_thompson_cleanup_20190709
Bugfix GF convection, Thompson cleanup 2019/07/09
commit 5c1fb7dc24337aecc5abcd08fad0c0c776f43cc6
Merge: 981af01d dfe41ca3
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu Jul 11 08:37:15 2019 -0600
Merge pull request #175 from climbfuji/update_from_github_master_20190708
Update from GitHub (=VLab) master 2019/07/08
commit 9207155591cf01f0825105dcd8f708e32ceeecae
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Jul 9 10:31:31 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.F90: adjust number of tracers in PBL tracer array for Thompson MP, add guard to prevent running Thompson MP with cplchm (not configured)
commit dfe41ca3b68c4fdc6c5c30e6ed1a38a39b25f618
Merge: d27d3473 c4ef4b09
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Mon Jul 8 11:24:40 2019 -0600
Merge branch 'master' of https://github.com/NCAR/FV3 into HEAD
commit d27d34737295bb5f3a30581c92aa11fc665edba1
Merge: 981af01d 3dc7e9b1
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Mon Jul 8 11:24:07 2019 -0600
Merge branch 'master' of gerrit:FV3 into HEAD
commit c4ef4b0944a1dbbea4a371a5f98cf18f407f181e
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Mon Jul 8 08:23:56 2019 -0600
Add CODEOWNERS after mirroring Vlab master
commit 981af01d87d8b302cafd19cfb07e66443f7a18d4
Merge: 66b1f26a 3e3b1b70
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Wed Jul 3 07:58:40 2019 -0600
Merge pull request #173 from climbfuji/cleanup_work_gerrit_codereview_20190701
Cleanup work gerrit codereview 2019/07/01
commit 3e3b1b701466a9884217d36a5e729866acfd7f7d
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Mon Jul 1 13:44:35 2019 -0600
gfsphysics/GFS_layer/GFS_physics_driver.F90: comment out unneccessary/redundant code as per code review
commit 66b1f26a0d5b576c2c7b39d6a009c8fb7d4822c4
Merge: 132bd90d 754129f5
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Sun Jun 30 20:25:43 2019 -0600
Merge pull request #172 from climbfuji/cleanup_work_gerrit_codereview_20190627
Cleanup work gerrit code review part 2 - 2019/06/29
commit 754129f5d24c092edc9e7f91031217a3d6bae485
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Sat Jun 29 09:30:17 2019 -0600
Optimization (CCPP-only): allocate Noah MP restart variables only if Noah MP is actually used
commit 6b54841392e5cc9c9fab6ef3d64ab3af0be8eefb
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Sat Jun 29 06:52:25 2019 -0600
CCPP_layer/makefile, gfsphysics/makefile: set CPP directives for promoting dynamics/fast physics to 32-bit
commit 4899b5d9d979dc96b9f6a1978adf81156867ee81
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Jun 28 14:22:23 2019 -0600
gfsphysics/physics/GFS_debug.F90, gfsphysics/GFS_layer/GFS_physics_driver.F90, gfsphysics/GFS_layer/GFS_diagnostics.F90: bugfixes following the reverse of the Diag%{wet1,sr} -> Sfcprop{wet1,sr} change
commit afb55926beb9255813e011e7c82bbe93c5beefab
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Jun 28 13:48:57 2019 -0600
atmos_cubed_sphere/tools/external_ic.F90: add CPP guard to logic for reading in Thompson aerosols
commit 50576da069d45a9d6602cb9301db04163f3331da
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Jun 28 13:46:49 2019 -0600
gfsphysics/GFS_layer/GFS_physics_driver.F90, gfsphysics/physics/physcons.F90, gfsphysics/physics/sfc_sice.f: revert cimin changes (moved from sfc_sice to physcons) for non-CCPP builds
commit a3f9fefd27f45b6ef64930648532c65c29bcca4c
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Jun 28 13:40:31 2019 -0600
gfsphysics/physics/radiation_clouds.f: fix bug for radiation-clouds in Thompson/WSM6 cloud scheme
commit d01ebbc1205d39e744b40fd4efb202804974fa78
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Jun 28 13:37:46 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.F90, io/FV3GFS_io.F90: RUC now uses srflag and not sr, revert change of moving sr from Diag to sfcprop, and remove sr from restart information for RUC
commit ef9936381fbd26276147ca58010e24a71a25728b
Merge: a00ec683 132bd90d
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 22:45:25 2019 -0600
Merge branch 'gmtb/ccpp' of https://github.com/NCAR/FV3 into cleanup_work_gerrit_codereview_20190627
commit a00ec683be47562518240938f72783f652973c8e
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 22:45:10 2019 -0600
io/FV3GFS_io.F90: rename wetness variable for RUC LSM from wet1 to wetness
commit f0fa127d278f2a1321560e190f7e80698839238e
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 22:43:26 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.F90: use different wetness variables for RUC LSM and other LSMs, update metadata for CCPP
commit 9f21fe1c50dd33e99a8d6d3d94402f0ec01cd192
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 22:41:42 2019 -0600
gfsphysics/GFS_layer/GFS_diagnostics.F90: use different wetness variables for RUC LSM and other LSMs, cleanup code for subsurface variables, rename RUC LSM soill output to slc to be consistent with Noah MP
commit 132bd90db5f033d479eb0892e840cd5b03fa1bb9
Merge: 7ab6d311 00db91cd
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu Jun 27 22:32:52 2019 -0600
Merge pull request #171 from climbfuji/cleanup_work_gerrit_codereview_20190626
Cleanup work for CCPP transition 2019/06/27 - 1
commit 00db91cd2f37e84a747bab70dedbdc607e54ce3b
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 11:21:23 2019 -0600
ipd/IPD_typedefs.F90: cleanup code, remove remaining remnants of old HYBRID build, remove unused IPD_finalize
commit 009d0bf91514ba1fbc69b28014d0b50ff0da0e70
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 11:20:05 2019 -0600
ipd/IPD_driver.F90: cleanup code, remove remaining remnants of old HYBRID build, remove unused IPD_finalize
commit 953cb7f8542b094b10b84bf1eecd0a66cd9944be
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 11:19:12 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.F90: check and remove old comments as needed, remove standard_name for composite dq3dt to prevent its usage, allocate d?3dt arrays for CCPP only if ldiag3d is true
commit 135d62927a63f8487858f94586e81e760f505d5b
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 11:17:14 2019 -0600
gfsphysics/GFS_layer/GFS_driver.F90: cleanup code, remove unused GFS_finalize
commit c0abdb637c9c77df9887d5342c5e4394cee3b311
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 11:16:41 2019 -0600
gfsphysics/GFS_layer/GFS_abstraction_layer.F90: cleanup code, remove remaining remnants of old HYBRID build, remove unused GFS_finalize
commit 9fd64b4d366997fa751c07d46e3d8f9b2bb81945
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 11:16:08 2019 -0600
atmos_model.F90: cleanup code, remove remaining remnants of old HYBRID build
commit 97f665fb5c2436f0f436f51cb77fbabc87e09f31
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 11:15:10 2019 -0600
atmos_cubed_sphere/tools/external_ic.F90: remove unnecessary comments
commit 226b417ac8da6af8bffed3b7567f0a409b311d7f
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 11:14:30 2019 -0600
atmos_cubed_sphere/model/fv_regional_bc.F90: remove unnecessary comments
commit eb1c50563e3f0d6189c01be15b3e4b4b1f12c680
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 11:12:05 2019 -0600
CCPP_layer/CCPP_driver.F90: Simplify physics_init, run over entire domain instead of multiple blocks
commit 00a02ca2cdff5bc5625739015853102d270726af
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Jun 26 11:56:45 2019 -0600
makefile: set SIONLIB_LINK_FLAGS only for CCPP build, do not add to non-CCPP ESMF makefile fragment
commit 7ab6d3111322e306251e50ffc88bd1efa8d7e310
Merge: 386ab989 0e122708
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Wed Jun 26 08:43:58 2019 -0600
Merge pull request #170 from climbfuji/ruclsm_b4b_20190625
RUC LSM b4b through restarts, cleanup for Thompson MP / effective radii / debug output
commit 0e122708f6f8ef3a92ce3ff4638cb9d6b94e115a
Merge: c9cbbc8a 386ab989
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Jun 25 21:25:58 2019 -0600
Merge branch 'gmtb/ccpp' of https://github.com/NCAR/FV3 into ruclsm_b4b_20190625
commit c9cbbc8a21b46987e0fa170650d8117882c40509
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Jun 25 21:25:22 2019 -0600
gfsphysics/physics/GFS_debug.F90: comment out Diag%fluxr components, not required for b4b (purely diagnostic and not in output)
commit 6635068b4dc8b8916fa2903b0e2bf721b0917b9a
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Jun 25 21:24:20 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.F90: improve debug print of dry/wet/icy components of CCPP interstitial type
commit 386ab989b837db3a6bbd9c47c2911673c3c8af6e
Merge: 470681c3 6ce05823
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Tue Jun 25 08:26:01 2019 -0600
Merge pull request #169 from NCAR/bugfix_gfs_phy_tracer_config_suffix
Bugfix gfs phy tracer config suffix .f -> .F
commit 6ce05823d64a49151d38e48a4dc960fd6a6cc3a6
Author: climbfuji <dom.heinzeller@icloud.com>
Date: Tue Jun 25 08:24:16 2019 -0600
Bugfix: fix suffix of physics/gfs_phy_tracer_config.f->F
commit 470681c382fd0d62a3cf45ca372bb06f31e16df9
Merge: d60d8e63 abb621fe
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Fri Jun 21 08:59:35 2019 +0200
Merge pull request #168 from climbfuji/ccpp_github_update_vlab_master_20190611
CCPP GitHub update from VLab master 2019/06/11
commit abb621fe28a61ff26cfc04849217b8cf3030e92d
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Jun 14 09:54:17 2019 -0600
This commit combines three commits to Vlab master (NEMSfv3gfs and FV3):
commit ee9977192f6782df21d2af23979ec67683ac020e
Author: Dusan Jovic <dusan.jovic@noaa.gov>
Date: Mon Jun 10 14:20:34 2019 +0000
NEMSfv3gfs: this commits #refs 56264: support fractional landmask on FV3 grid, and #refs 64400: bug fix for UGW and in CSAW
Change-Id: Id42e31a8b32ba52dd810e98dff059b14135884ec
commit a0fca321ffd9fff1e929c00f3e6d467154610065
Author: Dusan Jovic <dusan.jovic@noaa.gov>
Date: Thu Jun 6 13:54:04 2019 +0000
NEMSfv3gfs: this commits #refs 64015 Add updated scale-aware TKE-based moist EDMF scheme. Updated fv3_cap #refs 62862
Change-Id: Ic6a04044bd2826a3a4be700e77067ff435fadc56
commit a2c9fdabf3aa1e99ab8037c319820c9e440fb894
Author: Jun Wang <jun.wang@noaa.gov>
Date: Tue Jun 4 01:26:37 2019 +0000
NEMSfv3gfs: this commits #refs 61507, coupling Noah MP to fv3gfs
Change-Id: Ia3b86d247d98ee143e47b5e41fce3ae92dde0564
commit d60d8e638f12bc6ebfb77a042b0f75774f47eb5c
Merge: 7d6c9538 d00e8e6d
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu May 30 22:00:51 2019 -0600
Merge pull request #162 from climbfuji/bugfix_fractional_landmask_and_cleanup
Bugfix fractional landmask, scientific documentation update, cleanup
commit d00e8e6d8c80e9f1f409fa3abb52f5a864efd738
Merge: f42c3ed5 7d6c9538
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu May 30 08:41:54 2019 -0600
Merge branch 'gmtb/ccpp' of https://github.com/NCAR/FV3 into bugfix_fractional_landmask_and_cleanup
commit 7d6c95383258c9b9813614953876a191bce8b55b
Merge: 9adc6bc2 e90a8dec
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu May 30 06:34:35 2019 -0600
Merge pull request #161 from climbfuji/gsd_suite_cleanup_and_fractional_landmask_follow_up
GSD suite cleanup and fractional landmask follow up
commit f42c3ed52f50286fa65117c879dd8f0b7d0b0fc3
Author: shan.sun <shan.sun@noaa.gov>
Date: Fri May 24 16:10:37 2019 +0000
1.) Revert back to 1f45136245cde52b39e93ab29f0d36020b0f7e63 :
This rewinds cleanup in sfc_diag.f and GFS_physics_driver.F90
2.) Then, fix bug for ice point to be from ">15%" to ">=15%" to be consistent with initial condition, which defines slmsk=2 for >=15%.
This bugfix is in the following files:
GFS_physics_driver.F90
atmos_model.F90
commit e90a8dec3a9e56357b0a934e6dd02f7b587e3161
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue May 28 15:56:39 2019 -0600
atmos_cubed_sphere/driver/fvGFS/atmosphere.F90: improve error handling/output for CCPP fast physics
commit 43854a221fbf255cc84657b5ea567440855cf2a4
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue May 28 15:09:26 2019 -0600
io/FV3GFS_io.F90: remove temporary filling of top four Noah levels with RUC levels when restarting from RUC LSM data
commit aefb214c4da67cfc78036523c4447092157719a3
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue May 28 15:08:33 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.F90: add consistency check that surface data cycling is turned off when RUC LSM is used
commit 18414f2c682db5da35c8f7861d8eec29ef96b8f1
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue May 28 15:07:54 2019 -0600
gfsphysics/GFS_layer/GFS_diagnostics.F90: write out all subsurface layers for RUC LSM; facilitate and shorten the code for writing out subsurface layers for both RUC and Noah for the CCPP version
commit 9adc6bc261764c18292a3f258a0c6d3888e36c52
Merge: 56bffa38 e79d445f
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Fri May 24 13:59:58 2019 -0600
Merge pull request #158 from climbfuji/remove_hybrid_ccpp
Remove CCPP HYBRID mode
commit e79d445faf8d3d7594034ca0785a9c982a17baea
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri May 24 05:22:57 2019 -0600
gfsphysics/GFS_layer/GFS_physics_driver.F90: rearrange to match Vlab master code more closely
commit 2a61d4a9a15834eb9e02801513b2a4c472c79b0a
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu May 23 16:18:35 2019 -0600
Remove HYBRID CCPP build
commit 56bffa38043839dd3f867aa53d943610cf6e9b13
Merge: 8657c507 83fa5b9f
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu May 23 11:47:19 2019 -0600
Merge pull request #157 from climbfuji/ccpp_cleanup_20190523
CCPP cleanup 2019/05/23 - remove temporary files
commit 83fa5b9f7f5fd8b677635f4d76813d122fcb3c98
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu May 23 11:21:35 2019 -0600
Remove temporary files gfsphysics/GFS_layer/GFS_typedefs.{ipd,ccpp}.F90 and remove comments to them in gfsphysics/makefile
commit 8657c5074300810430692760ce475649c3119070
Merge: 789a135d 54fecdda
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu May 23 10:53:59 2019 -0600
Merge pull request #156 from climbfuji/cleanup_ccpp_build
CCPP cleanup 2019/05/13
commit 54fecdda7f950ef9afbe3d8700174d7ba8cfa03a
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Mon May 20 16:06:06 2019 -0600
gfsphysics/makefile: remove two-step compilation of GFS_typedefs.F90, this causes compile errors with Intel (compiler bug)
commit c885e896eb0b058e82fa50345ec0ce7f07056329
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Mon May 20 14:06:11 2019 -0600
TEMPORARY: add original, merged GFS physics driver as gfsphysics/GFS_lay…
climbfuji
added a commit
to climbfuji/fv3atm
that referenced
this issue
Apr 14, 2020
- RRTMGP in CCPP
- build system improvement: get CCPP kind and type definitions from CCPP framework, remove libxml2 from static CCPP build
- cleanup radiation tendencies in CCPP
- required cmake version now 3.0
- missing code changes for MG-IN-CCN update (from code review)
Squashed commit of the following:
commit 50c6de3fe781acb861cac617296380b571c3fd27
Merge: f089bbf 9cec3b5
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Tue Apr 14 06:59:19 2020 -0600
Merge pull request #42 from climbfuji/update_dtc_develop_from_emc_develop_and_missing_ccnin_updates
Update NCAR dtc/develop from EMC master, apply missing updates from CCN/IN commit
commit 9cec3b5f0f7a527a6496380442f7c5a4f32d1852
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Tue Apr 14 06:56:46 2020 -0600
Revert change to .gitmodules and update submodule pointer for ccpp-physics
commit 27ce0d4f6d45fef08ba8ea040fef5cdb1e9f42b7
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Fri Apr 10 14:21:54 2020 -0600
Update .gitmodules and submodule pointer for ccpp-physics for code review and testing
commit 50501ec2b925fb2ffd6f4ff6c61c08801c334933
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Fri Apr 10 14:21:26 2020 -0600
Apply missing updates for MG-IN-CCN changes
commit 2130922d485efe285b099c08c400d77b601dd1fe
Merge: f089bbf 9b5a420
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Fri Apr 10 13:55:33 2020 -0600
Merge branch 'develop' of https://github.com/NOAA-emc/fv3atm into HEAD
commit f089bbfd58e1e59662b28a1437f1fa570b55e0ac
Merge: f0e8d7c 96be1d3
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Fri Apr 10 11:36:13 2020 -0600
Merge pull request #40 from climbfuji/update_dtc_develop_from_emc_develop_and_other_updates_20200409
Update dtc/develop from develop and other updates 2020/04/09
commit 96be1d3acc831eadc7ad656aa99438d93847514c
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Fri Apr 10 11:34:34 2020 -0600
Revert change to .gitmodules and update submodule pointers for GFDL_atmos_cubed_sphere, ccpp-framework and ccpp-physics
commit 2e8645640d0ff6ddf74b9c66b2fa32dd2b823cb2
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Apr 9 20:23:32 2020 -0600
Update .gitmodules and submodule pointers for ccpp-framework, ccpp-physics, GFDL_atmos_cubed_sphere for code review and testing
commit 931dc325ab37a0a2dc8d20ebad0e777084694619
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Apr 9 20:22:56 2020 -0600
ccpp/CMakeLists.txt: require cmake 3.0, remove legacy syntax for policy CMP0048
commit 2f1a5c56a7d45a0de58ba47624f25a4be5e143e1
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Apr 9 20:21:20 2020 -0600
gfsphysics/physics/ugwp_driver_v0.f: comment out unnecessary prints to stdout that pollute the model output
commit 13cc9eae66932f93baefc4a18508c264f72d5c59
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Tue Jan 21 08:14:41 2020 -0700
CMakeLists.txt: add dependency on CCPP for fv3cap library
commit cfa55411f69c3c3000f7f3f5211c9b0c1bfd96e6
Merge: f0e8d7c 7c3eade
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Apr 9 10:34:58 2020 -0600
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into HEAD
commit f0e8d7cede7c82feaff332f000661e01ae61490a
Merge: 485de28 d444a9a
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Fri Apr 3 15:32:38 2020 -0600
Merge pull request #36 from climbfuji/update_submodule_pointer_ccpp_physics_20200403
dtc/develop: update submodule pointer for ccpp-physics 2020/04/03
commit d444a9a402a9110474a528abe4564d1fc5e6ddfe
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Fri Apr 3 15:29:52 2020 -0600
Update submodule pointer for ccpp-physics
commit 485de283183371f91a7ce454cc3186690bbef427
Merge: 59e02cc 053edd9
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Fri Apr 3 11:46:54 2020 -0600
Merge pull request #35 from climbfuji/avoid_recompile_without_change
dtc/develop: speed up static compilation
commit 053edd9103e23479601f7e5f2473bd4e767b5656
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Fri Apr 3 11:45:49 2020 -0600
Revert change to .gitmodules, update submodule pointers for ccpp-framework and ccpp-physics
commit f95cedbbbf0eb864bb5c78063757816de2fb22b8
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Apr 2 13:56:45 2020 -0600
Update .gitmodules and submodule pointers for ccpp-framework and ccpp-physics for code review and testing
commit 59e02cc293f488c04d9969a834ae75a78a40ce2a
Merge: 3ffe2b4 18f7cef
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu Apr 2 08:13:37 2020 -0600
Merge pull request #34 from climbfuji/cleanup_radiation_tendencies
Cleanup radiation tendencies (standard names and allocation)
commit 18f7cef3a2d411206a3e05194516ed851d9db6d4
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Apr 2 08:12:17 2020 -0600
Revert change to .gitmodules and update submodule pointer for ccpp-physics
commit e05ad13ee0d9aceb6b5990d4abe6363e6665c7e7
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Wed Apr 1 10:09:04 2020 -0600
Clean up of radiation tendencies standard names as described in issue https://github.com/NCAR/ccpp-physics/issues/179; move radiation tendencies on radiation timestep and radiation levels from GFS_tbd_type to GFS_interstitial_type
commit 14becd4000df1702e5e40c21614199b8376c3721
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Wed Apr 1 10:07:37 2020 -0600
Update .gitmodules and submodule pointer for ccpp-physics for code review and testing
commit 3ffe2b42702f0bd001a1b57fe8caf680548e08c1
Merge: 8672795 d1b1548
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu Mar 26 10:34:46 2020 -0600
Merge pull request #32 from climbfuji/add_rrtmgp_dom
RRTMGP in fv3atm (#26 - based on latest code)
commit d1b15481b46fed96c3665a1e0874b19baf202d16
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Mar 26 10:33:34 2020 -0600
Revert change .gitmodules and update submodule pointers for ccpp-framework and ccpp-physics
commit cc4b75d65a9047d261bd172c3d7e7e7cea1a8caf
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Mar 26 10:10:42 2020 -0600
Add guard to GFS_typedefs.F90 to prevent running RRTMGP with levr<levs
commit c678c68cf3b29fd238d0d9145f77627a346f03e5
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Wed Mar 25 14:39:45 2020 -0600
gfsphysics/GFS_layer/GFS_typedefs.F90: re-enable initialization/resetting of Diag%rain and Diag%rainc
commit 3815ff163afcea2f400114d06c2a37600fc6d6d8
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Wed Mar 25 06:24:37 2020 -0600
Update submodule pointer for ccpp-framework after merging Python 3 compatibility PR
commit 8f9871e5c6e86f4b593b67303dba65ba389f17c7
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Mon Mar 23 18:43:02 2020 +0000
Cleanup RRTMGP optional argument logic.
commit 0af00782d5cc4a1068b3e6c6a130e702e805b801
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Mar 19 20:32:07 2020 -0600
From @dustinswales: bugfix for optional arguments for RRTMGP in ccpp/config/ccpp_prebuild_config.py
commit 041ea4c5188958fa34c3efe08cd0cec7dac86877
Merge: 51ffb8e 515a83f
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Mar 19 11:53:12 2020 -0600
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into add_rrtmgp_dom
commit 51ffb8eb2c8bc2740f89b08b00a755e58f4e620d
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Mar 19 11:29:16 2020 -0600
Update to CCPP prebuild config and make/cmake build systems to accommodate latest changes in ccpp-framework
commit 58977b70feaec4dfa87457e47c917a01622ba235
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Mar 19 11:28:36 2020 -0600
Remove dcyc2t3_post from RRTMGP SDF, rename doRRTMGP to do_RRTMGP to be consistent with other do_XYZ flags in GFS_typedefs
commit b14368a04112d8fd9ad45801c356025e23c3bd6a
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Tue Mar 17 15:49:29 2020 -0600
Formatting changes to several files; reversal of changes to gfsphysics/makefile; update .gitmodules for code review and testing; update submodule pointer for ccpp-physics and ccpp-framework
commit d196b0e0fdf086bb72ae2579544369ffd2b66500
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Tue Mar 17 15:36:12 2020 -0600
Squashed commit of the following:
commit 6266b7bd7f9cefdbacf6ec03be74e1b998ab7fd5
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Fri Mar 6 18:53:55 2020 +0000
Zeroed out rrtmgp fields in GFS_typedefs.F90
commit be22b66f67078e0e29906f686328ea7a6e47d06a
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Fri Mar 6 16:58:20 2020 +0000
Added logic so that RRTMGP fields are only allocated if RRTMGP is used.
commit bbd4bbc6033977dca139b73b8794fa2edafaf63c
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Thu Mar 5 21:41:41 2020 +0000
Reverted some changes.
commit 7d784e424762211d81b54236c1e686422b392eb8
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Thu Mar 5 21:30:52 2020 +0000
Some housekeeping...
commit 40697859947f13ac0f204a93d75b30c4f79bae7a
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Thu Mar 5 21:14:29 2020 +0000
Updated ccpp submodules. Synced w/ upstream
commit 14be13f19f93f3b22aa76503fc9ed208a65364a2
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Wed Feb 19 18:16:51 2020 +0000
Some cleaning up. Updated submodules.
commit 84c18bd9cf0489a49866a8990469fdd5a630e3d8
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Sat Feb 15 00:01:16 2020 +0000
Updated submodules.
commit 1e05a16ac48101064e46937552355e0751ca09ce
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Mon Feb 10 23:49:16 2020 +0000
Updated submodules.
commit 6959f09095ba386ccb6a4f79ff4e2b0b50a672d0
Merge: a3c1cd8a 756ef51a
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Mon Feb 10 17:56:49 2020 +0000
Merge branch 'dtc/develop' of https://github.com/NCAR/fv3atm into rrtmgp-dev
commit a3c1cd8a2d6cbe38fe67372d0ef5e1a43370f09f
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Mon Feb 10 17:47:17 2020 +0000
Updated ccpp-physics submodule.
commit a255a636357584db690e810a0977277805f054a0
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Fri Dec 13 22:16:07 2019 +0000
Updated submodules
commit 0aea78e5ce8e4218c90ac4bdebdca04679811177
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Tue Dec 10 22:55:26 2019 +0000
Updated ccpp-physics submodule.
commit 09c2d77171e5ea0d1550f9f2d95120c0e7075e51
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Thu Dec 5 01:47:56 2019 +0000
Small change to GFS_typedefs.F90
commit 4de65fd50d87ce529e2403d5b1c1fc2b45a52c35
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Wed Dec 4 21:20:49 2019 +0000
Omission from previous commit.
commit 05179a163f8a1659ee8dcabc52ecdca1a1a7f9d1
Merge: ab209723 88e87e9b
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Wed Dec 4 21:08:27 2019 +0000
Merge branch 'dtc/develop' of https://github.com/NCAR/fv3atm into rrtmgp-dev
commit ab209723dd75f49ba99cdadbb4dad4a077a9a975
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Wed Dec 4 21:05:46 2019 +0000
Updated submodules.
commit 945ba98dc1100f2d08b6e804784ce5f4f5df8c96
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Thu Nov 21 21:33:28 2019 +0000
Cleaning up my mess.
commit 541a2800e695eb9c0e956d65e4f8388344eca47f
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Thu Nov 21 20:48:13 2019 +0000
Update submodule
commit 7566264e6e02ade0f8f40bfe9c4735f944a43e31
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Thu Nov 21 17:26:50 2019 +0000
Updated .gitmodule
commit 47418d31cca36db3c405be1a0c58448885ae371f
Merge: 221faed5 53e6b771
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Thu Nov 21 17:18:21 2019 +0000
Merge branch 'rrtmgp-dev2' of https://github.com/dustinswales/FV3 into rrtmgp-dev
commit 221faed57683d85d93a3f7b26ac032c2ec845b11
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Thu Nov 21 16:55:50 2019 +0000
Initial commit. Switched ccpp/physics to rrtmgp-dev repository
commit 53e6b771de7668c25b417f0d6d35ce9bb8898574
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Thu Nov 7 23:14:05 2019 +0000
Moved field from radtedn type to interstitial type.
commit c0f195758b91dce864487780d847bac226139797
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Tue Oct 29 14:19:07 2019 +0000
Moved RRTMGP active gases from GFS_radtend_type to GFS_control_type.
commit 323dfc61d3656c5330152acdcc7a19f35b263ccf
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Mon Oct 21 20:41:08 2019 +0000
gfsphysics building!
commit 0f38e6b700c34046cb3823ca806418d40e3bf6a3
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Fri Oct 18 17:21:49 2019 +0000
Reverted makefile
commit 226124b938decd3419e34b5ca2b1f50250b74851
Author: Dustin Swales <dustin.swales@noaa.gov>
Date: Thu Oct 17 17:49:10 2019 +0000
-
commit 7ae1b6e9cd0075e8443ce10b7c8ea6b0ccc3d22d
Merge: 474dfaf0 2f738680
Author: dustinswales <dustin.swales@noaa.gov>
Date: Thu Oct 17 10:46:13 2019 -0600
Merge pull request #1 from NCAR/gmtb/develop
Gmtb/develop
commit 2f73868081547b7373f7d47558fd96e9a42ae5e6
Merge: 2fbfebec 5c67f0a9
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Wed Oct 16 07:36:10 2019 +0900
Merge pull request #218 from climbfuji/update_gmtb_develop_from_vlab_master_20191003
Update GitHub NCAR gmtb/develop from VLab EMC master 2019/10/13
commit 5c67f0a979c5a0405a5eaffaa014b9457210e7f7
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Tue Oct 15 09:20:31 2019 +0900
Add stub post_gfs module that is used if -DNO_INLINE_POST is specified, this causes any test using inline post to fail
commit 29ac2cbc8c7a2cc3f0403b1f6bdbe7c738497d51
Author: Jun.Wang <Jun.Wang@noaa.gov>
Date: Mon Oct 7 17:55:48 2019 +0000
FV3: this commits #refs 66932, inline post
Change-Id: I9e685a7b5d4b6b8535fc5f107b42bbdaed47c443
commit 2fbfebec19443fe717e8add62d0a127e5415a188
Merge: 84434e25 9fb8cbbd
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Sun Oct 13 14:41:38 2019 +0900
Merge pull request #217 from climbfuji/fv3_update_submodule_pointer_2019101
Update submodule pointer for atmos_cubed_sphere
commit 9fb8cbbdc0ed081e6172bb15a93b60754d9d889d
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Sun Oct 13 14:40:02 2019 +0900
Update submodule pointer for atmos_cubed_sphere
commit 84434e2586127ca85845623b9370f9e0053d877f
Merge: 474dfaf0 b81b8191
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Sat Oct 12 08:45:10 2019 +0900
Merge pull request #213 from climbfuji/update_gmtb_develop_with_vlab_master_20191006
Update NCAR gmtb/develop with EMC Vlab master 2019/10/06
commit b81b8191dbb81aa9dd24ec00be953649454764c2
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Oct 10 20:38:44 2019 +0900
gfsphysics/GFS_layer/GFS_physics_driver.F90: bugfix for PBL post for MG2/MG3
commit bea8d7e3f4ec06bbf923f00098622be493ba6579
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Thu Oct 10 10:59:07 2019 +0900
gfsphysics/physics/sfcsub.F: transferring bugfix for lbms allocation from CCPP to IPD
commit 48f24c8dfc3853ac9faacd2c182c3dfd3348caa7
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Wed Oct 9 11:05:51 2019 +0900
gfsphysics/GFS_layer/GFS_physics_driver.F90: bugfix, remove if(cplchem) test for Zhao-Carr MP
commit b12b93b76da7de53cc7fa6f3faf0bf3333e45274
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Tue Oct 8 09:03:11 2019 +0900
gfsphysics/GFS_layer/GFS_typedefs.F90: reintroduce interstitial variables for NoahMP, change existing IPD type for Julian day from 'integer' to 'real(kind_phys)' remove redundant CCPP definitions
commit d5101c8229483a44af508170747f7c1454bae9dd
Author: Dom Heinzeller <climbfuji@ymail.com>
Date: Mon Oct 7 12:16:23 2019 +0900
Updates for CCPP GFSv16
commit 415c943a9b81258b691b036cd097e0b8384d9e0c
Author: Jun.Wang <Jun.Wang@noaa.gov>
Date: Wed Oct 2 19:27:36 2019 +0000
FV3: this commits the missed code changes in #68128
commit 5b5107fe68dad4825c78cc2eab74ee1c779467a6
Author: Jun.Wang <Jun.Wang@noaa.gov>
Date: Thu Sep 26 20:12:38 2019 +0000
FV3: this commits #refs: #68678,#68141,#68128,#68694,#68982,#67925
Change-Id: Ie4b75858dadbe1975449b9d734a1c6f1e6541b89
commit 474dfaf0a7a76912fc674b8d68877919b0e69aa8
Merge: d7699bab 36f4fb80
Author: grantfirl <grantf@ucar.edu>
Date: Thu Oct 3 11:12:04 2019 -0600
Merge pull request #211 from climbfuji/drag_suite_dom
gmtb/develop: follow-up PR for GSD drag suite
commit 36f4fb80f534f69baddf47b7660b44205366e85a
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Sep 27 16:41:43 2019 -0600
Reapply metadata cleanup work
commit 2e74a5104034dc3dbe263266c19a801158422fde
Author: Michael Toy <michael.toy@noaa.gov>
Date: Tue Sep 24 21:23:56 2019 +0000
Added changes to gfsphysics/GFS_layer/GFS_typdefs.meta that didn't get included in yesterdays PR.
commit 336b6d038db9698da944a1bd8cecf93a31f5cf54
Author: Michael Toy <michael.toy@noaa.gov>
Date: Mon Sep 23 13:30:59 2019 +0000
Added GSD drag suite to ccpp.
commit d7699bab4b20211db4a8ca3988e3ee8a744ab46f
Merge: 86ad37a1 fadbbda0
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Mon Sep 23 10:13:22 2019 -0600
Merge pull request #209 from climbfuji/update_submodule_pointer_atmos_cubed_sphere_20190923
Update submodule pointer for atmos_cubed_sphere 2019/09/23
commit fadbbda009dfccf66cecf814bf1c5475329e1a71
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Mon Sep 23 10:11:18 2019 -0600
Update submodule pointer for atmos_cubed_sphere
commit 86ad37a15dbd7e99f732c80cb758fad541535326
Merge: d02e260c ef0469fc
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Mon Sep 23 09:33:13 2019 -0600
Merge pull request #207 from climbfuji/gmtb_develop_update_from_master_20190920
gmtb/develop update from master 2019/09/20, remove TRANSITION mode
commit ef0469fcb5345d472324720e3c0043b65507c0bd
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Sep 20 08:53:31 2019 -0600
Remove TRANSITION mode
commit 65bfa600345eed605ac580fd35c984c1d915d405
Merge: 545a5ab4 b67d9a39
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Sep 20 07:23:01 2019 -0600
Merge branch 'master' of gerrit:FV3 into gmtb_develop_update_from_master_20190920
commit 545a5ab4fb70f5c7e9164107fb6f77d5ea94128e
Merge: d02e260c 42915ea8
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Sep 20 06:59:23 2019 -0600
Merge branch 'master' of https://github.com/NCAR/FV3 into HEAD
commit d02e260c161addf0bc6589b8f91a6098c4cd57ab
Merge: 9ad93730 fd8f98a4
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu Sep 19 14:40:14 2019 -0600
Merge pull request #206 from climbfuji/myj_with_dom_mods
gmtb/develop: MYJ PBL/SFC, Noah MP
commit fd8f98a43258d9f593fff11f14c4216fca484cfd
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Mon Sep 16 15:30:40 2019 -0600
gfsphysics/GFS_layer/GFS_driver.F90, gfsphysics/makefile, io/FV3GFS_io.F90: re-enable calculation of snocvr in FV3-IPD to avoid b4b issues when 32BIT=Y
commit daab7457cf08c205c5016c8ec7865fbb08b8495f
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Sep 13 16:29:43 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.{F90,meta}: introduce lower bound variable for snow-related arrays in NoahMP, use in metadata table
commit 243977dd91ea022a76dd799f5810357117af13ad
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Sep 13 16:28:01 2019 -0600
gfsphysics/GFS_layer/GFS_driver.F90: update comment on CCPP code
commit 03b00f445c72e1617bef13971cf2b5dd2c4e412f
Merge: 1bb9ab50 c83f1f73
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Sep 13 15:28:19 2019 -0600
Merge branch 'noahmp' of https://github.com/grantfirl/FV3 into myj_with_dom_mods
commit 1bb9ab5097d9906db571d4b4f40211646e23b3a2
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Sep 13 15:28:16 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.F90: remove empty line
commit 1627b2359bc490d4cce58a47ffccbc1c27a61ad9
Merge: 7da9ed85 9ad93730
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Sep 13 15:00:37 2019 -0600
Merge branch 'gmtb/develop' of https://github.com/NCAR/FV3 into myj_with_dom_mods
commit 9ad93730b81314d1ffaf0b98cd81e7d442ccf874
Merge: 1fa34bc4 43544887
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Fri Sep 13 15:00:08 2019 -0600
Merge pull request #204 from climbfuji/correct_longnames_20190909
gmtb/develop: correct long names, align with SCM
commit 7da9ed859921d2ffe1ffdcf6f17ae2ae58449050
Merge: 43544887 bcfed5b2
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Sep 13 10:49:16 2019 -0600
Merge branch 'myj_from_qingfu' into correct_longnames_20190909
commit 43544887d2b6624606dc82f30e4854dc49f23d20
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Sep 12 21:11:20 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.meta: correct longnames and align with SCM
commit c83f1f738b60772b2ae4dff6f6e2434ccc42bc04
Author: Grant Firl <grantf@ucar.edu>
Date: Tue Sep 10 17:37:42 2019 -0600
update comments in GFS_physics_driver.F90 for locations of NoahMP-related code
commit b4a674d9ae4144f25261943bf8a4481d09debe96
Merge: 36ab5be0 1fa34bc4
Author: Grant Firl <grantf@ucar.edu>
Date: Tue Sep 10 17:26:13 2019 -0600
Merge branch 'gmtb/develop' into noahmp
commit 1fa34bc41fe59e9efbb12aeab474c83bf7670420
Merge: 028a54ec 67db064b
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Sun Sep 8 20:32:08 2019 -0600
Merge pull request #203 from climbfuji/gmtb_develop_monster_merge_20190904
Merge gsd/develop, update from Vlab, separate stochastic physics from IPD and CCPP
commit 36ab5be04ffa4e0aabbe7cdae36c378881513739
Author: Grant Firl <grantf@ucar.edu>
Date: Fri Sep 6 15:15:24 2019 -0600
change location of interstitial calculation for NoahMP in comments
commit c1d7a918a84ea7cf64f0b63948be73253584663a
Author: Grant Firl <grantf@ucar.edu>
Date: Fri Sep 6 12:06:09 2019 -0600
fix bugs in FV3GFS_io.F90 related to #ifdef CCPP directives and noahmp
commit 6e8b0cedd9d98ed469366603bae0bb95bc68a9b2
Author: Grant Firl <grantf@ucar.edu>
Date: Wed Sep 4 22:09:28 2019 -0600
add t2mmp and q2mp to interstitial variables for noahmp
commit 42915ea8e753f8be859f6ebf4f5983b4c78b695f
Merge: b30a69a1 1d823f84
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Wed Sep 4 16:41:50 2019 -0600
Merge pull request #202 from climbfuji/github_master_update_from_vlab_master_20190904
Update GitHub master from Vlab master 2019/09/04
commit 67db064b8d7b2e4b8692c8d5927a6897d49607d3
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Sep 4 15:39:01 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.F90, gfsphysics/GFS_layer/GFS_typedefs.meta: add interstitial variables and their initialization, add metadata
commit 635bd9f4f39f219fd6599ab724819db0279bc537
Author: Grant Firl <grantf@ucar.edu>
Date: Wed Sep 4 13:05:15 2019 -0600
swap metadata for a couple of NoahMP precip variables
commit 0b385edcb8344f0e2f515c63d91c27f43155d351
Author: Jun.Wang <Jun.Wang@noaa.gov>
Date: Tue Sep 3 01:37:04 2019 +0000
FV3: this commits #refs 67151, Add aerosol transport to SAMF deep convection scheme, #refs 67152, Export instantaneous convective specific humidity tendency
commit 599dd26768fb988763d6ad2c887432dbfe540d0b
Author: Grant Firl <grantf@ucar.edu>
Date: Wed Sep 4 10:52:25 2019 -0600
remove accidentally reverted change in GFS_physics_driver.F90
commit 1d823f846d64a4c6155565042c36f93a281a6887
Author: Jun.Wang <Jun.Wang@noaa.gov>
Date: Tue Sep 3 01:37:04 2019 +0000
FV3: this commits #refs 67151, Add aerosol transport to SAMF deep convection scheme, #refs 67152, Export instantaneous convective specific humidity tendency
commit f3b64a02ce0f6703b2b0ff60265a91f896e2a0c7
Author: Grant Firl <grantf@ucar.edu>
Date: Wed Sep 4 10:40:11 2019 -0600
remove conversion factor-based directives in GFS_diagnostics.F90
commit 39667a94d78187149a373029ac5bf008ab434fcc
Merge: 5babb964 028a54ec
Author: Grant Firl <grantf@ucar.edu>
Date: Wed Sep 4 10:31:50 2019 -0600
Merge branch 'gmtb/develop' into noahmp
commit fedc6695589c70f0415f9c8914d4e91b649fe937
Merge: 3332314b 179cbe76
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Sep 4 09:08:10 2019 -0600
Merge branch 'gsd/develop' of https://github.com/NCAR/FV3 into gmtb_develop_update_from_master_20190830
commit 3332314b09fa3a373e0ab132165a1453f6b23fa3
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Sep 4 08:27:44 2019 -0600
Bugfixes in gfsphysics/GFS_layer/GFS_driver.F90, gfsphysics/GFS_layer/GFS_typedefs.F90 and gfsphysics/GFS_layer/GFS_typedefs.meta following the merge of the stochastic_physics separation PR
commit 5babb964462e6913e3093462522b2430483905ea
Author: Grant Firl <grantf@ucar.edu>
Date: Tue Sep 3 15:50:59 2019 -0600
remove directives in FV3GFS_io.F90 limiting NoahMP to non-CCPP build; add noahmp_tables.f90 (data only) to makefile for CCPP build (needed in FV3GFS_io.F90 for noahmp cold starts)
commit ede4f37077c866bffb87261edf38e7a8ee388b67
Merge: a721e0d3 45ceeac4
Author: Grant Firl <grantf@ucar.edu>
Date: Tue Sep 3 14:26:19 2019 -0600
Merge branch 'fix_sncovr' into noahmp
commit dbef968c7985c72dc9eabf75f5e65141506dbd38
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Jul 10 08:04:32 2019 -0600
namphysics/NAM_layer/NAM_typedefs.F90, namphysics/NAM_layer/NAM_driver.F90: add new component blksz(:) to NAM_control (GFS_control) DDT, pass to init routine
commit c79b844b35a101db7ed3971d0be7c6077c085cb7
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Jul 9 14:57:36 2019 -0600
makefile: build_stochastic physics independently of IPD or CCPP in directory ../stochastic_physics
commit 278a1f1aa0915b1bcccc86779cc7bd65ee42bc3b
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Jul 9 14:56:42 2019 -0600
atmos_model.F90: call stochastic physics independently of IPD or CCPP
commit 24543a1c4365485d782fa29de647512ef384ec81
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Jul 9 14:41:17 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.F90: remove variables for CCPP that are no longer required, add blksz as component to GFS_control also for IPD (is already for CCPP)
commit 76dccf55128cd961461688f2df3a3bd88d5189e0
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Jul 9 14:38:40 2019 -0600
(1) remove directory stochastic_physics
(2) gfsphysics/GFS_layer/GFS_driver.F90: remove calls to stochastic_physics, make Init_parm%blksz an input argument to Model%init for both IPD and CCPP
commit 028a54ec8e0596892f9bc01d63df7a1c4867ec41
Merge: d04664e7 62fb7fb3
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Tue Sep 3 09:20:05 2019 -0600
Merge pull request #199 from climbfuji/gmtb_develop_update_from_master_20190830
gmtb/develop: update from master 2019/08/30
commit b30a69a16b0b9cd91b49fe20ea4cf5773e65f26e
Merge: 127baf51 a47b7fc2
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Tue Sep 3 08:21:34 2019 -0600
Merge pull request #200 from climbfuji/update_submodule_pointer_in_FV3_20190903
master: update submodule pointer for atmos_cubed_sphere
commit a47b7fc2dfe3612b8d0ee8af6d523e3995cc93d8
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Sep 3 08:19:46 2019 -0600
Update submodule pointer for atmos_cubed_sphere
commit 127baf51f612a7c7f04ebe160b28657773840bac
Merge: ef8bb547 088e5fa1
Author: Laurie Carson <carson@ucar.edu>
Date: Mon Sep 2 14:12:30 2019 -0600
Merge pull request #198 from climbfuji/update_from_noaaemc_dev_20190830
Update GitHub NCAR master from Vlab master
commit 45ceeac46d3f3f6dbdcef9bfd9cd43bdc2b1c92c
Author: Grant Firl <grantf@ucar.edu>
Date: Fri Aug 30 16:04:41 2019 -0600
remove calculation of sncovr from FV3GFS_io.F90 and from the makefile (for CCPP build)
commit 62fb7fb3cf5900e6f71c4a7a52f6d6fbc3b629a1
Author: Jun.Wang <Jun.Wang@noaa.gov>
Date: Tue Aug 27 20:17:31 2019 +0000
FV3: This commits #refs 66699, Calling radiative transfer parameterizations on each physics time step and #refs 66931,fix time window for accumulated fields in fv3 with IAU
commit 9265ae03ec7af41420210a427149268118d81846
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Aug 30 12:04:36 2019 -0600
Update .gitmodules and set default branch for atmos_cubed_sphere to gmtb/develop, update submodule pointer
commit 1028b3f905d7f74f173a854d55fdc0a2ca6b7c82
Author: Jun.Wang <Jun.Wang@noaa.gov>
Date: Sun Aug 25 02:54:03 2019 +0000
FV3: this commits #59519, separate FV3 dynamical core repository from FV3
commit 088e5fa16afc1b3ffd3932294de83aa72c7971ac
Author: Jun.Wang <Jun.Wang@noaa.gov>
Date: Tue Aug 27 20:17:31 2019 +0000
FV3: This commits #refs 66699, Calling radiative transfer parameterizations on each physics time step and #refs 66931,fix time window for accumulated fields in fv3 with IAU
commit cf98bfae384ee3cb2969c69fafa19f79156ed15d
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Aug 30 08:36:09 2019 -0600
Update .gitmodules to point to NCAR fork of GFDL_atmos_cubed_sphere
commit 31e13942a8e543e365216b134895e6ceffef8a83
Author: Jun.Wang <Jun.Wang@noaa.gov>
Date: Sun Aug 25 02:54:03 2019 +0000
FV3: this commits #59519, separate FV3 dynamical core repository from FV3
commit d04664e793f8cff5502a5127ce03f1e19352f676
Merge: 47fa9fbb a5d2226d
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Fri Aug 30 07:39:08 2019 -0600
Merge pull request #195 from climbfuji/github_gmtb_develop_address_physics_issue_300_and_coupled_code
GitHub gmtb develop address physics issue 300 and coupled code
commit ef8bb5470f7d53b4afc6087f7f601f4b8cd8ee80
Merge: 8a863586 bd46b82d
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu Aug 29 15:33:03 2019 -0600
Merge pull request #197 from grantfirl/master
add Julie as codeowner
commit 47fa9fbb67fdfe1d7ace52282fc8974eea9b1a03
Merge: 21fdde6b 561eb79d
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu Aug 29 15:32:36 2019 -0600
Merge pull request #196 from grantfirl/gmtb/develop
add Julie as codeowner
commit bd46b82d013091fcf36f75ab04624c55efd96dd3
Author: Grant Firl <grantf@ucar.edu>
Date: Thu Aug 29 15:07:57 2019 -0600
add Julie as codeowner
commit 561eb79d9133f1b285eb1503bbad5c24d6f460dc
Author: Grant Firl <grantf@ucar.edu>
Date: Thu Aug 29 15:05:15 2019 -0600
add Julie as codeowner
commit a5d2226d5d37464e9feea05b32db08572468fb16
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Aug 28 17:29:25 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.meta: rename instantaneous_upward_sensible_heat_flux to instantaneous_surface_upward_sensible_heat_flux_for_chemistry_coupling
commit 5fac92183886479afc473bd01b9cd70840bd54fc
Merge: b803db91 7ffc16a7
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Aug 28 10:03:12 2019 -0600
Merge branch 'gmtb/develop' of https://github.com/panll/FV3 into HEAD
commit b803db9182aad295b64e9d62052a4e601dd029fe
Merge: 21fdde6b fd929f17
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Aug 28 10:02:36 2019 -0600
Merge branch 'fix_LSM_units' of https://github.com/grantfirl/FV3 into HEAD
commit 179cbe760b1d06960fecafb811241f0a6f2293d4
Merge: 0591b5c5 7994ef98
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Tue Aug 27 16:38:23 2019 -0600
Merge pull request #190 from grantfirl/fix_RUC_LSM_precip_partitioning
Address ccpp-physics issue #301
commit 21fdde6b7db39fa24ff667a42b3f79edeab50e1e
Merge: a26436be 2f5bd1ef
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Tue Aug 27 16:29:54 2019 -0600
Merge pull request #194 from climbfuji/gmtb_develop_fix_RUC_LSM_precip_partitioning
gmtb/develop: address issue #301 (fix RUC LSM precip partitioning)
commit fd929f175da3b3e3ba16c0984f46f97e6246c1be
Author: Grant Firl <grantf@ucar.edu>
Date: Tue Aug 27 16:27:48 2019 -0600
fix soil moisture units in non-CCPP sfc_drv.f and sfc_noahmp_drv.f
commit a721e0d3c2913dd1fa174b0fb3741b802e5b4c4f
Author: Grant Firl <grantf@ucar.edu>
Date: Tue Aug 27 15:02:51 2019 -0600
remove stop for NoahMP LSM through CCPP in GFS_typedefs.F90
commit dcd9771211b2476000e968b02ebedc7e35f0f4a7
Author: Grant Firl <grantf@ucar.edu>
Date: Tue Aug 27 13:43:37 2019 -0600
wrap removal of conversion factors for 3 variables in GFS_diagnostics.F90 in #ifndef CCPP directives
commit 2f5bd1ef13db0b857b03b2e43f7b5bfb930d8470
Author: Grant Firl <grantf@ucar.edu>
Date: Tue Aug 20 14:13:34 2019 -0600
fix CCPP metadata for convective/non-convective precip variables used in RUC LSM
commit a26436be1da9816330d375fb111e79204398aaee
Merge: 44d95416 63633922
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Tue Aug 27 07:13:16 2019 -0600
Merge pull request #186 from bluefinweiwei/cires_ugwp
UGWP Version 0
commit bcfed5b20a6b18f5e9ad96b16763889a0fb0c4b6
Author: Qingfu Liu <Qingfu.Liu@noaa.gov>
Date: Tue Aug 27 11:17:39 2019 +0000
add MYJ surface layer scheme and MYJ PBL scheme to CCPP
commit 2f5183ea7052fa39592f8b0fbec36326174526c9
Author: Grant Firl <grantf@ucar.edu>
Date: Mon Aug 26 13:32:59 2019 -0600
move julian and yearlen to GFS_control_type (from interstitial) and add metadata for vars needed in GFS_time_vary_pre_run
commit 636339227e9948feb58e4848a8983c822bbe831a
Merge: 07b2f1f9 0b222938
Author: Weiwei <42526954+bluefinweiwei@users.noreply.github.com>
Date: Fri Aug 23 13:23:21 2019 -0600
Merge pull request #1 from climbfuji/ugwd_dom
UGWD update for open PR to gmtb/develop
commit 0b2229387070e966b5bc6892bd9704d7e57a239c
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Aug 23 11:59:01 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.meta: correct variable dimensions
commit 95071efdde50b128749f5719dce45fc1b2e52729
Author: Grant Firl <grantf@ucar.edu>
Date: Fri Aug 23 11:11:07 2019 -0600
add density of liquid water to constants available to CCPP schemes
commit f7b7df469022a7d74fd43591aabc57ba7e4ddbcf
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Aug 23 08:52:51 2019 -0600
gfsphysics/GFS_layer/GFS_physics_driver.F90: update CCPP comments for UGWP code changes
commit 539d331b5f578dd0c22b2131b54662cfff8839dd
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Aug 23 08:52:22 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.{meta,F90}: import con_p0, use instead of locally defined p_ref, add metadata
commit 5717d0f19ea5b61010910fc0bf50b2529650dd21
Author: Grant Firl <grantf@ucar.edu>
Date: Thu Aug 22 13:32:30 2019 -0600
change comments to reflect locations of NoahMP interstitial code
commit a43041878ed867ec04f3d863559089d2c5d20fef
Merge: 9ffcba3b 44d95416
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Aug 22 11:19:43 2019 -0600
Merge branch 'gmtb/develop' of https://github.com/NCAR/FV3 into ugwd_dom
commit 9ffcba3b817c779dfbd7d7b7fe84d2228b9c652e
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Aug 22 11:19:16 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.F90: remove unnecessary comment
commit 44d95416b0921f5947e93f3aa29ef31ab1b73d4a
Merge: e4e7ee6c cef4ace8
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu Aug 22 11:17:41 2019 -0600
Merge pull request #191 from climbfuji/bugfix_gfdlmp_ccpp
gmtb/develop: bugfix for CCPP GFDL-MP when effective radii are not used
commit 697003f6b26443df0f385b17a2202f70d0f4b476
Merge: e4e7ee6c 07b2f1f9
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Aug 21 14:24:23 2019 -0600
Merge branch 'cires_ugwp' of https://github.com/bluefinweiwei/FV3 into HEAD
commit 04e913f0b90264dc97b122bb1ab789beedde9547
Author: Grant Firl <grantf@ucar.edu>
Date: Wed Aug 21 13:30:00 2019 -0600
initial addition of NoahMP variables to GFS_typedefs.F90
commit 7994ef98ad93bc5999d9a105cba3773ae84da6b5
Author: Grant Firl <grantf@ucar.edu>
Date: Tue Aug 20 14:13:34 2019 -0600
fix CCPP metadata for convective/non-convective precip variables used in RUC LSM
commit ab4264fdd0128ca39897b324ed71aa8b113ed6ad
Author: Grant Firl <grantf@ucar.edu>
Date: Tue Aug 20 13:50:54 2019 -0600
removed conversion factor for soil moisture and runoff diagnostics since they now have the desired units directly in physics code; corrected CCPP units in GFS_typedefs.meta
commit 7ffc16a7ed7f759e414529cd8873417e0dae408d
Author: Linlin.Pan <Linlin.Pan@noaa.gov>
Date: Mon Aug 19 21:52:12 2019 +0000
adding couple option in CCPP with modified variable names.
passed regression tests.
commit 7f7e0a226264cd8928282cabad4822b41f019ddb
Merge: 915dafd4 e4e7ee6c
Author: panll <lpan@ucar.edu>
Date: Mon Aug 19 09:55:48 2019 -0600
Merge pull request #1 from NCAR/gmtb/develop
Gmtb/develop
commit cef4ace8dbb72e551b452743590f1e39739a5c6d
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jul 18 10:58:56 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.F90: bugfix for GFDL-MP in CCPP when effective radii are not used
commit 0591b5c5100d75a79c604d9e91985a8a75aaf60b
Merge: a6ce9d41 c9606fba
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Mon Aug 19 08:48:29 2019 -0600
Merge pull request #188 from climbfuji/update_gsd_develop_with_vlab_master_20190816
Update GitHub gsd/develop with Vlab master 2019/08/16
commit e4e7ee6c640ca64b0ad8915c8ee06631c3c5590c
Merge: 0af7e331 b7b423cb
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Sat Aug 17 16:25:45 2019 -0600
Merge pull request #184 from climbfuji/bugfix_allocating_dtdt_m_non_ccpp_version
Bugfix for allocating dtdt_m in fv_dynamics.F90
commit c9606fba7e19ab86aa60b002f9ccd972b754d219
Author: Dusan Jovic <dusan.jovic@noaa.gov>
Date: Fri Jul 26 13:45:14 2019 +0000
Fix an issue introduced in the previous commit where merge conflict markers were inadvertently committed.
commit 02efdda480a2d1b610e3057d95fa4ac6f21d6ca6
Author: Jun.Wang <Jun.Wang@noaa.gov>
Date: Thu Jul 18 15:21:28 2019 +0000
FV3: This commits #refs 65267 adding obs-based roughness length formulations and adjustment of K for hurricane simulations
Change-Id: Ifea0ed42e7611648f4daa2dc24921561b4080691
commit 8a86358617ff8bc39731b6f8a84128cfb3e74075
Merge: 396b10dc 319bb441
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Fri Aug 16 11:36:41 2019 -0600
Merge pull request #187 from climbfuji/update_github_master_from_vlab_master_20190816
Update GitHub master from Vlab master 2019/08/16
commit 319bb4411a8884493430166b2c4953bd5166e7a2
Author: Dusan Jovic <dusan.jovic@noaa.gov>
Date: Fri Jul 26 13:45:14 2019 +0000
Fix an issue introduced in the previous commit where merge conflict markers were inadvertently committed.
commit b757a06cbb507adcf73b85256cf8ed1869b8e425
Author: Jun.Wang <Jun.Wang@noaa.gov>
Date: Thu Jul 18 15:21:28 2019 +0000
FV3: This commits #refs 65267 adding obs-based roughness length formulations and adjustment of K for hurricane simulations
Change-Id: Ifea0ed42e7611648f4daa2dc24921561b4080691
commit 07b2f1f9e7db1155463698956755cd9b899ce0b7
Author: Weiwei <weiweili@ucar.edu>
Date: Tue Jul 16 14:57:32 2019 -0600
modified: GFS_typedefs.F90
modified: GFS_typedefs.meta
commit 915dafd466c0b7195d1e494d327feb55d4da8981
Author: Linlin.Pan <Linlin.Pan@noaa.gov>
Date: Thu Aug 15 04:43:15 2019 +0000
adding new variables for coupling option in CCPP:
gfsphysics/GFS_layer/GFS_typedefs.F90 -- new variables allocation and initiation included
gfsphysics/GFS_layer/GFS_typedefs.meta -- new variables definiation added
commit b7b423cbf65f30f2c2a2d928c6814d746cbf202e
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Aug 9 11:47:51 2019 -0600
atmos_cubed_sphere/model/fv_dynamics.F90: always allocate dtdt_m, because its dimensions are hardcoded in fv_mapz.F90
commit dfb7db58bd44c48853ae6cd55efeaa731e3afa5f
Merge: 0af7e331 a3ea903d
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Aug 8 14:05:59 2019 -0600
Merge branch 'MG_array_allocation' of https://github.com/grantfirl/FV3 into HEAD
commit 0af7e331bdc79d81a9f0daf6f7a4d64e9170a440
Merge: b1d8ec4d 5b4c6e5e
Author: grantfirl <grantf@ucar.edu>
Date: Tue Aug 6 13:45:45 2019 -0600
Merge pull request #180 from grantfirl/add_interstitial_comments
Document locations of CCPP-implemented code within GFS_physics_driver.F90
commit 5b4c6e5e51738c28fd4616e7cb5ee401817f37b6
Author: Grant Firl <grantf@ucar.edu>
Date: Thu Aug 1 16:35:28 2019 -0600
fix comment related to stochastics in GFS_driver.F90
commit f8f792b889ab19a6c99384c7b1453144ab263bc6
Merge: 4dc853b8 b1d8ec4d
Author: Grant Firl <grantf@ucar.edu>
Date: Thu Aug 1 14:52:11 2019 -0600
Merge branch 'gmtb/develop' into add_interstitial_comments
commit b1d8ec4d6eb4d4f7519c608fe5f76fbacd8e7f6c
Merge: c4712c23 5d14eec3
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu Aug 1 14:46:23 2019 -0600
Merge pull request #181 from climbfuji/new_metadata_format_step1_20190725
Migrate to new metadata format step 1
commit 4dc853b8ca35494376b8e811f1f2916f61b648a6
Merge: 31e0cc65 c4712c23
Author: Grant Firl <grantf@ucar.edu>
Date: Thu Aug 1 14:00:56 2019 -0600
Merge branch 'gmtb/develop' into add_interstitial_comments
commit 31e0cc65bf4eea12e2072c5f3edd9011c99a1bd1
Author: Grant Firl <grantf@ucar.edu>
Date: Thu Aug 1 13:53:25 2019 -0600
add comments in GFS_driver.F90 and GFS_radiation_driver.F90 to tell users locations of code in the CCPP
commit 5d14eec31116d3b2f4902695c9f12a05f6748d70
Merge: f575b620 417f8ce9
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Jul 31 15:47:56 2019 -0600
Merge branch 'master' of gerrit:FV3 into new_metadata_format_step1_20190725
commit f575b6205aafc91e2d37130febe9a6934e2e352b
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Jul 24 16:44:16 2019 -0400
gfsphysics/GFS_layer/GFS_typedefs.F90: add metadata for new HAFS variable GFS_Control%sfc_z0_type
commit 3990afc75001f55529d0be960ad7ea149715f669
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Jul 31 14:17:45 2019 -0600
Convert CCPP type and variable definitions to new metadata format, introduce variables for all dimensions needed, add comments about further work
commit a3ea903db48889bf163b33f7fbc6644fae8f1731
Author: Grant Firl <grantf@ucar.edu>
Date: Wed Jul 31 12:41:08 2019 -0600
conditionally allocate arrays for Morrison-Gettelman microphysics scheme
commit 7b4db3ea1751644174dc22c1d8f5e34c3176bf12
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jul 25 16:31:42 2019 -0600
gfsphysics/CCPP_layer/CCPP_typedefs.F90, gfsphysics/GFS_layer/GFS_typedefs.F90: substitute dashes with underscores in variable standard names
commit 2cdcc3b4d6af372194c52293b537de759d36bed4
Author: Grant Firl <grantf@ucar.edu>
Date: Sun Jul 21 19:13:19 2019 -0600
add comments in GFS_physics_driver.F90 to tell users locations of code in the CCPP
commit a6ce9d412e31a865116183c817fd5f0db40c44db
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jul 18 10:45:01 2019 -0600
Update CODEOWNERS to enable branch protection
commit 9def0cf844a3bc743c842e35a070128b9fc0035d
Merge: a5c8b40e 780d3a87
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Wed Jul 17 20:48:05 2019 -0600
Merge pull request #179 from climbfuji/add_regression_tests_20190717
gsd/develop: add regression tests for Thompson only, GF only, MYNN only & cleanup
commit 780d3a87df3dd7749d960af0bfac876c553c21a7
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Jul 17 14:13:03 2019 -0600
Remove namelist option make_number_concentrations, this will be used by default for Thompson MP
commit a5c8b40e37ebb410e721e00f04350086b27da834
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Jul 16 15:00:57 2019 -0600
Update CODEOWNERS to GSD team
commit 1cfdbb099f5ff7bcc30e0290ea3c8aaf7f0f714b
Merge: 9595fb7c c4712c23
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Jul 16 14:52:54 2019 -0600
Merge branch 'gmtb/develop' of https://github.com/NCAR/FV3 into HEAD
commit c4712c233cb6cb5d68e1dd050fd3a4889c20f53d
Merge: ae1d3d92 d0359b3f
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Tue Jul 16 14:46:17 2019 -0600
Merge pull request #178 from climbfuji/update_gmtb_develop_from_vlab_master_20190716
Update gmtb/develop from Vlab master 2019/07/16
commit d0359b3f8f8ec129b3be65a6aafde203bbfb4f1f
Merge: ae1d3d92 64fc1f1a
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Jul 16 14:41:30 2019 -0600
Merge branch 'master' of gerrit:FV3 into HEAD
commit 396b10dcbd91c577a0dfb3094e2cd0d463f1046a
Merge: c4ef4b09 e0fed0fd
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Tue Jul 16 14:37:34 2019 -0600
Merge pull request #177 from climbfuji/update_master_github_from_master_vlab
Update master GitHub from master Vlab
commit e0fed0fdda5b8d290cae2a5550f1baf9c8977b92
Merge: c4ef4b09 64fc1f1a
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Jul 16 14:33:18 2019 -0600
Merge branch 'master' of gerrit:FV3 into HEAD
commit ae1d3d92ad53af377789e1b353dbdc96e65cb66c
Merge: 5c1fb7dc 92071555
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Tue Jul 16 14:23:13 2019 -0600
Merge pull request #176 from climbfuji/bugfix_gf_conv_AND_thompson_cleanup_20190709
Bugfix GF convection, Thompson cleanup 2019/07/09
commit 5c1fb7dc24337aecc5abcd08fad0c0c776f43cc6
Merge: 981af01d dfe41ca3
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu Jul 11 08:37:15 2019 -0600
Merge pull request #175 from climbfuji/update_from_github_master_20190708
Update from GitHub (=VLab) master 2019/07/08
commit 9207155591cf01f0825105dcd8f708e32ceeecae
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Jul 9 10:31:31 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.F90: adjust number of tracers in PBL tracer array for Thompson MP, add guard to prevent running Thompson MP with cplchm (not configured)
commit dfe41ca3b68c4fdc6c5c30e6ed1a38a39b25f618
Merge: d27d3473 c4ef4b09
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Mon Jul 8 11:24:40 2019 -0600
Merge branch 'master' of https://github.com/NCAR/FV3 into HEAD
commit d27d34737295bb5f3a30581c92aa11fc665edba1
Merge: 981af01d 3dc7e9b1
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Mon Jul 8 11:24:07 2019 -0600
Merge branch 'master' of gerrit:FV3 into HEAD
commit c4ef4b0944a1dbbea4a371a5f98cf18f407f181e
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Mon Jul 8 08:23:56 2019 -0600
Add CODEOWNERS after mirroring Vlab master
commit 981af01d87d8b302cafd19cfb07e66443f7a18d4
Merge: 66b1f26a 3e3b1b70
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Wed Jul 3 07:58:40 2019 -0600
Merge pull request #173 from climbfuji/cleanup_work_gerrit_codereview_20190701
Cleanup work gerrit codereview 2019/07/01
commit 3e3b1b701466a9884217d36a5e729866acfd7f7d
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Mon Jul 1 13:44:35 2019 -0600
gfsphysics/GFS_layer/GFS_physics_driver.F90: comment out unneccessary/redundant code as per code review
commit 66b1f26a0d5b576c2c7b39d6a009c8fb7d4822c4
Merge: 132bd90d 754129f5
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Sun Jun 30 20:25:43 2019 -0600
Merge pull request #172 from climbfuji/cleanup_work_gerrit_codereview_20190627
Cleanup work gerrit code review part 2 - 2019/06/29
commit 754129f5d24c092edc9e7f91031217a3d6bae485
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Sat Jun 29 09:30:17 2019 -0600
Optimization (CCPP-only): allocate Noah MP restart variables only if Noah MP is actually used
commit 6b54841392e5cc9c9fab6ef3d64ab3af0be8eefb
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Sat Jun 29 06:52:25 2019 -0600
CCPP_layer/makefile, gfsphysics/makefile: set CPP directives for promoting dynamics/fast physics to 32-bit
commit 4899b5d9d979dc96b9f6a1978adf81156867ee81
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Jun 28 14:22:23 2019 -0600
gfsphysics/physics/GFS_debug.F90, gfsphysics/GFS_layer/GFS_physics_driver.F90, gfsphysics/GFS_layer/GFS_diagnostics.F90: bugfixes following the reverse of the Diag%{wet1,sr} -> Sfcprop{wet1,sr} change
commit afb55926beb9255813e011e7c82bbe93c5beefab
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Jun 28 13:48:57 2019 -0600
atmos_cubed_sphere/tools/external_ic.F90: add CPP guard to logic for reading in Thompson aerosols
commit 50576da069d45a9d6602cb9301db04163f3331da
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Jun 28 13:46:49 2019 -0600
gfsphysics/GFS_layer/GFS_physics_driver.F90, gfsphysics/physics/physcons.F90, gfsphysics/physics/sfc_sice.f: revert cimin changes (moved from sfc_sice to physcons) for non-CCPP builds
commit a3f9fefd27f45b6ef64930648532c65c29bcca4c
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Jun 28 13:40:31 2019 -0600
gfsphysics/physics/radiation_clouds.f: fix bug for radiation-clouds in Thompson/WSM6 cloud scheme
commit d01ebbc1205d39e744b40fd4efb202804974fa78
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Jun 28 13:37:46 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.F90, io/FV3GFS_io.F90: RUC now uses srflag and not sr, revert change of moving sr from Diag to sfcprop, and remove sr from restart information for RUC
commit ef9936381fbd26276147ca58010e24a71a25728b
Merge: a00ec683 132bd90d
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 22:45:25 2019 -0600
Merge branch 'gmtb/ccpp' of https://github.com/NCAR/FV3 into cleanup_work_gerrit_codereview_20190627
commit a00ec683be47562518240938f72783f652973c8e
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 22:45:10 2019 -0600
io/FV3GFS_io.F90: rename wetness variable for RUC LSM from wet1 to wetness
commit f0fa127d278f2a1321560e190f7e80698839238e
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 22:43:26 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.F90: use different wetness variables for RUC LSM and other LSMs, update metadata for CCPP
commit 9f21fe1c50dd33e99a8d6d3d94402f0ec01cd192
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 22:41:42 2019 -0600
gfsphysics/GFS_layer/GFS_diagnostics.F90: use different wetness variables for RUC LSM and other LSMs, cleanup code for subsurface variables, rename RUC LSM soill output to slc to be consistent with Noah MP
commit 132bd90db5f033d479eb0892e840cd5b03fa1bb9
Merge: 7ab6d311 00db91cd
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu Jun 27 22:32:52 2019 -0600
Merge pull request #171 from climbfuji/cleanup_work_gerrit_codereview_20190626
Cleanup work for CCPP transition 2019/06/27 - 1
commit 00db91cd2f37e84a747bab70dedbdc607e54ce3b
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 11:21:23 2019 -0600
ipd/IPD_typedefs.F90: cleanup code, remove remaining remnants of old HYBRID build, remove unused IPD_finalize
commit 009d0bf91514ba1fbc69b28014d0b50ff0da0e70
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 11:20:05 2019 -0600
ipd/IPD_driver.F90: cleanup code, remove remaining remnants of old HYBRID build, remove unused IPD_finalize
commit 953cb7f8542b094b10b84bf1eecd0a66cd9944be
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 11:19:12 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.F90: check and remove old comments as needed, remove standard_name for composite dq3dt to prevent its usage, allocate d?3dt arrays for CCPP only if ldiag3d is true
commit 135d62927a63f8487858f94586e81e760f505d5b
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 11:17:14 2019 -0600
gfsphysics/GFS_layer/GFS_driver.F90: cleanup code, remove unused GFS_finalize
commit c0abdb637c9c77df9887d5342c5e4394cee3b311
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 11:16:41 2019 -0600
gfsphysics/GFS_layer/GFS_abstraction_layer.F90: cleanup code, remove remaining remnants of old HYBRID build, remove unused GFS_finalize
commit 9fd64b4d366997fa751c07d46e3d8f9b2bb81945
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 11:16:08 2019 -0600
atmos_model.F90: cleanup code, remove remaining remnants of old HYBRID build
commit 97f665fb5c2436f0f436f51cb77fbabc87e09f31
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 11:15:10 2019 -0600
atmos_cubed_sphere/tools/external_ic.F90: remove unnecessary comments
commit 226b417ac8da6af8bffed3b7567f0a409b311d7f
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 11:14:30 2019 -0600
atmos_cubed_sphere/model/fv_regional_bc.F90: remove unnecessary comments
commit eb1c50563e3f0d6189c01be15b3e4b4b1f12c680
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu Jun 27 11:12:05 2019 -0600
CCPP_layer/CCPP_driver.F90: Simplify physics_init, run over entire domain instead of multiple blocks
commit 00a02ca2cdff5bc5625739015853102d270726af
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Wed Jun 26 11:56:45 2019 -0600
makefile: set SIONLIB_LINK_FLAGS only for CCPP build, do not add to non-CCPP ESMF makefile fragment
commit 7ab6d3111322e306251e50ffc88bd1efa8d7e310
Merge: 386ab989 0e122708
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Wed Jun 26 08:43:58 2019 -0600
Merge pull request #170 from climbfuji/ruclsm_b4b_20190625
RUC LSM b4b through restarts, cleanup for Thompson MP / effective radii / debug output
commit 0e122708f6f8ef3a92ce3ff4638cb9d6b94e115a
Merge: c9cbbc8a 386ab989
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Jun 25 21:25:58 2019 -0600
Merge branch 'gmtb/ccpp' of https://github.com/NCAR/FV3 into ruclsm_b4b_20190625
commit c9cbbc8a21b46987e0fa170650d8117882c40509
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Jun 25 21:25:22 2019 -0600
gfsphysics/physics/GFS_debug.F90: comment out Diag%fluxr components, not required for b4b (purely diagnostic and not in output)
commit 6635068b4dc8b8916fa2903b0e2bf721b0917b9a
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue Jun 25 21:24:20 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.F90: improve debug print of dry/wet/icy components of CCPP interstitial type
commit 386ab989b837db3a6bbd9c47c2911673c3c8af6e
Merge: 470681c3 6ce05823
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Tue Jun 25 08:26:01 2019 -0600
Merge pull request #169 from NCAR/bugfix_gfs_phy_tracer_config_suffix
Bugfix gfs phy tracer config suffix .f -> .F
commit 6ce05823d64a49151d38e48a4dc960fd6a6cc3a6
Author: climbfuji <dom.heinzeller@icloud.com>
Date: Tue Jun 25 08:24:16 2019 -0600
Bugfix: fix suffix of physics/gfs_phy_tracer_config.f->F
commit 470681c382fd0d62a3cf45ca372bb06f31e16df9
Merge: d60d8e63 abb621fe
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Fri Jun 21 08:59:35 2019 +0200
Merge pull request #168 from climbfuji/ccpp_github_update_vlab_master_20190611
CCPP GitHub update from VLab master 2019/06/11
commit abb621fe28a61ff26cfc04849217b8cf3030e92d
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri Jun 14 09:54:17 2019 -0600
This commit combines three commits to Vlab master (NEMSfv3gfs and FV3):
commit ee9977192f6782df21d2af23979ec67683ac020e
Author: Dusan Jovic <dusan.jovic@noaa.gov>
Date: Mon Jun 10 14:20:34 2019 +0000
NEMSfv3gfs: this commits #refs 56264: support fractional landmask on FV3 grid, and #refs 64400: bug fix for UGW and in CSAW
Change-Id: Id42e31a8b32ba52dd810e98dff059b14135884ec
commit a0fca321ffd9fff1e929c00f3e6d467154610065
Author: Dusan Jovic <dusan.jovic@noaa.gov>
Date: Thu Jun 6 13:54:04 2019 +0000
NEMSfv3gfs: this commits #refs 64015 Add updated scale-aware TKE-based moist EDMF scheme. Updated fv3_cap #refs 62862
Change-Id: Ic6a04044bd2826a3a4be700e77067ff435fadc56
commit a2c9fdabf3aa1e99ab8037c319820c9e440fb894
Author: Jun Wang <jun.wang@noaa.gov>
Date: Tue Jun 4 01:26:37 2019 +0000
NEMSfv3gfs: this commits #refs 61507, coupling Noah MP to fv3gfs
Change-Id: Ia3b86d247d98ee143e47b5e41fce3ae92dde0564
commit d60d8e638f12bc6ebfb77a042b0f75774f47eb5c
Merge: 7d6c9538 d00e8e6d
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu May 30 22:00:51 2019 -0600
Merge pull request #162 from climbfuji/bugfix_fractional_landmask_and_cleanup
Bugfix fractional landmask, scientific documentation update, cleanup
commit d00e8e6d8c80e9f1f409fa3abb52f5a864efd738
Merge: f42c3ed5 7d6c9538
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu May 30 08:41:54 2019 -0600
Merge branch 'gmtb/ccpp' of https://github.com/NCAR/FV3 into bugfix_fractional_landmask_and_cleanup
commit 7d6c95383258c9b9813614953876a191bce8b55b
Merge: 9adc6bc2 e90a8dec
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu May 30 06:34:35 2019 -0600
Merge pull request #161 from climbfuji/gsd_suite_cleanup_and_fractional_landmask_follow_up
GSD suite cleanup and fractional landmask follow up
commit f42c3ed52f50286fa65117c879dd8f0b7d0b0fc3
Author: shan.sun <shan.sun@noaa.gov>
Date: Fri May 24 16:10:37 2019 +0000
1.) Revert back to 1f45136245cde52b39e93ab29f0d36020b0f7e63 :
This rewinds cleanup in sfc_diag.f and GFS_physics_driver.F90
2.) Then, fix bug for ice point to be from ">15%" to ">=15%" to be consistent with initial condition, which defines slmsk=2 for >=15%.
This bugfix is in the following files:
GFS_physics_driver.F90
atmos_model.F90
commit e90a8dec3a9e56357b0a934e6dd02f7b587e3161
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue May 28 15:56:39 2019 -0600
atmos_cubed_sphere/driver/fvGFS/atmosphere.F90: improve error handling/output for CCPP fast physics
commit 43854a221fbf255cc84657b5ea567440855cf2a4
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue May 28 15:09:26 2019 -0600
io/FV3GFS_io.F90: remove temporary filling of top four Noah levels with RUC levels when restarting from RUC LSM data
commit aefb214c4da67cfc78036523c4447092157719a3
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue May 28 15:08:33 2019 -0600
gfsphysics/GFS_layer/GFS_typedefs.F90: add consistency check that surface data cycling is turned off when RUC LSM is used
commit 18414f2c682db5da35c8f7861d8eec29ef96b8f1
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Tue May 28 15:07:54 2019 -0600
gfsphysics/GFS_layer/GFS_diagnostics.F90: write out all subsurface layers for RUC LSM; facilitate and shorten the code for writing out subsurface layers for both RUC and Noah for the CCPP version
commit 9adc6bc261764c18292a3f258a0c6d3888e36c52
Merge: 56bffa38 e79d445f
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Fri May 24 13:59:58 2019 -0600
Merge pull request #158 from climbfuji/remove_hybrid_ccpp
Remove CCPP HYBRID mode
commit e79d445faf8d3d7594034ca0785a9c982a17baea
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Fri May 24 05:22:57 2019 -0600
gfsphysics/GFS_layer/GFS_physics_driver.F90: rearrange to match Vlab master code more closely
commit 2a61d4a9a15834eb9e02801513b2a4c472c79b0a
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu May 23 16:18:35 2019 -0600
Remove HYBRID CCPP build
commit 56bffa38043839dd3f867aa53d943610cf6e9b13
Merge: 8657c507 83fa5b9f
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu May 23 11:47:19 2019 -0600
Merge pull request #157 from climbfuji/ccpp_cleanup_20190523
CCPP cleanup 2019/05/23 - remove temporary files
commit 83fa5b9f7f5fd8b677635f4d76813d122fcb3c98
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Thu May 23 11:21:35 2019 -0600
Remove temporary files gfsphysics/GFS_layer/GFS_typedefs.{ipd,ccpp}.F90 and remove comments to them in gfsphysics/makefile
commit 8657c5074300810430692760ce475649c3119070
Merge: 789a135d 54fecdda
Author: Dom Heinzeller <dom.heinzeller@icloud.com>
Date: Thu May 23 10:53:59 2019 -0600
Merge pull request #156 from climbfuji/cleanup_ccpp_build
CCPP cleanup 2019/05/13
commit 54fecdda7f950ef9afbe3d8700174d7ba8cfa03a
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Mon May 20 16:06:06 2019 -0600
gfsphysics/makefile: remove two-step compilation of GFS_typedefs.F90, this causes compile errors with Intel (compiler bug)
commit c885e896eb0b058e82fa50345ec0ce7f07056329
Author: Dom Heinzeller <dom.heinzeller@noaa.gov>
Date: Mon May 20 14:06:11 2019 -0600
TEMPORARY: add original, merged GFS physics driver as gfsphysics/GFS_lay…
climbfuji
added a commit
to climbfuji/fv3atm
that referenced
this issue
Jun 6, 2020
…_emc_develop_and_missing_ccnin_updates Update NCAR dtc/develop from EMC master, apply missing updates from CCN/IN commit
|
@mcgibbon we addressed the restart reproducibility issues in the authoritative branches (ufs-weather-model develop) a while ago. Can you confirm it is working correctly now? Thanks. |
|
That's great to hear, both that you ran into these issues (the last I heard was that the tests were passing in the UFS model), and that it's fixed. Can you give me any more detail about where this came up in ufs-weather-model? We don't currently have our code set up to use the ufs-weather-model build system, so I can't quickly update the sources and run the test. This is something we're planning to do soon, so I'll re-run this test when we do so. For now, I'll close this issue. |
|
The two commits for fv3atm (develop) are listed in ufs-community/ufs-weather-model#208 and ufs-community/ufs-weather-model#325. You can also look at just the required changes for the release/public-v2 branches (for the upcoming SRW App release), which went in today (again in fv3atm mentioned here: ufs-community/ufs-weather-model#417). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We are using the "ufs_public_release" branches of fv3atm, FMS, and stochastic_physics, and ESMF 8.0.0. We are using the GFS physics option. @oliverwm1 has also been working on this issue.
Our build configuration is in configure.fv3.gnu_docker.txt
Most of the namelist we're using is contained in default_config.yml.txt, though I toggle flags to enable restart mode. The issue also occurs when the initial model state is read from a restart file.
Long story short, when we run the model for 4 hours, the result is different than if we run the model for 2 hours, write to a restart file, restart the model from that restart file, and run for 2 more hours. The result is the same when running with the dycore only, but different when physics is enabled.
However, the restart files are correctly read in and their values are correctly set in the state variables of the model. We've checked this by probing the model state variables during runtime. Despite this, the model progression changes. This implies something important is not being written out during a restart.
Earlier when using the fv3gfs repo we had the same issue, but we were able to correct the restart by first running the initialization in cold start mode and then reading in the restart files after this point using wrapping Python code, followed by stepping the model forward the final 2 hours. On the newer UFS public release, this does not work.
I'd be glad to send the forcing/initial conditions/namelist files we are using if someone would like to reproduce this issue on their own machine with their own build environment.
The text was updated successfully, but these errors were encountered: