Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes from public release #112

Merged
merged 9 commits into from
May 8, 2020
Merged

Bugfixes from public release #112

merged 9 commits into from
May 8, 2020

Conversation

DusanJovic-NOAA
Copy link
Collaborator

@DusanJovic-NOAA DusanJovic-NOAA commented May 7, 2020 •
edited
Loading

Cherry pick some bug fixes and cleanup commits from release/public-v1 branch.

Associated PRs:
ufs-community/ufs-weather-model#119

jedwards4b and others added 9 commits May 5, 2020 13:20
@jedwards4b @DusanJovic-NOAA
Update from release/public-v1 (See NOAA-EMC#43)
57bce37 
make variables using filename_base consistant in length
@DusanJovic-NOAA
Set default calendar to 'gregorian' (See NOAA-EMC#34)
0ea6ce6 
* set default calendar to gregorian
* set default values of write_nemsioflip and write_fsyncflag to .true.
@climbfuji
Update CCPP version number from 3 to 4
9aa0522
@climbfuji
gfsphysics/GFS_layer/GFS_physics_driver.F90: update comment on locati…
de5b7ce 
…on of code in CCPP
@climbfuji
Add no_nsst CCPP suites from public release
6e8250a
@climbfuji
Update .gitmodules and submodule pointers for ccpp-framework and ccpp…
7641a1d 
…-physics for code review and testing
@DusanJovic-NOAA
Remove unused and unsupported code (See NOAA-EMC#31)
d5fda8a
@DusanJovic-NOAA
Merge pull request #1 from climbfuji/bugfixes_from_public_release-dom
bd142d4 
Bring hotfixes from release/public-v1 back to master (CCPP changes)
@DusanJovic-NOAA
Revert "Merge pull request #1 from climbfuji/bugfixes_from_public_rel…
ba97e26 
…ease-dom"

This reverts commit bd142d4, reversing
changes made to d5fda8a.
@DusanJovic-NOAA DusanJovic-NOAA mentioned this pull request May 7, 2020
Merged
climbfuji
climbfuji reviewed May 7, 2020
View reviewed changes
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I am doing something wrong, but I don't see the changes from my commits when I click on "all commits"? There should be several in ccpp/, one on GFS_physics_driver.F90, one in .gitmodules?

@climbfuji
Copy link
Collaborator

Maybe I am doing something wrong, but I don't see the changes from my commits when I click on "all commits"? There should be several in ccpp/, one on GFS_physics_driver.F90, one in .gitmodules?

Ah, now I see, this is what you had to revert. I'll go and have a good look at the CCPP changes then.

climbfuji
climbfuji approved these changes May 7, 2020
View reviewed changes
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I do not understand why/how the regression tests failed when you merged my PR.

@DusanJovic-NOAA DusanJovic-NOAA merged commit 63658ed into NOAA-EMC:develop May 8, 2020
@DusanJovic-NOAA DusanJovic-NOAA deleted the bugfixes_from_public_release branch May 8, 2020 14:11
climbfuji pushed a commit to climbfuji/fv3atm that referenced this pull request May 8, 2020
@DusanJovic-NOAA @climbfuji
Bugfixes from public release (NOAA-EMC#112)
3962b1c 
* See NOAA-EMC#43 NOAA-EMC#34 NOAA-EMC#31
climbfuji pushed a commit to climbfuji/fv3atm that referenced this pull request Oct 21, 2021
@DomHeinzeller
Merge pull request NOAA-EMC#112 from climbfuji/joe_mynn_updates_20211020
0e6ff3b 
Updates to MYNN-EDMF in CCPP physics
SamuelTrahanNOAA referenced this pull request in SamuelTrahanNOAA/fv3atm Jun 13, 2022
@XiaqiongZhou-NOAA
Add regression tests with MULTI_GASES (NCAR#112)
a7b9b6d 
* Add the option to run regression test with MULTI_GASES=Y
* Add multi_gases CCPP regression test
LarissaReames-NOAA pushed a commit to LarissaReames-NOAA/fv3atm that referenced this pull request Nov 17, 2023
@bensonr
Merge pull request NOAA-EMC#112 from lharris4/master
b8599fe 
Documentation and defaults changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junwang-noaa junwang-noaa junwang-noaa approved these changes

@climbfuji climbfuji climbfuji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DusanJovic-NOAA @climbfuji @junwang-noaa @jedwards4b