ugwpv1_gsldrag bug fixes, and GFS_typdefs updates associated with diag flags for ugwpv1_gsldrag.F90 and GFS_DCNV_generic.F90 #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g flags for ugwpv1_gsldrag and GFS_DCNV_generic.F90
climbfuji
reviewed
Apr 23, 2021
| @@ -7139,8 +7136,7 @@ subroutine interstitial_phys_reset (Interstitial, Model) | |||
| Interstitial%zngw = clear_val | |||
|
|
|||
| ! CIRES UGWP v1 | |||
| if (Model%do_ugwp_v1 .or. Model%gwd_opt==33 .or. Model%gwd_opt==22 & | |||
There was a problem hiding this comment.
@mdtoy this PR reverts all changes that I had to make so that Evan could run the model w/o segfaults. Can you confirm that these changes are intended?
|
This PR was merged as part of #291 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the final accumulation of tendencies at the end of subroutine ugwpv1_gsldrag_run in module ugwpv1_gsldrag.
Fixes inconsistencies between allocation of diagnostic variables in GFS_typedefs.F90 and ugwpv1_gsldrag.F90 as determined by logical flags.
Fixes inconsistencies between allocation of diagnostic variables in GFS_typedefs.F90 and GFS_DCNV_generic.F90 as determined by logical flags.