Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physics update in cumulus convection, PBL & surface layer for UFS_P7 #314

Merged
merged 25 commits into from
Jul 16, 2021

Conversation

JongilHan66
Copy link
Contributor

@JongilHan66 JongilHan66 commented May 24, 2021

Description

(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
Is a change of answers expected from this PR?

Cumulus convection:
a) More strict convection trigger
b) Reduced entrainment rate below cloud base
c) Enhanced downdraft detrainments starting from 60mb above the ground surface
d) Reduced rain evaporation
e) Modification of cloud depth separating shallow convection from deep convection

PBL and surface layer:
a) Inclusion of wind shear effect reducing characteristic mixing length
b) Reduction of background diffusivity in the inversion layers as a function of surface roughness and green vegetation fraction
c) PBL updraft overshooting limited by bulk Richardson number-based-PBL depth
d) Inclusion of new canopy heat storage parameterization
e) Modification of thermal roughness calculation over land
f) Increase of momentum roughness length over sea
g) Inclusion of sea spray effect parameterization

The verification results for the physics updates above can be found in https://www.emc.ncep.noaa.gov/gmb/jhan/vsdbw/ccaa14
More detailed description for the updates and ccaa14 results are given in the attached ppt file.
Tests_physics_MRF_MJO_JHan_WLi.pptx

Verification results for additional physics updates are in:

  1. Increased sea spray effects: https://www.emc.ncep.noaa.gov/gmb/jhan/vsdbw/ccaa27
  2. Inclusion of new maximum z/L parameterization in the GFS surface layer scheme:
    Winter: https://www.emc.ncep.noaa.gov/gmb/jhan/vsdbw/ccaa41
    Summer: https://www.emc.ncep.noaa.gov/gmb/jhan/vsdbw/ccaa41x

The final update is based on 'ccaa41'.

Description for the new maximum z/L parameterization can be found in the attached ppt file.
PBL_SL_inv_JHan.pptx

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

  • fixes #<issue_number>
  • fixes noaa-emc/fv3atm/issues/<issue_number>

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

NCAR/ccpp-physics#665
ufs-community/ufs-weather-model#589

@JongilHan66 JongilHan66 changed the title Han p7 Physics update in cumulus convection, PBL & surface layer for UFS_P7 May 24, 2021
real(kind=kind_phys) :: betas_deep = 0.05 !< fraction factor of downdraft air mass reaching ground surface over sea
real(kind=kind_phys) :: betal_deep = 0.01 !< fraction factor of downdraft air mass reaching ground surface over land
real(kind=kind_phys) :: betas_deep = 0.01 !< fraction factor of downdraft air mass reaching ground surface over sea
real(kind=kind_phys) :: evef = 0.09 !< evaporation factor from convective rain
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the difference between evef and evfact_deep? Both have same documentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

evfact_deep & evfactl_deep were commented out in SAS deep convection scheme, are no longer used, and will be eventually removed from both convection schemes and GFS_typedefs.F90.

.gitmodules Outdated
@@ -5,8 +5,8 @@
[submodule "ccpp/framework"]
path = ccpp/framework
url = https://github.com/NCAR/ccpp-framework
branch = main
branch = master
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this must be main

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jongil, would you please fix this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what's the problem and please direct me to fix it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the file .gitmodules in your fv3 branch han_p7, you are using "master" branch for ccpp-framework, please change it back to "main".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the file .gitmodules in my fv3 branch han_p7, I changed "master" to "main" and commit and pushed back. Should I also update my ufs-weather-model branch (ufs_hanp7)? Also, do I need to re-do the RT run with this ccpp-framework?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because the hash of ccpp-framework that fv3atm uses is still the same.

@climbfuji
Copy link
Collaborator

Submodule pointer for ccpp-physics is correct, and .gitmodules is back to what it should be. This PR can be merged (I cannot). @DusanJovic-NOAA @junwang-noaa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants