Remove interstitial variables for land and ice emissivity and update the land and ice emissivity in the routine setemis in CCPP

[SMoorthi-emc]

Description

(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
Is a change of answers expected from this PR?
This PR removes interstitial variables representing land and ice emissivity and updates the calculation of emissivity in setemis routine of radiation_surface.f. This update automatically makes the NoahMP restart reproducible.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

• fixes #<issue_number>
• fixes noaa-emc/fv3atm/issues/<issue_number>
  fixes ccpp-physics issue bug fix: disable concurrency in GFS_phys_time_vary_init NetCDF calls #735

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

• Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
• Please commit the regression test log files in your ufs-weather-model branch
  The baselines are expected to change as the surface emissivity calculation over ice has changed. In the coupled model the chnage only affects lake ice. For RUC LSM, as emissivity is in that LSM, it should have any impact.

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

• waiting on noaa-emc/nems/pull/<pr_number>
• waiting on noaa-emc/fv3atm/pull/<pr_number>
  Yes, ccpp-physics PR #736 should be merge first

[climbfuji]

I prefer not to depend on a compiler to optimize. I think what I have is better.
…

I wouldn't be surprised if the compiler threw away line 2494 and used Dusan's suggestion. We could check by letting the Intel compiler write out its optimizations.

[SMoorthi-emc]

Well, these days wall time is eclipsed by the outrageous time taken by communication etc, so one may not see the advantages of correct coding. I remember in the last cray class we had, the cray expert told us it is still better to write the code the way it should be written.

…

On Tue, Oct 19, 2021 at 1:53 PM Dom Heinzeller ***@***.***> wrote: I prefer not to depend on a compiler to optimize. I think what I have is better. … <#m_2394091771636520552_> I wouldn't be surprised if the compiler threw away line 2494 and used Dusan's suggestion. We could check by letting the Intel compiler write out its optimizations. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#393 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALLVRYRZQYEABNUUEXIULTLUHWWBPANCNFSM5EP6RGYQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Dr. Shrinivas Moorthi Research Meteorologist Modeling and Data Assimilation Branch Environmental Modeling Center / National Centers for Environmental Prediction 5830 University Research Court - (W/NP23), College Park MD 20740 USA Tel: (301)683-3718 e-mail: ***@***.*** Phone: (301) 683-3718 Fax: (301) 683-3718

[DusanJovic-NOAA]

I prefer not to depend on a compiler to optimize. I think what I have is better.

Are you sure it's better.

https://godbolt.org/z/jxx84Eazd

I think you should trust compilers more. I do not think we can (or should) try to outsmart compiles these days

[junwang-noaa]

What difference is this suite file from the current P7 suite file which uses sas, nsst, noahmp, ugwp and ca?

[junwang-noaa]

What difference is this suite file from the current P7 suite file which uses sas, nsst, noahmp, ugwp and ca?

[SMoorthi-emc]

I will take two multiplications for exponentiation any time. We have this kind of code all over the place. I am not the one to make code bad just assuming the compile is smart or maybe it is time for me to quit.

…

On Tue, Oct 19, 2021 at 2:00 PM Dusan Jovic ***@***.***> wrote: I prefer not to depend on a compiler to optimize. I think what I have is better. Are you sure it's better. https://godbolt.org/z/jxx84Eazd I think you should trust compilers more. I do not think we can (or should) try to outsmart compiles these days — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#393 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALLVRYXHD26PJMEC4FXH6GDUHWW43ANCNFSM5EP6RGYQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Dr. Shrinivas Moorthi Research Meteorologist Modeling and Data Assimilation Branch Environmental Modeling Center / National Centers for Environmental Prediction 5830 University Research Court - (W/NP23), College Park MD 20740 USA Tel: (301)683-3718 e-mail: ***@***.*** Phone: (301) 683-3718 Fax: (301) 683-3718

[junwang-noaa]

can we remove this one if the next suite file FV3_GFSv17alp_cpldnsstrasugwpnoahmp is working?

[SMoorthi-emc]

I see no "P7" suite!

…

On Tue, Oct 19, 2021 at 2:06 PM Jun Wang ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In ccpp/suites/suite_FV3_GFSv17alp_cpldnsstsasugwpnoahmp.xml <#393 (comment)>: > @@ -0,0 +1,95 @@ +<?xml version="1.0" encoding="UTF-8"?> + +<suite name="FV3_GFSv17alp_cpldnsstsasugwpnoahmp" version="1"> What difference is this suite file from the current P7 suite file which uses sas, nsst, noahmp, ugwp and ca? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#393 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALLVRYUSDKK7A3K2LEBFXE3UHWXSBANCNFSM5EP6RGYQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Dr. Shrinivas Moorthi Research Meteorologist Modeling and Data Assimilation Branch Environmental Modeling Center / National Centers for Environmental Prediction 5830 University Research Court - (W/NP23), College Park MD 20740 USA Tel: (301)683-3718 e-mail: ***@***.*** Phone: (301) 683-3718 Fax: (301) 683-3718

[SMoorthi-emc]

Well, they are using different gravity wave drag routines!

…

On Tue, Oct 19, 2021 at 2:07 PM Jun Wang ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In ccpp/suites/suite_FV3_GFSv17alp_cpldnsstrasnoahmp.xml <#393 (comment)>: > @@ -0,0 +1,95 @@ +<?xml version="1.0" encoding="UTF-8"?> + +<suite name="FV3_GFSv17alp_cpldnsstrasnoahmp" version="1"> can we remove this one if the next suite file FV3_GFSv17alp_cpldnsstrasugwpnoahmp is working? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#393 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALLVRYXO63AE2QE3YXBFJD3UHWXWZANCNFSM5EP6RGYQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Dr. Shrinivas Moorthi Research Meteorologist Modeling and Data Assimilation Branch Environmental Modeling Center / National Centers for Environmental Prediction 5830 University Research Court - (W/NP23), College Park MD 20740 USA Tel: (301)683-3718 e-mail: ***@***.*** Phone: (301) 683-3718 Fax: (301) 683-3718

[SMoorthi-emc]

It was "zero" when I was checking the rrtmgp RT test. It failed in my test because I was sending emissivity from ice calculated using the imported ulw. So, the emissivity became zero. Without my updates, the emissivity used is from old radiation_surface.f, which was I think 0.96. that is why rrtmgp did not fail before.

…

On Tue, Oct 19, 2021 at 2:39 PM Jun Wang ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In atmos_model.F90 <#393 (comment)>: > @@ -2490,6 +2491,15 @@ subroutine assign_importdata(jdat, rc) GFS_data(nb)%Coupling%hsnoin_cpl(ix) = min(hsmax, GFS_data(nb)%Coupling%hsnoin_cpl(ix) & / (GFS_data(nb)%Sfcprop%fice(ix)*GFS_data(nb)%Sfcprop%oceanfrac(ix))) GFS_data(nb)%Sfcprop%zorli(ix) = z0ice + tem = GFS_data(nb)%Sfcprop%tisfc(ix) * GFS_data(nb)%Sfcprop%tisfc(ix) + tem = con_sbc * tem * tem + if (GFS_data(nb)%Coupling%ulwsfcin_cpl(ix) > zero) then + GFS_data(nb)%Sfcprop%emis_ice(ix) = GFS_data(nb)%Coupling%ulwsfcin_cpl(ix) / tem + GFS_data(nb)%Sfcprop%emis_ice(ix) = max(0.9, min(one, GFS_data(nb)%Sfcprop%emis_ice(ix))) + else + GFS_data(nb)%Sfcprop%emis_ice(ix) = 0.96 + endif + GFS_data(nb)%Coupling%ulwsfcin_cpl(ix) = tem * GFS_data(nb)%Sfcprop%emis_ice(ix) I see, thanks. I am wondering how the previous version computes the ulwsfcin_cpl in rrtmgp test. If I remember correctly, @DeniseWorthen <https://github.com/DeniseWorthen> checked the upward long wave from ice when we were debugging the P7 restart issues, there is no issue with this field. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#393 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALLVRYXBAXYSCCNYIVEEVUTUHW3OHANCNFSM5EP6RGYQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Dr. Shrinivas Moorthi Research Meteorologist Modeling and Data Assimilation Branch Environmental Modeling Center / National Centers for Environmental Prediction 5830 University Research Court - (W/NP23), College Park MD 20740 USA Tel: (301)683-3718 e-mail: ***@***.*** Phone: (301) 683-3718 Fax: (301) 683-3718

[SMoorthi-emc]

Nevetheless, my change uses imported ULW, if it is nonzero; otherwise, it computes based on ice skin temperature assuming emissivity for ice as in radiation_surface.f.

[junwang-noaa]

Thanks for the explanation.

[climbfuji]

I merged the ccpp-physics PR, new hash is b12e6c3 - please update the submodule pointer in your fv3atm PR.

[SMoorthi-emc]

Done.

…

On Fri, Oct 22, 2021 at 12:19 AM Dom Heinzeller ***@***.***> wrote: I merged the ccpp-physics PR, new hash is b12e6c3 - please update the submodule pointer in your fv3atm PR. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#393 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALLVRYS4RJDPGK6ZH2HD4VTUIDQ6DANCNFSM5EP6RGYQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Dr. Shrinivas Moorthi Research Meteorologist Modeling and Data Assimilation Branch Environmental Modeling Center / National Centers for Environmental Prediction 5830 University Research Court - (W/NP23), College Park MD 20740 USA Tel: (301)683-3718 e-mail: ***@***.*** Phone: (301) 683-3718 Fax: (301) 683-3718

[junwang-noaa]

@SMoorthi-emc Can you check if you pushed the code changes? The PR does not point to CCPP main branch, there are still 11 changed files including ccpp physics.

[SMoorthi-emc]

Jun, It has correct hash "git submodule status 02c3bac atmos_cubed_sphere (201912_public_release-282-g02c3bac) 6874fc9b49237b70df7af9b513ea10df697c27d6 ccpp/framework (ccpp_transition_to_vlab_master_20190705-439-g6874fc9) b12e6c3 ccpp/physics (ccpp_transition_to_vlab_master_20190705-2055-gb12e6c32) Moorthi

…

On Fri, Oct 22, 2021 at 7:59 AM Jun Wang ***@***.***> wrote: @SMoorthi-emc <https://github.com/SMoorthi-emc> Can you check if you pushed the code changes? The PR does not point to CCPP main branch, there are still 11 changed files including ccpp physics. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#393 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALLVRYRXVA3CT5L76T5E6U3UIFGXDANCNFSM5EP6RGYQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Dr. Shrinivas Moorthi Research Meteorologist Modeling and Data Assimilation Branch Environmental Modeling Center / National Centers for Environmental Prediction 5830 University Research Court - (W/NP23), College Park MD 20740 USA Tel: (301)683-3718 e-mail: ***@***.*** Phone: (301) 683-3718 Fax: (301) 683-3718

[SMoorthi-emc]

Please see "https://github.com/SMoorthi-emc/fv3atm/tree/SM_Sept21_PR/ccpp" On Fri, Oct 22, 2021 at 8:27 AM Shrinivas Moorthi - NOAA Federal < ***@***.***> wrote:

…

Jun, It has correct hash "git submodule status 02c3bac atmos_cubed_sphere (201912_public_release-282-g02c3bac) 6874fc9b49237b70df7af9b513ea10df697c27d6 ccpp/framework (ccpp_transition_to_vlab_master_20190705-439-g6874fc9) b12e6c3 ccpp/physics (ccpp_transition_to_vlab_master_20190705-2055-gb12e6c32) Moorthi On Fri, Oct 22, 2021 at 7:59 AM Jun Wang ***@***.***> wrote: > @SMoorthi-emc <https://github.com/SMoorthi-emc> Can you check if you > pushed the code changes? The PR does not point to CCPP main branch, there > are still 11 changed files including ccpp physics. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#393 (comment)>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ALLVRYRXVA3CT5L76T5E6U3UIFGXDANCNFSM5EP6RGYQ> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > -- Dr. Shrinivas Moorthi Research Meteorologist Modeling and Data Assimilation Branch Environmental Modeling Center / National Centers for Environmental Prediction 5830 University Research Court - (W/NP23), College Park MD 20740 USA Tel: (301)683-3718 e-mail: ***@***.*** Phone: (301) 683-3718 Fax: (301) 683-3718

-- Dr. Shrinivas Moorthi Research Meteorologist Modeling and Data Assimilation Branch Environmental Modeling Center / National Centers for Environmental Prediction 5830 University Research Court - (W/NP23), College Park MD 20740 USA Tel: (301)683-3718 e-mail: ***@***.*** Phone: (301) 683-3718 Fax: (301) 683-3718

[climbfuji]

The submodule pointer for ccpp-physics is correct. But .gitmodules will need to be reverted.

The decision about the additional suite definition files lies with the FV3 code managers.

[climbfuji]

.gitmodules will need to be reverted

[SMoorthi-emc]

Sorry, I forgot that. It is done now.

…

On Fri, Oct 22, 2021 at 8:30 AM Dom Heinzeller ***@***.***> wrote: ***@***.**** requested changes on this pull request. The submodule pointer for ccpp-physics is correct. But .gitmodules will need to be reverted. The decision about the additional suite definition files lies with the FV3 code managers. ------------------------------ In .gitmodules <#393 (comment)>: > @@ -8,5 +8,5 @@ branch = main [submodule "ccpp/physics"] path = ccpp/physics - url = https://github.com/NCAR/ccpp-physics - branch = main + url = https://github.com/SMoorthi-emc/ccpp-physics + branch = SM_Sept21_PR .gitmodules will need to be reverted — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#393 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALLVRYS5WE3HDK6F7LRREKDUIFKMFANCNFSM5EP6RGYQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Dr. Shrinivas Moorthi Research Meteorologist Modeling and Data Assimilation Branch Environmental Modeling Center / National Centers for Environmental Prediction 5830 University Research Court - (W/NP23), College Park MD 20740 USA Tel: (301)683-3718 e-mail: ***@***.*** Phone: (301) 683-3718 Fax: (301) 683-3718