Modified 2 ugwp metadata files to fix ufs-community/ufs-weather-model… #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 'fhzero reproducibility' issue #908
|
@mdtoy would you please sync your ccpp physics and fv3atm branches with the latest develop branch? |
DusanJovic-NOAA
approved these changes
Nov 30, 2021
climbfuji
approved these changes
Nov 30, 2021
16 tasks
|
ccpp-physics hash is correct, ready to merge |
SamuelTrahanNOAA
pushed a commit
to SamuelTrahanNOAA/fv3atm
that referenced
this pull request
Jun 13, 2022
…ux init bug fix in CCPP (NOAA-EMC#425) * change the namelist setting for noahmp * Consolidate namelist templates for NoahMP tests Co-authored-by: Helin Wei <Helin.Wei@noaa.gov> Co-authored-by: Brian Curtis <brian.curtis@noaa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… 'fhzero reproducibility' issue #908
Description
This PR updates the .gitmodules pointer to NCAR/ccpp-physics branch that fixes a bug in the UGWP drag suite (both "unified_ugwp" and "ugwpv1_gsldrag" schemes) where the changing the "fhzero" (diagnostic bucket) variable in the input.nml would change the forecast, which should not happen. This does change the expected answer from Regression Testing.
Issue(s) addressed
This PR fixes ufs-community/ufs-weather-model issue #908
Testing
The update passed the Operation Requirement Testing. On Hera, see the following log file for the test result:
/scratch1/BMC/wrfruc/mtoy/git_local/ufs-weather-model/tests/OpnReqTests_hera.intel.log
Dependencies
None