Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent Restart filenames #625

Merged
merged 6 commits into from
Feb 27, 2023
Merged

Conversation

junwang-noaa
Copy link
Collaborator

Description

Currently FV3ATM writes out restart files using FMS, the restart file names at the end of forecast time is different from the intermediate restart files generated during forecast integration. The PR changes the restart file names at the end of forecast to make them consistent with those intermediate restart files.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

@junwang-noaa
Copy link
Collaborator Author

@DusanJovic-NOAA Code changes were made, please review again.

@DeniseWorthen Please update my fv3atm branch in your ufs-weather-model branch.

@junwang-noaa
Copy link
Collaborator Author

@DusanJovic-NOAA I was thinking about that too. The restart_endfcst is removed from the forecast grid comp. Please review again.

@DeniseWorthen FYI.

@jkbk2004 jkbk2004 merged commit 78bfe9e into NOAA-EMC:develop Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent time-stamps in restarts across various ufs-weather-model components.
4 participants