Changed UGWP diagnostic variable declaration intents from 'out' to 'inout'

[mdtoyNOAA]

Description

This pull request fixes Issue #37 of the ufs-community/ccpp-physics repository. The UGWP diagnostic variables (i.e., dusfc_ms, dvsfc_ms, tdaux2d_ms, datauy2d_ms, etc.) are declared with "intent(out)" and initialized in module unified_ugwp.F90, then they are passed to subroutine "drag_suite_run" (in drag_suite.F90). In this subroutine, the UGWP diagnostic variables should have been declared with "intent(inout)" instead of "intent(out)". This PR fixes this.
This PR does not change any results.

Issue(s) addressed

• Fixes Issue #37

Testing

How were these changes tested? Regression testing and ORT testing.
What compilers / HPCs was it tested with? Intel/Hera
Are the changes covered by regression tests? Yes. (But there are no baseline changes.)
Have the ufs-weather-model regression test been run? On what platform? Yes. Hera/Intel.

• Will the code updates change regression test baseline? No,
• Please commit the regression test log files in your ufs-weather-model branch

Dependencies

None.

[grantfirl]

@mdtoyNOAA ufs-community/ccpp-physics#40 has been merged. Please revert the changes to .gitmodules and update the ccpp/physics submodule pointer in anticipation of merge.

[jkbk2004]

@mdtoyNOAA ccpp pr was merged. can you update submodule pointer and revert change in gitmodules ?

[mdtoyNOAA]

Yes, but I won’t be able to get to it for about an hour and a half.

…

On Wednesday, February 22, 2023, JONG KIM ***@***.***> wrote: @mdtoyNOAA <https://github.com/mdtoyNOAA> ccpp pr was merged. can you update submodule pointer and revert change in gitmodules ? — Reply to this email directly, view it on GitHub <#627 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARRVLIA23COD5ZAALPKAPTTWYYTRTANCNFSM6AAAAAAU2554VU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- ————————— Michael Toy, Research Scientist CIRES, University of Colorado Boulder NOAA Global Systems Laboratory 325 Broadway, Boulder, Colorado ***@***.*** +1- <(303)%20497-4061>505-609-8782

[jkbk2004]

Yes, but I won’t be able to get to it for about an hour and a half.
…
On Wednesday, February 22, 2023, JONG KIM @.> wrote: @mdtoyNOAA https://github.com/mdtoyNOAA ccpp pr was merged. can you update submodule pointer and revert change in gitmodules ? — Reply to this email directly, view it on GitHub <#627 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARRVLIA23COD5ZAALPKAPTTWYYTRTANCNFSM6AAAAAAU2554VU . You are receiving this because you were mentioned.Message ID: @.>
-- ————————— Michael Toy, Research Scientist CIRES, University of Colorado Boulder NOAA Global Systems Laboratory 325 Broadway, Boulder, Colorado @.*** +1- <(303)%20497-4061>505-609-8782

Sure, no problem!

[mdtoyNOAA]

Done. I hope I did it correctly.