-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export evaporative flux from ATM #672
Conversation
* do not apply scaling to special values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm the scaled fields are only used for coupling with ocn, not by aerosol models. Otherwise the code looks good to me.
@junwang-noaa The scaling is only applied to the "mean" fields, which I don't believe are used anywhere else (for coupling itself). The full RTs have passed for all tests with only coupled tests changing. I will double check the first fields passed out of the ATM when aerosols are included. |
Fixing the scaling of the special value (huge) by rtime does change the fields coming out of the ATM at the first coupling timestep (dt=720s) when aerosols are included, but only at those points which contain the special value. They are otherwise identical. The four fields affected are the mean taux,y, sensible and latent. These fields have different maximum values (1.384612495609288E+34 vs 9.969209968386869E+36). The sfcf000.tileX.nc files are identical. |
Do you still have those files that I can take a look? Thanks |
Yes, the develop output is in /scratch1/NCEPDEV/stmp2/Denise.Worthen/FV3_RT/rt_9995/s2swa.dev. This is a sandbox of the /scratch1/NCEPDEV/stmp2/Denise.Worthen/FV3_RT/rt_9995/cpld_control_p8_intel with only the executable changed. |
I am curious, does the coupled test without aerosol have the same changes in the mean taux,y, sensible and latent? |
I've done another test using the current develop branch, but pointing to my FV3 branch. In this case, CMEPS is still using the laten_heat exported by the ATM so no answer changes are expected, but the exported fields will contain the impact of the scaling change in atmos_model. In my sandbox, s2swa.dev and s2swa.scale.dev have idential sfc and restart files. The mediator files (history and restart) show the only difference is the max value---the actual values are the same, they differ only in the areas which have a value huge. In one case it is the actual value huge, in the other it is huge*rtime. |
Thanks for the testing and confirming the change is only on the max values. |
Description
Adds the evaporative flux to the available export fields from the ATM.
Also adds a new procedure within the
block_data_copy
interface to prevent scaling of export values where the field contains a special value.Issue(s) addressed
Testing
Testing results will be posted in the associated UFS PR ufs-community/ufs-weather-model#1812
In brief, coupled tests using an active ATM and MOM6 will change baselines.
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs