-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use inline post with cubed sphere history output #680
Merged
jkbk2004
merged 6 commits into
NOAA-EMC:develop
from
DusanJovic-NOAA:cubed_sphere_history_output
Jul 31, 2023
Merged
Use inline post with cubed sphere history output #680
jkbk2004
merged 6 commits into
NOAA-EMC:develop
from
DusanJovic-NOAA:cubed_sphere_history_output
Jul 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 tasks
@BrianCurtis-NOAA could you review and approve in preparation for #1831 testing? Thank you |
BrianCurtis-NOAA
approved these changes
Jul 26, 2023
@DusanJovic-NOAA Please resolve the conflicts here. |
BrianCurtis-NOAA
approved these changes
Jul 28, 2023
@jkbk2004 testing is complete on #1831 . Please feel free to review this PR so we may begin the merge process. |
jkbk2004
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new model_configure parameter (history_file_on_native_grid) to allow history outputs on native (cubed sphere) grid to be created when inline post is enabled.
Fixes: ufs-community/ufs-weather-model#1803
Is a change of answers expected from this PR? No
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
Dependencies
N/A