Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mean to inst field names, part I #704

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Sep 27, 2023

Description

For fields imported to FV3atm from CICE6 and CMEPS, changes the field name alias used by FV3atm by removing the 'mean' prefix. Also renames the fields being exported by FV3atm as mean_prec_rate, mean_fprec_rate and mean_prec_rate_conv to being inst fields in each case. The values of these fields used to fill the export state are unchanged.

This is the first part of a two part commit sequence to change field names from mean->inst. This first commit will not change baselines.

Issue(s) addressed

Testing

Incremental testing has been done comparing this feature branch against a baseline created using the two dependent PRs on Hera. All baselines were B4B.

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

@DeniseWorthen DeniseWorthen marked this pull request as ready for review September 28, 2023 20:29
@zach1221
Copy link
Collaborator

zach1221 commented Oct 10, 2023

@DeniseWorthen testing is finished on ufs-wm PR #1925. @jkbk2004 we have the approvals needed, can you please go ahead to merge this PR?

@DeniseWorthen DeniseWorthen merged commit a13a239 into NOAA-EMC:develop Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clarify "mean" and "inst" coupled fields exchanged
4 participants