Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MYNN-EDMF, MYNN surface layer, and Thompson AA updates #712

Merged
merged 29 commits into from
Nov 17, 2023

Conversation

joeolson42
Copy link
Contributor

@joeolson42 joeolson42 commented Oct 16, 2023

Description

The following PR consists of updates to 3 schemes and related modules:

  1. MYNN-EDMF
  • optimization work: fixed 8-plume model instead of variable number plume. maintains performance
  • bug fix to correct grid mean vs in-cloud mixing ratios. Now requires namelist variable lcnorm (set to true)
  • adjustments to cloud pdf to better fit modified thompson scheme
  1. MYNN surface layer
  • tweak to Czil parameter to improve diurnal cycle of T and wsp.
  1. Thompson aerosol-aware microphysics
  • change to nucleation rates to fix marine drizzle problem
  • minimum effective radii of 7 microns over water

Testing

How were these changes tested? Case studies, RRFS retrospective runs
What compilers / HPCs was it tested with? Intel
Are the changes covered by regression tests? Yes
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? YES, because the changes are meant to modify te behavior of the model every time above 3 schemes are used. Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch. OK, when it's ready...

Dependencies

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

@zach1221 zach1221 requested a review from jkbk2004 November 15, 2023 21:17
Copy link
Collaborator

@jkbk2004 jkbk2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as the physics PR was thoroughly reviewed.

@jkbk2004
Copy link
Collaborator

@joeolson42 Physics PR was merged. Can you update hash and revert change in gitmodules? Correct hash is ufs-community/ccpp-physics@d566ea4

@grantfirl
Copy link
Collaborator

@joeolson42 Physics PR was merged. Can you update hash and revert change in gitmodules? Correct hash is ufs-community/ccpp-physics@d566ea4

@jkbk2004 @joeolson42 Done

@jkbk2004 jkbk2004 merged commit 34675c2 into NOAA-EMC:develop Nov 17, 2023
@DusanJovic-NOAA DusanJovic-NOAA mentioned this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants