Fix out of bound errors in block_atmos_copy routines #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
41 tasks
BrianCurtis-NOAA
approved these changes
Feb 1, 2024
41 tasks
jkbk2004
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes out of bounds array access in 6 overloaded block_atmos_copy subroutines in module_block_data (cpl/module_block_data.F90). See #776 for details.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested? Yes
What compilers / HPCs was it tested with? Intel/Hera
Are the changes covered by regression tests? I'm not sure but probably not, otherwise we would notice this issue earlier. fv3atm component must be coupled with another component that advertises one of the arrays what are copied by one of these 6 routines.
Have the ufs-weather-model regression test been run? Yes. On what platform? Hera
Dependencies
N/A