Bug fix for unallocated array sfcprop%wetness in GFS_diagnostics.F90 #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etness for RUC LSM
…review and testing
14 tasks
DusanJovic-NOAA
approved these changes
Feb 29, 2024
|
@climbfuji ccpp-framework pr has been merged, please revert change in gitmodule url and update the submodule hash |
|
@DusanJovic-NOAA This should be ready to merge |
jkbk2004
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #791 (see issue for more details).
I decided to still output this field another time, because it's got a different name and different unit than the already existing one.
Issue(s) addressed
Resolves #791
Testing
Tested extensively in my (yet to be created) PRs that convert all UFS DDTs from blocked data structures to chunked arrays.
Dependencies
This is part of a set of (independent) PRs: