Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fixes: kchunk3d ignored, hailwat uninitialized in dycore, tile_num wrong for nests #806

Merged
merged 11 commits into from
Apr 14, 2024
Merged

bug fixes: kchunk3d ignored, hailwat uninitialized in dycore, tile_num wrong for nests #806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d87527e
nesting fixes
SamuelTrahanNOAA Mar 19, 2024
956b0a6
update to head of develop
SamuelTrahanNOAA Mar 19, 2024
bdfa922
Merge remote-tracking branch 'origin/develop' into HEAD
SamuelTrahanNOAA Mar 25, 2024
7a90d9e
Point to sam's GFDL_atmos_cubed_sphere branch'
SamuelTrahanNOAA Mar 25, 2024
1086b6d
remove an unneeded write statemen
SamuelTrahanNOAA Mar 27, 2024
0d41274
remove another unneeded write statement
SamuelTrahanNOAA Mar 27, 2024
3a72d6c
Merge remote-tracking branch 'upstream/develop' into nesting-fixes
SamuelTrahanNOAA Apr 1, 2024
d46fa8c
Fix kchunk3d in io/module_write_netcdf.F90
DusanJovic-NOAA Apr 10, 2024
379f1e4
Merge remote-tracking branch 'upstream/develop' into nesting-fixes
SamuelTrahanNOAA Apr 11, 2024
cbd207b
Merge remote-tracking branch 'dusan/fix_kchunk3d' into nesting-fixes
SamuelTrahanNOAA Apr 11, 2024
7a92b72
point to authoritative atmos_cubed_sphere
SamuelTrahanNOAA Apr 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion atmos_cubed_sphere
Open in desktop
Submodule atmos_cubed_sphere updated 2 files
+4 −3 driver/fvGFS/atmosphere.F90
+1 −0 model/fv_nesting.F90
3 changes: 2 additions & 1 deletion atmos_model.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,8 @@ subroutine atmos_model_init (Atmos, Time_init, Time, Time_step)
call atmosphere_diag_axes (Atmos%axes)
call atmosphere_etalvls (Atmos%ak, Atmos%bk, flip=flip_vc)

call atmosphere_control_data (isc, iec, jsc, jec, nlev, p_hydro, hydro, tile_num)
tile_num=-1
call atmosphere_control_data (isc, iec, jsc, jec, nlev, p_hydro, hydro, global_tile_num=tile_num)

allocate (Atmos%lon(nlon,nlat), Atmos%lat(nlon,nlat))
call atmosphere_grid_ctr (Atmos%lon, Atmos%lat)
Expand Down
2 changes: 1 addition & 1 deletion io/module_write_netcdf.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ end function nf_set_log_level
if (is_cubed_sphere) then
chunksizes = [im, jm, lm, tileCount, 1]
else
chunksizes = [ichunk3d(grid_id), jchunk3d(grid_id), fldlev(i), 1]
chunksizes = [ichunk3d(grid_id), jchunk3d(grid_id), min(kchunk3d(grid_id),fldlev(i)), 1]
end if
ncerr = nf90_def_var_chunking(ncid, varids(i), NF90_CHUNKED, chunksizes) ; NC_ERR_STOP(ncerr)
end if
Expand Down
Loading