Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[production/RRFS.v1] To compile the model with new fms/2024.01 & RUC LSM deep soil temperature #852

Merged

Conversation

haiqinli
Copy link
Contributor

@haiqinli haiqinli commented Jun 26, 2024

Description

(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
-- 1). To compile the model with new fms/2024.1
2). Update the RUC LSM deep soil temperature from climatology to real foreast.

Is a change of answers expected from this PR?
-- Yes, the results from the suites with RUC LSM are changed.

Issue(s) and PR(s) addressed

ccpp dependece

ufs-community/ccpp-physics#217

Testing

How were these changes tested? The changes were with rt.conf_rrfs cases.
What compilers / HPCs was it tested with? Intel/GNU compilers on Hera.
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes.
Have the ufs-weather-model regression test been run? On what platform? Yes, on Hera.

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
    Yes, the suites with RUC LSM are changed.
  • Please commit the regression test log files in your ufs-weather-model branch
    Yes, the log file of RegressionTests_hera.log is committed.

Dependencies

@DusanJovic-NOAA
Copy link
Collaborator

Please specify the ccpp-physics PR that this PR depends on.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Jul 3, 2024

@MatthewPyle-NOAA This PR is ready for final review and approval.

Copy link
Collaborator

@MatthewPyle-NOAA MatthewPyle-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my perspective.

@jkbk2004 jkbk2004 merged commit 15b100f into NOAA-EMC:production/RRFS.v1 Jul 3, 2024
grantfirl pushed a commit to grantfirl/fv3atm that referenced this pull request Dec 5, 2024
…LSM deep soil temperature (NOAA-EMC#852)

* to compile the model with new fms/2024.01

* Update the RUC LSM deep soil temperature from climatology to real foreast.
jkbk2004 pushed a commit that referenced this pull request Jan 3, 2025
* [production/RRFS.v1] To compile the model with new fms/2024.01 & RUC LSM deep soil temperature (#852)

* Update the RUC LSM deep soil temperature from climatology to real foreast.

---------

Co-authored-by: haiqinli <38666296+haiqinli@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants