-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for NoahMP land component #886
base: develop
Are you sure you want to change the base?
Conversation
@uturuncoglu Is there a reason why this is still in DRAFT mode? |
@grantfirl I am working on a modification in the CCPP physics layer and currently testing it. Once it is done I'll mark this as a ready for review. Sorry, it took longer than expected due to other commitments. |
Thanks and no worries at all. I'm just checking up on PRs in the ccpp-physics list and noticed that this one had been in draft for a while. |
Description
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
This PR aims to bring new S2S configuration that includes also land component. It also updates suite_FV3_GFS_v17_coupled_p8.xml suite file to enable getting land fluxes from the land component model. The default behavior is not changed and the suite file will pass sfc_land scheme unless cpllnd2atm namelist option in input.nml is set to true.
What bug does it fix, or what feature does it add?
Is a change of answers expected from this PR? Yes, the land component related RT might have answer changes since we are skipping to get fluxes from land component in very first coupling time step and using fluxes computed in ccpp/physics version of NoahMP model.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs
Requirements before merging