Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update calculation of time-averaged radiation variables #900

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

LarissaReames-NOAA
Copy link

Description

This PR fixes incorrect diagnostic output for fhzero-averaged radiation output variables. Presently, there is a significant "sawtooth" appearance to these fields (such as dswrf_ave and ulwrf_avetoa) when we expect smoother lines with jumps only at fhzero diagnostic reset times. Here is an example of the present (OLD) result and the result from the current PR (FIX) from a 24-hour S2S regression test forecast.

iTerm2 RaUnsB rads_fhzero6_fix

Issue(s) addressed

  • fixes a problem found in investigating ufs-weather-model/#1767

Testing

Ran full regression test suite on Hera. See log files here: /scratch1/NAGAPE/hpc-wof1/lreames/ufs-weather-model/tests/logs/log_hera

Forecast output can be found here: /scratch1/NCEPDEV/stmp2/Larissa.Reames/FV3_RT/rt_4109245

All regression tests fail as sfcf*.nc files, as well as post-processed grib2 files as a result, are not identical. New baselines will be necessary.

Dependencies

  • waiting on noaa-emc/ccpp-physics/pull/241

Requirements before merging

  • All new code in this PR is tested by at least one unit test
  • All new code in this PR includes Doxygen documentation
  • All new code in this PR does not add new compilation warnings (check CI output)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant