Add CCPP host variable to track initialization of GFS_phys_time_vary, fix bug for MP Thompson init flag #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0,meta} and fix bug for Thompson MP init flag (used uninitialized, correct by coincidence)
This was referenced Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR goes together with ufs-community/ccpp-physics#242 and is needed to support multiple instances of CCPP physics within one host model execution.
While adding the
is_initflag for theGFS_phys_time_varyscheme, I noticed a bug for the corresponding flag for Thompson microphysics. Instead of initializing the GFS_control DDT member, the existing code initializes a local copy of the flag to false. This doesn't have any effect in the UFS, because any uninitialized logical flag is.false.by default.Issue(s) addressed
This PR and associated PRs below form the last set of PRs to replace NCAR/ccpp-physics#1000, which was created to support the case of multiple CCPP physics instances in one model run.
Testing
gcc@13.3.0,openmpi@5.0.5).Dependencies
Requirements before merging
All new code in this PR is tested by at least one unit testnot applicableAll new code in this PR includes Doxygen documentationnot applicable