Make gfs-utils compile on CSPs with Rocky 8 #81

weihuang-jedi · 2024-08-30T21:24:24Z

Support Rocky 8 on CSPs.

Description

Make gfs-utils compile on CSPs using Rocky 8.

Resolves #80

Type of change

New feature (adds functionality)

Change characteristics

Is this a breaking change (a change in existing functionality)? NO
Does this change require a documentation update? YES

How has this been tested?

Clone and build on AWS

Checklist

Any dependent changes have been merged and published
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
New and existing tests pass with my changes
I have made corresponding changes to the documentation if necessary

…cky8

aerorahul · 2024-09-14T01:30:40Z

modulefiles/gfsutils_noaacloud.intel.lua

+prepend_path("PATH", "/contrib/EPIC/bin")
+load("gnu")
+load("stack-intel")
+load("stack-intel-oneapi-mpi")

+stack_intel_ver=os.getenv("stack_intel_ver") or "2021.10.0"
 load(pathJoin("stack-intel", stack_intel_ver))
+
+stack_impi_ver=os.getenv("stack_impi_ver") or "2021.10.0"
 load(pathJoin("stack-intel-oneapi-mpi", stack_impi_ver))
+unload("gnu")


Not sure what is going on here.
loading gnu, intel and impi, then loading a specific version of the intel and impi, and finally unloading gnu?

also, why is PATH being updated here?

Yes, I feel that it is strange to load unload "gnu", but it seems that without load "gnu", we won't be able to load stack-intel properly.

The PATH update is not needed, check with SI team, and then tested to remove it.

what is the error without loading GNU?

…cky8

weihuang-jedi · 2024-10-16T22:31:01Z

could some one review this PR please?

modulefiles/gfsutils_noaacloud.intel.lua

weihuang-jedi · 2024-10-17T17:09:10Z

This is because in " detect_machine.sh" we did not check if MACHINE_ID is "noaacloud". Do you want add it there?

…

On Thu, Oct 17, 2024 at 10:57 AM Rahul Mahajan ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In modulefiles/gfsutils_noaacloud.intel.lua <#81 (comment)>: > @@ -2,15 +2,15 @@ help([[ Build environment for GFS utilities on NOAA Cloud ]]) -prepend_path("MODULEPATH", "/contrib/spack-stack/spack-stack-1.6.0/envs/unified-env/install/modulefiles/Core") -prepend_path("MODULEPATH", "/contrib/spack-stack/spack-stack-1.6.0/envs/gsi-addon-env/install/modulefiles/Core") +prepend_path("MODULEPATH", "/contrib/spack-stack-rocky8/spack-stack-1.6.0/envs/gsi-addon-env/install/modulefiles/Core") +prepend_path("MODULEPATH", "/apps/modules/modulefiles") +load("gnu") +load("stack-intel") +load("stack-intel-oneapi-mpi") +unload("gnu") Why is it returning WARNING: UNKNOWN PLATFORM? It should have detected noaacloud, no? — Reply to this email directly, view it on GitHub <#81 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASMCH67YHS2WERZBWSGNPZ3Z37T77AVCNFSM6AAAAABNNFMMXGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZVG44TAMBZG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

aerorahul · 2024-10-17T18:06:42Z

This is because in " detect_machine.sh" we did not check if MACHINE_ID is "noaacloud". Do you want add it there?
…
On Thu, Oct 17, 2024 at 10:57 AM Rahul Mahajan @.> wrote: @.* commented on this pull request. ------------------------------ In modulefiles/gfsutils_noaacloud.intel.lua <#81 (comment)>: > @@ -2,15 +2,15 @@ help([[ Build environment for GFS utilities on NOAA Cloud ]]) -prepend_path("MODULEPATH", "/contrib/spack-stack/spack-stack-1.6.0/envs/unified-env/install/modulefiles/Core") -prepend_path("MODULEPATH", "/contrib/spack-stack/spack-stack-1.6.0/envs/gsi-addon-env/install/modulefiles/Core") +prepend_path("MODULEPATH", "/contrib/spack-stack-rocky8/spack-stack-1.6.0/envs/gsi-addon-env/install/modulefiles/Core") +prepend_path("MODULEPATH", "/apps/modules/modulefiles") +load("gnu") +load("stack-intel") +load("stack-intel-oneapi-mpi") +unload("gnu") Why is it returning WARNING: UNKNOWN PLATFORM? It should have detected noaacloud, no? — Reply to this email directly, view it on GitHub <#81 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASMCH67YHS2WERZBWSGNPZ3Z37T77AVCNFSM6AAAAABNNFMMXGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZVG44TAMBZG4 . You are receiving this because you authored the thread.Message ID: @.***>

It should. Are you setting PW_CSP? Based on PW_CSP, MACHINE_ID is set to noaacloud

weihuang-jedi · 2024-10-17T19:36:37Z

PW_CSP is an ParallelWork env. var. we detect MACHINE_ID based on PW_CSP if it is on CSPs. Modified ush/module-setup to check PW_CSP and if it is on CSPs, get rid of the warning message. Code has push to branch. On Thu, Oct 17, 2024 at 12:07 PM Rahul Mahajan ***@***.***> wrote:

…

This is because in " detect_machine.sh" we did not check if MACHINE_ID is "noaacloud". Do you want add it there? … <#m_3216837295982062920_> On Thu, Oct 17, 2024 at 10:57 AM Rahul Mahajan *@*.*> wrote: @.** commented on this pull request. ------------------------------ In modulefiles/gfsutils_noaacloud.intel.lua <#81 (comment) <#81 (comment)>>: > @@ -2,15 +2,15 @@ help([[ Build environment for GFS utilities on NOAA Cloud ]]) -prepend_path("MODULEPATH", "/contrib/spack-stack/spack-stack-1.6.0/envs/unified-env/install/modulefiles/Core") -prepend_path("MODULEPATH", "/contrib/spack-stack/spack-stack-1.6.0/envs/gsi-addon-env/install/modulefiles/Core") +prepend_path("MODULEPATH", "/contrib/spack-stack-rocky8/spack-stack-1.6.0/envs/gsi-addon-env/install/modulefiles/Core") +prepend_path("MODULEPATH", "/apps/modules/modulefiles") +load("gnu") +load("stack-intel") +load("stack-intel-oneapi-mpi") +unload("gnu") Why is it returning WARNING: UNKNOWN PLATFORM? It should have detected noaacloud, no? — Reply to this email directly, view it on GitHub <#81 (comment) <#81 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASMCH67YHS2WERZBWSGNPZ3Z37T77AVCNFSM6AAAAABNNFMMXGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZVG44TAMBZG4 . You are receiving this because you authored the thread.Message ID: *@* .***> It should. Are you setting PW_CSP? Based on PW_CSP, MACHINE_ID is set to noaacloud — Reply to this email directly, view it on GitHub <#81 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASMCH66UWT4VZ3TLQ43RW73Z374ERAVCNFSM6AAAAABNNFMMXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRQGIYDMOBYGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

aerorahul · 2024-10-17T20:21:33Z

modulefiles/gfsutils_noaacloud.intel.lua

+stack_intel_ver=os.getenv("stack_intel_ver") or "2021.10.0"
 load(pathJoin("stack-intel", stack_intel_ver))
+stack_impi_ver=os.getenv("stack_impi_ver") or "2021.10.0"


Suggested change

stack_intel_ver=os.getenv("stack_intel_ver") or "2021.10.0"

load(pathJoin("stack-intel", stack_intel_ver))

stack_impi_ver=os.getenv("stack_impi_ver") or "2021.10.0"

local stack_intel_ver=os.getenv("stack_intel_ver") or "2021.10.0"

load(pathJoin("stack-intel", stack_intel_ver))

local stack_impi_ver=os.getenv("stack_impi_ver") or "2021.10.0"

what happened to the local change?

ush/module-setup.sh

…cky8

…ility

aerorahul

looks good.

weihuang-jedi added 2 commits August 30, 2024 21:12

Make gfs-util compile on CSPs with Rocky 8

5463313

Merge branch 'develop' of github.com:NOAA-EPIC/gfs-utils into csps-ro…

e2559b0

…cky8

aerorahul reviewed Sep 14, 2024

View reviewed changes

weihuang-jedi added 2 commits October 1, 2024 17:05

Merge branch 'develop' of github.com:NOAA-EPIC/gfs-utils into csps-ro…

73b25f7

…cky8

Remove unneeded path

008794d

weihuang-jedi force-pushed the csps-rocky8 branch from f4209e7 to 008794d Compare October 1, 2024 17:06

simplify modulefile

e5501fe

aerorahul requested changes Oct 17, 2024

View reviewed changes

modulefiles/gfsutils_noaacloud.intel.lua Outdated Show resolved Hide resolved

modulefiles/gfsutils_noaacloud.intel.lua Outdated Show resolved Hide resolved

version added

7c911e8

get rid of WARNING: UNKNOWN PLATFORM on CSPs

2584c5f

aerorahul reviewed Oct 17, 2024

View reviewed changes

aerorahul reviewed Oct 18, 2024

View reviewed changes

ush/module-setup.sh Outdated Show resolved Hide resolved

weihuang-jedi added 2 commits October 18, 2024 15:26

just check MACHINE_ID is noaacloud or not shuold be enough on CSPs

8f65f5c

Merge branch 'develop' of github.com:NOAA-EPIC/gfs-utils into csps-ro…

37624c1

…cky8

weihuang-jedi force-pushed the csps-rocky8 branch from 8f3a3b9 to 37624c1 Compare October 18, 2024 15:29

move local defines together, and keep load together to improve readib…

da0cc14

…ility

aerorahul approved these changes Oct 18, 2024

View reviewed changes

aerorahul merged commit 4848ecb into NOAA-EMC:develop Oct 18, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make gfs-utils compile on CSPs with Rocky 8 #81

Make gfs-utils compile on CSPs with Rocky 8 #81

weihuang-jedi commented Aug 30, 2024

aerorahul Sep 14, 2024

weihuang-jedi Oct 1, 2024

aerorahul Oct 17, 2024

weihuang-jedi commented Oct 16, 2024

weihuang-jedi commented Oct 17, 2024 via email

aerorahul commented Oct 17, 2024

weihuang-jedi commented Oct 17, 2024 via email

aerorahul Oct 17, 2024

aerorahul Oct 18, 2024

aerorahul left a comment

Make gfs-utils compile on CSPs with Rocky 8 #81

Make gfs-utils compile on CSPs with Rocky 8 #81

Conversation

weihuang-jedi commented Aug 30, 2024

Description

Type of change

Change characteristics

How has this been tested?

Checklist

aerorahul Sep 14, 2024

Choose a reason for hiding this comment

weihuang-jedi Oct 1, 2024

Choose a reason for hiding this comment

aerorahul Oct 17, 2024

Choose a reason for hiding this comment

weihuang-jedi commented Oct 16, 2024

weihuang-jedi commented Oct 17, 2024 via email

aerorahul commented Oct 17, 2024

weihuang-jedi commented Oct 17, 2024 via email

aerorahul Oct 17, 2024

Choose a reason for hiding this comment

aerorahul Oct 18, 2024

Choose a reason for hiding this comment

aerorahul left a comment

Choose a reason for hiding this comment