checkout.sh and build_all.sh fail for develop at 9118ab3 #1086
Labels
bug
Something isn't working
Comments
Closed
|
Commit 3467e86 changed the gfs_utils hash from 7bf599f to af933d3. Given this, ran the following test:
gfs-utils at 7bf599f contains The one app not successfully built was gfs_utils. |
WalterKolczynski-NOAA
added a commit
to WalterKolczynski-NOAA/global-workflow
that referenced
this issue
Oct 23, 2022
A recent update changed the name of the script that determines the machine to `detect_machine.sh`, so scripts that call that script had to be updated. The variable name holding the machine name has also changed (from `$target` to `$MACHINE_ID`) and it may now include a compiler at the end, so changes were necessary to account for that. The WW3 build is changed completely to use the UFS modules instead of maintaining separate modules in workflow that may use different module versions. Refs NOAA-EMC#1086
WalterKolczynski-NOAA
added a commit
to WalterKolczynski-NOAA/global-workflow
that referenced
this issue
Oct 23, 2022
A recent merge inadvertently removed the execute permissions from `checkout.sh`. Refs NOAA-EMC#1086
WalterKolczynski-NOAA
added a commit
that referenced
this issue
Oct 24, 2022
The recent update of the gfs_utils version in PR #1082 introduced some gfs_util that weren't accounted for in the original PR. gfs_utils changed the name of the script that determines the machine to `detect_machine.sh`, so scripts that call that script had to be updated. The variable name holding the machine name has also changed (from `$target` to `$MACHINE_ID`) and it may now include a compiler at the end, so changes were necessary to account for that. The WW3 build is changed completely to use the UFS modules to be consistent with the rest of UFS instead of maintaining separate modules in workflow that may use different module versions. Also reverts an inadvertent removal of execute permissions for `checkout.sh` Fixes #1086
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior
./checkout.shshould be an executable script../build_all.shshould build g-w appsCurrent behavior
./checkout.shis not executable from develop @ 9118ab3../build_all.shfails withFATAL: Unable to determine target machine.Machines affected
Only tested on Hera but expect the problem affects all machines supported by g-w.
To Reproduce
git clone https://github.com/NOAA-EMC/global-workflow.git .cd sorc./checkout.shThis fails with-bash: ./checkout.sh: Permission deniedchmod 755 checkout.sh./checkout.sh -gThis runs to completion../build_all.shThis fails withFATAL: Unable to determine target machineAdditional Information
When users clone g-w develop at 9118ab3, they can not immediately execute
checkout.sh. Instead they must manually change file permissions forcheckout.sh. After g-w repos are clonedbuild_all.shfails. As such users can not set up HOMEgfs from develop at 9118ab3 for a new experiment. They should not update an existing HOMEgfs with develop at 9118ab3 for the same reason.Possible Implementation
checkout.shshould be committed to the develop branch with execute permission.build_all.shexecutesgfs_utils.fd/ush/machine-setup.sh. gfs_utils hash af933d3 deletedmachine-setup.sh.build_all.shneeds to be updated with the appropriate script in gfs_utils hash af933d3. Alternatively,machine-setup.shneeds to be restored to gfs_utils or made available elsewhere.The text was updated successfully, but these errors were encountered: