Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ufs-weather-model hash to HR2 code tag #1500

Closed
JessicaMeixner-NOAA opened this issue Apr 21, 2023 · 8 comments · Fixed by #1827
Closed

Update ufs-weather-model hash to HR2 code tag #1500

JessicaMeixner-NOAA opened this issue Apr 21, 2023 · 8 comments · Fixed by #1827
Milestone
HR2

Comments

@JessicaMeixner-NOAA
Copy link
Contributor

JessicaMeixner-NOAA commented Apr 21, 2023 •
edited
Loading

Description

This issue is for updating the ufs-weather-model hash to HR2 code tag. This will make sure several physics changes and updates for the wave model (#1547) code changes are included for HR2.

Requirements

  • Update to ufs-weather-model tag

Acceptance Criteria (Definition of Done)
Be able to run HR2 from develop branch

Dependencies
Multiple ufs-weather-model PRs will need to be created and merged before the HR2 tag is ready.
WalterKolczynski-NOAA added a commit to WalterKolczynski-NOAA/global-workflow that referenced this issue Apr 25, 2023
@WalterKolczynski-NOAA
Update UFS to develop as of 2023 Apr 17
8ef27c1 
Updates the UFS model hash to the version as of 2023 Apr 17.

Some associated changes accompany this update
- Restart filenames for MOM6 (ufs-community/ufs-weather-model#1599)
- Remove store coriolis setting from MOM6 namelist (ufs-community/ufs-weather-model#1599)
- Change in atm 'log' file names (ufs-community/ufs-weather-model#1704)
- Additions to diag_table for frozen species (ufs-community/ufs-weather-model#1529)
- Restart quilting (ufs-community/ufs-weather-model#1633)
- Update to post itag (ufs-community/ufs-weather-model#1690)

The switch to restart quilting adds an additional constraint on the size of
write groups to be divisible by the number of tiles, so all were increased
to the next multiple of 6.

In the process of updating the diag tables, unused tables were removed.

Closes NOAA-EMC#1445
Closes NOAA-EMC#1499
Partially addresses NOAA-EMC#1277
See also NOAA-EMC#1500
WalterKolczynski-NOAA added a commit to WalterKolczynski-NOAA/global-workflow that referenced this issue Apr 26, 2023
@WalterKolczynski-NOAA
Update UFS to develop as of 2023 Apr 17
1e3e8c7 
Updates the UFS model hash to the version as of 2023 Apr 17.

Some associated changes accompany this update
- Restart filenames for MOM6 (ufs-community/ufs-weather-model#1599)
- Remove store coriolis setting from MOM6 namelist (ufs-community/ufs-weather-model#1599)
- Change in atm 'log' file names (ufs-community/ufs-weather-model#1704)
- Additions to diag_table for frozen species (ufs-community/ufs-weather-model#1529)
- Restart quilting (ufs-community/ufs-weather-model#1633)
- Update to post itag (ufs-community/ufs-weather-model#1690)

The switch to restart quilting adds an additional constraint on the size of
write groups to be divisible by the number of tiles, so all were increased
to the next multiple of 6.

In the process of updating the diag tables, unused tables were removed.

Closes NOAA-EMC#1445
Closes NOAA-EMC#1499
Partially addresses NOAA-EMC#1277
See also NOAA-EMC#1500
@HelinWei-NOAA
Copy link
Contributor

We have the new soil texture data and the soil color data. They need to be put into the official fixed directory. Also we change the way the NoahMP reads the parameter table. Now the table is part of input as a file instead of the model as a program. So this table file has to be put into some place and we need to have a soft link in the running script to access. So the first step is to create a global workflow issue to move those files and then I can update my workflow branch.

@WalterKolczynski-NOAA
Copy link
Contributor

The new table would probably go into the workflow parm directory, though if it is added to UFS we can just copy it from there during build instead of carrying around our own copy. We're trying to reduce the redundancy with UFS.

@HelinWei-NOAA
Copy link
Contributor

Also we found some fixed fields were created using the old grid files (many years ago). While some including oro were created by using the new grid files. There are some difference between them along the coastline. It is better to start over to create all fixed fields using the same grid files.

@HelinWei-NOAA
Copy link
Contributor

I prefer the first approach. It is more straightforward to me.

The new table would probably go into the workflow parm directory, though if it is added to UFS we can just copy it from there during build instead of carrying around our own copy. We're trying to reduce the redundancy with UFS.

@WalterKolczynski-NOAA
Copy link
Contributor

Isn't UFS going to need the new table too, though?

@HelinWei-NOAA
Copy link
Contributor

Actually only UFS needs this table. Like input.nml, it is an input for running UFS.

Isn't UFS going to need the new table too, though?

@JessicaMeixner-NOAA JessicaMeixner-NOAA added this to the HR2 milestone Apr 27, 2023
@JessicaMeixner-NOAA JessicaMeixner-NOAA changed the title Updates for HR2 Update ufs-weeather-model hash to HR2 code tag May 2, 2023
@JessicaMeixner-NOAA
Copy link
Contributor Author

@HelinWei-NOAA to make it more clear that this PR is only to update the ufs-weather-model tag, I have updated the title and contents of this PR. If there are namelist, input file or other changes needed for an HR2 related update, please make a new issue and put the HR2 as the milestone.

@junwang-noaa
Copy link
Contributor

@HelinWei-NOAA if I understand correctly, the model needs to be updated to read in the soil color, we can create a new model tag after the code is committed. Thanks

@JessicaMeixner-NOAA JessicaMeixner-NOAA changed the title Update ufs-weeather-model hash to HR2 code tag Update ufs-weather-model hash to HR2 code tag Aug 4, 2023
@JessicaMeixner-NOAA JessicaMeixner-NOAA mentioned this issue Aug 29, 2023
Merged
7 tasks
WalterKolczynski-NOAA pushed a commit that referenced this issue Aug 30, 2023
@JessicaMeixner-NOAA
Final Updates for HR2 (#1827)
63270da 
This PR has the final updates for HR2.  There was one added variable for diagnostic output: 
`iopt_diag=3` and required from land team. This also points to HR2 updates for initial conditions
which update the land states in `sfc*` files compared to HR1. Lastly, it was determined that the
setting to enable running on hera `WRTTASK_PER_GROUP_PER_THREAD_PER_TILE_GFS=20`
actually will fail on WCOSS2. While not ideal, a setting that would run out of the box on both
hera and wcoss2 for C768 could not be found, therefore a comment was added noting WCOSS2
needs to use a different setting until it can be resolved.

Resolves #1500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
HR2
Development

Successfully merging a pull request may close this issue.

Final Updates for HR2 JessicaMeixner-NOAA/global-workflow
4 participants
@JessicaMeixner-NOAA @WalterKolczynski-NOAA @junwang-noaa @HelinWei-NOAA