Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syntax in config.ocnanalrun #1170

Closed
wants to merge 2 commits into from

Conversation

lgannoaa
Copy link
Contributor

Provide update for file config.ocnanalrun to address #1164

parm/config/config.ocnanalrun Fixed Show resolved Hide resolved
@aerorahul
Copy link
Contributor

Just an FYI here.
This particular violation is a bit pesky and there is no easy way to automagically fix it in a "readable" form.
The error code is SC2086

There are 2 formats that the shellchecker recognizes

$HOME/$dir/dist/bin/$file        # Unquoted (bad)
"$HOME"/"$dir"/dist/bin/"$file"  # Minimal quoting (good)
"$HOME/$dir/dist/bin/$file"      # Canonical quoting (good)

The automatic checker applies the minimal quoting, which IMHO is a bit annoying to read.
The canonical quoting makes it readable, but the auto fix does not apply it.

I think this is an eternal issue and IMO, we should disable this error code from flagging it.

@WalterKolczynski-NOAA has an issue open with shellcheck to provide an option to apply canonical fix if desired by the user.

@guillaumevernieres
Copy link
Contributor

I'm closing this PR, the issue is addressed in #1172 . Sorry @lgannoaa , I'll make sure to assign myself next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants