Use fracoro data for all new UFS applications

[ChunxiZhang-NOAA]

Description

The new fracoro data should be used for all new UFS applications no matter if it uses frac_grid or not.

Most problems in Issue#863 have been resolved. However, one problem remains, e.g., the latest fix, mask and oro datasets (fracoro) created by Shan/Mike/Helin should work for both fractional and non-fractional grid.

Related to the changes in UFS_UTILS. A PR#714 in UFS_UTILS has been created.

Fixes #863

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

The Forecast-only tests were successful on Orion. The tests are: Atmosphere-only C96 for FRAC_GRID on and off, respectively; Coupled c384 for GRAC_GRID on and off, respectively. However, the test for GLDAS is not done.

• Clone and Build tests on WCOSS Dell P3
• Cycled test on Orion
• Forecast-only test on Hera

Checklist
This PR requires an upstream UFS_UTILS PR#741.

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes need updates to the documentation. I have made corresponding changes to the documentation
• My changes generate no new warnings
• New and existing tests pass with my changes
• Any dependent changes have been merged and published

[aerorahul]

@ChunxiZhang-NOAA @yangfanglin

Following up on the discussion in the coupled modeling group meeting, since we are moving to using fractional grid, can we replace/remove all instances where non-fractional grid are used? Basically, only have fractional grid option in the system.

❯❯❯ grep -r -B2 -A4 FRAC_GRID *
parm/config/config.fcst-#coupling settings
parm/config/config.fcst-export cplmode="nems_frac"
parm/config/config.fcst:if [[ "${FRAC_GRID:-".true."}" = ".false." ]]; then
parm/config/config.fcst-  export cplmode="nems_orig"
parm/config/config.fcst-fi
--
parm/config/config.base.emc.dyn:export FRAC_GRID=".true."
--
scripts/exgdas_atmos_gldas.sh:# Set FIXgldas subfolder based on FRAC_GRID value
scripts/exgdas_atmos_gldas.sh:if [[ "${FRAC_GRID:-".true."}" = ".true." ]] ; then
scripts/exgdas_atmos_gldas.sh-  ln -fs "${FIXgldas}/frac_grid/FIX_T${JCAP}" "${RUNDIR}/FIX"
scripts/exgdas_atmos_gldas.sh-else
scripts/exgdas_atmos_gldas.sh-  ln -fs "${FIXgldas}/nonfrac_grid/FIX_T${JCAP}" "${RUNDIR}/FIX"
scripts/exgdas_atmos_gldas.sh-fi
--
ush/parsing_namelists_FV3.sh:  frac_grid    = ${FRAC_GRID:-".true."}

Basically,

• we no longer need to define FRAC_GRID in config.base.
• we no longer need to have logic if [ ${FRAC_GRID} ... ]; then anywhere
• update scripts/exgdas_atmos_gldas.sh to remove the if logic for FRAC_GRID
• set frac_grid = .true. in the namelist

[ChunxiZhang-NOAA]

@aerorahul Good idea. I will remove FRAC_GRID conditions in the workflow as you suggested.

[WalterKolczynski-NOAA]

@ChunxiZhang-NOAA Should this still be a draft, or is it ready to review?

[ChunxiZhang-NOAA]

@WalterKolczynski-NOAA It is still a draft.

[ChunxiZhang-NOAA]

@aerorahul All applications will use the new fracoro data since this dataset can be used by both fractional and non-fractional grids. After a discussion with Fanglin, we will keep the option grid_frac, but all fix directories point to new fracoro dataset.

[aerorahul]

@aerorahul All applications will use the new fracoro data since this dataset can be used by both fractional and non-fractional grids. After a discussion with Fanglin, we will keep the option grid_frac, but all fix directories point to new fracoro dataset.

That is fine.

• All applications will use fractional grid datasets. Non-fractional datasets will continue to reside on the systems, but will not be used.
• Applications will retain the frac_grid = .true. | .false. functionality via the input.nml

[WalterKolczynski-NOAA]

I'm ready to merge this once testing is confirmed to be complete (no testing is listed in the PR).

[ChunxiZhang-NOAA]

I updated the testing in "How Has This Been Tested?". Note that is PR required the upstream UFS_UTILS PR#741.

[WalterKolczynski-NOAA]

@ChunxiZhang-NOAA did the UFS Utils PR need to be merged first for this to work? If so, I'll need to revert.

[ChunxiZhang-NOAA]

@WalterKolczynski-NOAA The UFS_UTILS PR needs to be merged first.

[WalterKolczynski-NOAA]

@WalterKolczynski-NOAA The UFS_UTILS PR needs to be merged first.

@ChunxiZhang-NOAA Okay, please open the PR again and keep it as a draft until the UFS UTILS PR is merged and you have updated the PR to update the UFS UTILS hash.

Also, in the future, please be clearer when a PR depends on another PR to be merged first (use the words "Depends on ". "Related to" does not imply a dependency of this PR on that one.

[ChunxiZhang-NOAA]

@WalterKolczynski-NOAA Sorry for the confusion. I've created a new draft PR#1242.