Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fire blending to GOCART #2883
base: develop
Are you sure you want to change the base?
Add fire blending to GOCART #2883
Changes from 56 commits
c8e6344
4d81cb8
5f86abd
62dbf31
ae3f599
16e21bd
b22d7bc
9965857
5b57604
1f95b2b
eb8bc78
9a9a874
3b87649
21d7bad
58e7280
f74f471
945508f
eb53925
55d7ada
4aec698
2d8155d
389f9da
2875b6e
404131d
ca87ed9
9ff202f
55d5892
f853e4f
4dfba87
dc5c8bc
dbc63e8
a43e0c6
6836bfc
4e30517
d0b20b4
1fa7df1
d1dad35
4a696b3
8d9a124
42da2da
9753ddc
84edf69
9583817
ec4f462
65572fa
ffb8664
7a1efd1
b628f29
3c170db
d44c5b9
5d2f493
f204898
e7bf48a
eab4554
71a0547
d6ce0ab
313cb62
438c421
8a471fa
1df78dd
4e660a5
f4a31bd
c379b5c
82a2805
6d12fb3
934c95f
46838fd
d6e8fc1
5039957
5124844
9b86ea7
5cdd6a6
4ced2d2
d8b6d29
511629c
6ecf5c6
98ab6e6
7aae5e9
1b56d63
7ea3b68
5ce4047
0670aae
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for the check against
$RUN
? Presumably, if$AERO_EMIS_FIRE
is blending, we want to use blending regardless of the$RUN
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure... Rahul asked to add this but
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this was only GEFS related, I suggested the
RUN
condition check. Pretty sure, SFS will need that as well in the future.I can go either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather rely on the app config to know whether it wants blending.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is
vdate
coming from in this function scope?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated it to use
$current_cycle
instead, consistent with theaero_emissions.yaml
. Is that ok?