Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine issue and PR templates #2947

Conversation

WalterKolczynski-NOAA
Copy link
Contributor

Description

Refines the issue and PR templates to cover some shortcomings and pitfalls we have identified.

The fix file issue template is expanded to cover other data sets managed under "glopara".

Resolves #2589

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

N/A

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

Refines the issue and PR templates to cover some shortcomings and
pitfalls we have identified.

The fix_file issue template is expanded to cover other data sets
managed under "glopara".

Resolves NOAA-EMC#2589
aerorahul
aerorahul previously approved these changes Sep 23, 2024
@DavidHuber-NOAA
Copy link
Contributor

Co-authored-by: David Huber <69919478+DavidHuber-NOAA@users.noreply.github.com>
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for doing this, especially the static_data one!

.github/ISSUE_TEMPLATE/static_data.yml Show resolved Hide resolved
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @WalterKolczynski-NOAA !

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit ec63492 into NOAA-EMC:develop Sep 23, 2024
5 checks passed
@WalterKolczynski-NOAA WalterKolczynski-NOAA deleted the feature/update_issue_tmpl branch September 23, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue templates are too "rigid"
4 participants