Update JGDAS ENKF SELECT OBS JGLOBAL_ATMOS_ANALYSIS and JGLOBAL_ATMOS_ANALYSIS_CALC jobs #3092

mingshichen-noaa · 2024-11-12T20:19:02Z

Description

NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the global jgdas enkf select obs job and relevant .JGLOBAL_ATMOS_ANALYSIS and JGLOBAL_ATMOS_ANALYSIS_CALC jobs.

Refs #2451

Type of change

Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

Is this a breaking change (a change in existing functionality)? NO
Does this change require a documentation update? NO

How has this been tested?

Clone and build on RDHPCS
Cycled tests on Hercules
Forecast-only tests on Hercules

Checklist

Any dependent changes have been merged and published
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
New and existing tests pass with my changes
I have made corresponding changes to the documentation if necessary

…lect_obs_com_in_out

jobs/JGDAS_ENKF_SELECT_OBS

aerorahul

looks good. I am no longer familiar w/ the IN and OUT of EnKF related data, so would appreciate a review from @CatherineThomas-NOAA @RussTreadon-NOAA

KateFriedman-NOAA

Looks good! Please resolve the shellcheck warning in jobs/JGDAS_ENKF_SELECT_OBS and then I can approve.

jobs/JGDAS_ENKF_SELECT_OBS

aerorahul

looks good to me.

KateFriedman-NOAA

Looks good, thanks @mingshichen-noaa !

emcbot · 2024-11-15T10:31:47Z

Experiment C96C48_hybatmDA FAILED on Hera in Build# 1 in
/scratch1/NCEPDEV/global/CI/3092/RUNTESTS/EXPDIR/C96C48_hybatmDA_01216a52

emcbot · 2024-11-15T10:37:47Z

Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 1 with error logs:

/scratch1/NCEPDEV/global/CI/3092/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA_01216a52/logs/2021122018/enkfgdas_eobs.log

Follow link here to view the contents of the above file(s): (link)

emcbot · 2024-11-15T10:37:53Z

Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 1 in
/scratch1/NCEPDEV/global/CI/3092/RUNTESTS/EXPDIR/C96C48_hybatmaerosnowDA_01216a52

emcbot · 2024-11-15T13:22:13Z

CI Failed on Hera in Build# 1
Built and ran in directory /scratch1/NCEPDEV/global/CI/3092


Experiment C96C48_hybatmDA_01216a52 Terminated with 0
FAIL
FAIL tasks failed and 1 dead at Fri Nov 15 10:31:28 UTC 2024
Experiment C96C48_hybatmDA_01216a52 Terminated: *FAIL*
Error logs:
/scratch1/NCEPDEV/global/CI/3092/RUNTESTS/COMROOT/C96C48_hybatmDA_01216a52/logs/2021122100/enkfgdas_eobs.log
Experiment C96C48_hybatmaerosnowDA_01216a52 Terminated with 0
FAIL
FAIL tasks failed and 1 dead at Fri Nov 15 10:37:33 UTC 2024
Experiment C96C48_hybatmaerosnowDA_01216a52 Terminated: *FAIL*
Error logs:
/scratch1/NCEPDEV/global/CI/3092/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA_01216a52/logs/2021122018/enkfgdas_eobs.log
Experiment C96_S2SWA_gefs_replay_ics_01216a52 Completed 1 Cycles: *SUCCESS* at Fri Nov 15 11:07:58 UTC 2024
Experiment C48_ATM_01216a52 Completed 2 Cycles: *SUCCESS* at Fri Nov 15 11:20:08 UTC 2024
Experiment C48mx500_3DVarAOWCDA_01216a52 Completed 2 Cycles: *SUCCESS* at Fri Nov 15 11:20:09 UTC 2024
Experiment C48_S2SWA_gefs_01216a52 Completed 1 Cycles: *SUCCESS* at Fri Nov 15 12:21:30 UTC 2024
Experiment C96_atm3DVar_01216a52 Completed 3 Cycles: *SUCCESS* at Fri Nov 15 12:45:34 UTC 2024
Experiment C48_S2SW_01216a52 Completed 2 Cycles: *SUCCESS* at Fri Nov 15 13:03:46 UTC 2024
Experiment C96C48_ufs_hybatmDA_01216a52 Completed 3 Cycles: *SUCCESS* at Fri Nov 15 13:22:01 UTC 2024

aerorahul · 2024-11-15T22:45:24Z

@mingshichen-noaa
The tests failed overnight because of changes made in the j-job impacted the scripts called by the j-job.

mingshichen-noaa · 2024-11-21T16:51:43Z

@aerorahul @WalterKolczynski-NOAA @KateFriedman-NOAA
Since JGDAS_ENKF_SELECT_OBS job is associated with JGLOBAL_ATMOS_ANALYSIS and JGLOBAL_ATMOS_ANALYSIS_CALC jobs, I have made changing the original COM_* variables into the corresponding COMIN_* or COMOUT_* variables. Please review the adding commits. Thanks in advance.

KateFriedman-NOAA

Looks good for the most part. Left one comment to resolve before approving. Thanks!

scripts/exglobal_atmos_analysis.sh

KateFriedman-NOAA · 2024-11-21T17:46:24Z

@mingshichen-noaa Since this PR now also includes COM updates for the analysis job, please update the PR title and description to reflect the file changeset. Thanks!

KateFriedman-NOAA

COM updates look good, thanks @mingshichen-noaa ! Approve pending successful completion of CI testing.

mingshichen-noaa · 2024-11-21T18:46:00Z

@aerorahul @KateFriedman-NOAA @AntonMFernando-NOAA
Just now I checked COM to COMIN/COMOUT Tracker and found Anton planned to work on the two jobs ( JGLOBAL_ATMOS_ANALYSIS and JGLOBAL_ATMOS_ANALYSIS_CALC). Could you tell me how I should handle this case?

KateFriedman-NOAA · 2024-11-21T18:58:29Z

@aerorahul @KateFriedman-NOAA @AntonMFernando-NOAA Just now I checked COM to COMIN/COMOUT Tracker and found Anton planned to work on the two jobs ( JGLOBAL_ATMOS_ANALYSIS and JGLOBAL_ATMOS_ANALYSIS_CALC). Could you tell me how I should handle this case?

@mingshichen-noaa Thanks for checking on this! Since the change for the eobs job requires companion updates to the analysis/analysis_calc jobs at the same time then it was necessary to submit the changes together. Hopefully @AntonMFernando-NOAA hasn't already done much work on those job scripts. :)

In the future, I suggest checking the spreadsheet sooner if you think you need to update other job scripts at the same time. If someone else has already assigned themself to that job then you should reach out to them to say you can take care of it within your work or collaborate with the other developer if they have already begun making changes. Hope that helps!

KateFriedman-NOAA · 2024-11-21T19:00:32Z

@mingshichen-noaa please update the COM update tracking spreadsheet to reflect the analysis/analysis_calc job updates, thanks!

mingshichen-noaa · 2024-11-21T19:09:00Z

@KateFriedman-NOAA
Thank you for your prompt reply and suggestion.

mingshichen-noaa · 2024-11-21T19:18:34Z

@KateFriedman-NOAA @AntonMFernando-NOAA
I have updated https://docs.google.com/spreadsheets/d/1S4deVHNEgSR_6-q2lDOaXq4kW-4SmxurxH-q5iPVd6o/edit?pli=1&gid=0#gid=0 about

Mingshi Chen added 2 commits November 8, 2024 15:25

changing COM_ into COMIN_ or COMOUT_

fcd075e

Merge remote-tracking branch 'emc/develop' into feature/jgdas_enkf_se…

c1d9f8c

…lect_obs_com_in_out

mingshichen-noaa requested review from RussTreadon-NOAA, CoryMartin-NOAA and CatherineThomas-NOAA as code owners November 12, 2024 20:19

mingshichen-noaa removed request for CoryMartin-NOAA, RussTreadon-NOAA and CatherineThomas-NOAA November 12, 2024 20:19

github-advanced-security bot found potential problems Nov 12, 2024

View reviewed changes

jobs/JGDAS_ENKF_SELECT_OBS Fixed Show resolved Hide resolved

mingshichen-noaa requested review from WalterKolczynski-NOAA, KateFriedman-NOAA and DavidHuber-NOAA November 12, 2024 20:20

mingshichen-noaa self-assigned this Nov 12, 2024

mingshichen-noaa added the CI/CD Issue related to CI/CD label Nov 12, 2024

aerorahul reviewed Nov 12, 2024

View reviewed changes

jobs/JGDAS_ENKF_SELECT_OBS Outdated Show resolved Hide resolved

aerorahul reviewed Nov 12, 2024

View reviewed changes

aerorahul requested review from RussTreadon-NOAA, CatherineThomas-NOAA and DavidGrumm-NOAA November 12, 2024 20:30

don't need -m 755 in mkdir

1ff5591

KateFriedman-NOAA reviewed Nov 13, 2024

View reviewed changes

DavidHuber-NOAA reviewed Nov 13, 2024

View reviewed changes

jobs/JGDAS_ENKF_SELECT_OBS Outdated Show resolved Hide resolved

TerrenceMcGuinness-NOAA removed the CI/CD Issue related to CI/CD label Nov 13, 2024

remove trailing space on line 37

677b8ca

aerorahul previously approved these changes Nov 13, 2024

View reviewed changes

Merge branch 'develop' into feature/jgdas_enkf_select_obs_com_in_out

01216a5

KateFriedman-NOAA previously approved these changes Nov 14, 2024

View reviewed changes

WalterKolczynski-NOAA previously approved these changes Nov 15, 2024

View reviewed changes

WalterKolczynski-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Nov 15, 2024

emcbot removed the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Nov 15, 2024

emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Nov 15, 2024

changing COM_ into COMIN_ or COMOUT_

ad1aa96

mingshichen-noaa dismissed stale reviews from WalterKolczynski-NOAA, KateFriedman-NOAA, and aerorahul via ad1aa96 November 21, 2024 14:46

mingshichen-noaa added 6 commits November 21, 2024 08:58

changing COM_ATMOS_ANALYSIS int COMOUT_ATMOS_ANALYSIS

ebdb0ba

changing COM_ into COMIN_ or COMOUT_

3337cc4

modified JGLOBAL_ATMOS_ANALYSIS_CALC

5abb226

changing COMOUT_ATMOS_RESTART into COMIN_ATMOS_RESTART

f0be27e

changing COM_ into COMOUT

4fa5030

changing COM_ into COMIN_ or COMOUT_

7a956aa

mingshichen-noaa requested a review from GeorgeGayno-NOAA as a code owner November 21, 2024 16:31

KateFriedman-NOAA requested changes Nov 21, 2024

View reviewed changes

scripts/exglobal_atmos_analysis.sh Outdated Show resolved Hide resolved

COMOUT_OBS into COMIN_OBS

ca1829b

mingshichen-noaa changed the title ~~Update JGDAS ENKF SELECT OBS job~~ Update JGDAS ENKF SELECT OBS JGLOBAL_ATMOS_ANALYSIS and JGLOBAL_ATMOS_ANALYSIS_CALC jobs Nov 21, 2024

KateFriedman-NOAA approved these changes Nov 21, 2024

View reviewed changes

Merge branch 'develop' into feature/jgdas_enkf_select_obs_com_in_out

4988539

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update JGDAS ENKF SELECT OBS JGLOBAL_ATMOS_ANALYSIS and JGLOBAL_ATMOS_ANALYSIS_CALC jobs #3092

Update JGDAS ENKF SELECT OBS JGLOBAL_ATMOS_ANALYSIS and JGLOBAL_ATMOS_ANALYSIS_CALC jobs #3092

mingshichen-noaa commented Nov 12, 2024 •

edited

Loading

aerorahul left a comment

KateFriedman-NOAA left a comment

aerorahul left a comment

KateFriedman-NOAA left a comment

emcbot commented Nov 15, 2024

emcbot commented Nov 15, 2024

emcbot commented Nov 15, 2024

emcbot commented Nov 15, 2024

aerorahul commented Nov 15, 2024

mingshichen-noaa commented Nov 21, 2024

KateFriedman-NOAA left a comment

KateFriedman-NOAA commented Nov 21, 2024

KateFriedman-NOAA left a comment

mingshichen-noaa commented Nov 21, 2024

KateFriedman-NOAA commented Nov 21, 2024

KateFriedman-NOAA commented Nov 21, 2024

mingshichen-noaa commented Nov 21, 2024

mingshichen-noaa commented Nov 21, 2024

Update JGDAS ENKF SELECT OBS JGLOBAL_ATMOS_ANALYSIS and JGLOBAL_ATMOS_ANALYSIS_CALC jobs #3092

Are you sure you want to change the base?

Update JGDAS ENKF SELECT OBS JGLOBAL_ATMOS_ANALYSIS and JGLOBAL_ATMOS_ANALYSIS_CALC jobs #3092

Conversation

mingshichen-noaa commented Nov 12, 2024 • edited Loading

Description

Type of change

Change characteristics

How has this been tested?

Checklist

aerorahul left a comment

Choose a reason for hiding this comment

KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

aerorahul left a comment

Choose a reason for hiding this comment

KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

emcbot commented Nov 15, 2024

emcbot commented Nov 15, 2024

emcbot commented Nov 15, 2024

emcbot commented Nov 15, 2024

aerorahul commented Nov 15, 2024

mingshichen-noaa commented Nov 21, 2024

KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

KateFriedman-NOAA commented Nov 21, 2024

KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

mingshichen-noaa commented Nov 21, 2024

KateFriedman-NOAA commented Nov 21, 2024

KateFriedman-NOAA commented Nov 21, 2024

mingshichen-noaa commented Nov 21, 2024

mingshichen-noaa commented Nov 21, 2024

mingshichen-noaa commented Nov 12, 2024 •

edited

Loading