Skip to content

update model for vector regridding #3651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JessicaMeixner-NOAA
Copy link
Contributor

Description

This PR updates ufs-weather-model with several commits (see: ufs-community/ufs-weather-model@4a56620...b81282e) . Some updates of note:

Changes to forecast model output is expected with the improvements to mitigate grid imprinting.

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.): Routine update of model

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

  • Tests on Gaea are in progress.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aerorahul aerorahul removed the request for review from WalterKolczynski-NOAA May 6, 2025 13:29
@JessicaMeixner-NOAA
Copy link
Contributor Author

My tests on gaea didn't run as expected (user error) last night. But they've gotten past forecasts in at least one test. I'll post additional updates later today.

@aerorahul
Copy link
Contributor

@JessicaMeixner-NOAA
Thanks for the update. Let us know when your tests have concluded, and we can spawn the CI on the other platforms.

@CatherineThomas-NOAA CatherineThomas-NOAA moved this to Model - To Do/In Progress in GFS v17 May 6, 2025
@JessicaMeixner-NOAA
Copy link
Contributor Author

@aerorahul - All of my tests on gaea c6 succeeded except for the archiving jobs since I forgot to turn that off w/hpss maintenance. I ran all of the GFS tests.

@aerorahul aerorahul added the CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules label May 6, 2025
@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules labels May 6, 2025
@aerorahul aerorahul added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 labels May 7, 2025
@emcbot emcbot added CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 CI-Gaeac6-Running and removed CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 labels May 7, 2025
@emcbot
Copy link

emcbot commented May 7, 2025

Experiment C96C48mx500_S2SW_cyc_gfs FAILED on Gaeac6 in Build# 2 with error logs:

/gpfs/f6/drsa-precip3/world-shared/global/CI/3651/RUNTESTS/COMROOT/C96C48mx500_S2SW_cyc_gfs_05c9a66f/logs/2021122100/enkfgfs_earc_tars_01.log

Follow link here to view the contents of the above file(s): (enkfgfs_earc_tars_01.log)

@emcbot emcbot added CI-Gaeac6-Failed **Bot use only** CI testing on Gaea C6 for this PR has failed and removed CI-Gaeac6-Running labels May 7, 2025
@emcbot
Copy link

emcbot commented May 7, 2025

Experiment C96C48mx500_S2SW_cyc_gfs FAILED on Gaeac6 in Build# 2 in
/gpfs/f6/drsa-precip3/world-shared/global/CI/3651/RUNTESTS/EXPDIR/C96C48mx500_S2SW_cyc_gfs_05c9a66f

@emcbot emcbot added CI-Gaeac6-Failed **Bot use only** CI testing on Gaea C6 for this PR has failed and removed CI-Gaeac6-Failed **Bot use only** CI testing on Gaea C6 for this PR has failed labels May 7, 2025
@emcbot
Copy link

emcbot commented May 7, 2025

Experiment C96C48_hybatmDA FAILED on Hercules in Build# 1 with error logs:

/work2/noaa/global/role-global/GFS_CI_CD/HERCULES/CI/3651/RUNTESTS/COMROOT/C96C48_hybatmDA_05c9a66f/logs/2021122106/enkfgdas_fcst_mem001.log
/work2/noaa/global/role-global/GFS_CI_CD/HERCULES/CI/3651/RUNTESTS/COMROOT/C96C48_hybatmDA_05c9a66f/logs/2021122106/enkfgdas_fcst_mem002.log

Follow link here to view the contents of the above file(s): (enkfgdas_fcst_mem001.log) (enkfgdas_fcst_mem002.log)

@KateFriedman-NOAA KateFriedman-NOAA added the CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 label May 9, 2025
@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules labels May 9, 2025
@JessicaMeixner-NOAA
Copy link
Contributor Author

thanks @KateFriedman-NOAA ! I'll be following the hercules closely to see if the failure again happens that I could not replicate.

@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Gaeac6-Running and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 labels May 9, 2025
@emcbot
Copy link

emcbot commented May 9, 2025

Experiment C96C48mx500_S2SW_cyc_gfs FAILED on Gaeac6 in Build# 4 with error logs:

/gpfs/f6/drsa-precip3/world-shared/global/CI/3651/RUNTESTS/COMROOT/C96C48mx500_S2SW_cyc_gfs_e31ddb5d/logs/2021122018/enkfgfs_earc_tars_00.log

Follow link here to view the contents of the above file(s): (enkfgfs_earc_tars_00.log)

@emcbot emcbot added CI-Gaeac6-Failed **Bot use only** CI testing on Gaea C6 for this PR has failed and removed CI-Gaeac6-Running labels May 9, 2025
@emcbot
Copy link

emcbot commented May 9, 2025

Experiment C96C48mx500_S2SW_cyc_gfs FAILED on Gaeac6 in Build# 4 in
/gpfs/f6/drsa-precip3/world-shared/global/CI/3651/RUNTESTS/EXPDIR/C96C48mx500_S2SW_cyc_gfs_e31ddb5d

@CatherineThomas-NOAA
Copy link
Contributor

I took a look at the failure on Gaea in enkfgfs_earc_tars_00.log. It has this line:
FileNotFoundError: FATAL ERROR: Required file, directory, or glob logs/2021122018/enkfgfs_esfc.log not found!

This is likely due to the same race condition mentioned in #3660 and #3667. The enkfgdas_earc_tars jobs should be dependent on both ecmn and esfc as they run concurrently.

@emcbot emcbot added CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Gaeac6-Failed **Bot use only** CI testing on Gaea C6 for this PR has failed CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Gaeac6-Failed **Bot use only** CI testing on Gaea C6 for this PR has failed CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels May 9, 2025
@KateFriedman-NOAA KateFriedman-NOAA merged commit a6c4351 into NOAA-EMC:develop May 12, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Model - To Do/In Progress to Done in GFS v17 May 12, 2025
@JessicaMeixner-NOAA JessicaMeixner-NOAA deleted the updatemodel20250505 branch June 26, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-Gaeac6-Failed **Bot use only** CI testing on Gaea C6 for this PR has failed CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants