forked from NCAR/noahmp
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable new decomposition algorithm #13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
uturuncoglu
requested review from
barlage and
BarbaraStunder-NOAA
and removed request for
BarbaraStunder-NOAA
January 3, 2025 21:04
@barlage JFYI, this is ready for review. |
@barlage Can you review this pr and approve? Not merge yet though. |
barlage
approved these changes
Jan 22, 2025
Tests are done at ufs-community/ufs-weather-model#2387. @uturuncoglu @barlage @HelinWei-NOAA Can you merge this pr? |
@uturuncoglu do you want to merge this? |
@barlage good to go ahead to merge. |
@jkbk2004 done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add new decomposition algorithm to NoahMP component model coupling interface (NUOPC cap )to distribute land and ocean points evenly to all the processor. The new decomposition algorithm might be more efficient especially for high resolution cases. The new decomposition algorithm can be activated by adding decomp_type = custom option to LND_attributes:: section of ufs.configure.