Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rhonewsn1 to nuopc and to the NOAH MP driver and source code #4

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Add rhonewsn1 to nuopc and to the NOAH MP driver and source code #4

merged 1 commit into from
Feb 8, 2023

Conversation

ericaligo-NOAA
Copy link

A variable precip ice density, rhonewsn1, is passed into the driver and then assigned to prcpiceden. The array prcpiceden is used in the LSM if the namelist option, iopt_snf = 5 and exticeden = T. The flag exticeden is set to T if a user wants to compute the variable precip ice density.

This PR is connected with the following PRs:

Depends on Winterwx NOAA-EMC/fv3atm#614
Depends on Winterwx ufs-community/ccpp-physics#30
Six new winter weather diagnostics, new precip ice density for RUC, NOAH and NOAH MP LSM, and rename nsradar_reset ufs-community/ufs-weather-model#1529

@ChunxiZhang-NOAA
Copy link

@barlage @uturuncoglu Could you review this PR at your convenience?

@uturuncoglu
Copy link
Collaborator

@ChunxiZhang-NOAA I have a meeting all day but I'll look at it today and maybe test it.

@ChunxiZhang-NOAA
Copy link

@uturuncoglu No problem. Thank you!

Copy link
Collaborator

@uturuncoglu uturuncoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to clarify how we handle this new argument in component version of the model before merging this. So, we also need input from @barlage

drivers/nuopc/lnd_comp_driver.F90 Show resolved Hide resolved
@uturuncoglu uturuncoglu merged commit 9ea6e5d into NOAA-EMC:develop Feb 8, 2023
@uturuncoglu
Copy link
Collaborator

@ChunxiZhang-NOAA @BrianCurtis-NOAA This is merged now. Thanks for putting this.

@ChunxiZhang-NOAA
Copy link

@uturuncoglu Thanks for merging it. The merge is supposed to be done AFTER all ufs-weather-model regression tests on different platforms passed. But I think it is OK for now unless some bugs caught later from the regression tests.

@uturuncoglu
Copy link
Collaborator

@ChunxiZhang-NOAA I was thinking that that is already done and you are waiting for this merge. Anyway, if you see any issue we could fix it. I have already test the datm+land outside of the UFS and it was fine. I am not sure about other RTs.

@ChunxiZhang-NOAA
Copy link

@uturuncoglu Sure, I will let you know if there is any issue. And yes, the RT test on Hera was successful. The chance to fail on other platforms is very low.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants