Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Land surface upgrades for HR2 #7

Merged
merged 10 commits into from
Jul 19, 2023
Merged

Land surface upgrades for HR2 #7

merged 10 commits into from
Jul 19, 2023

Conversation

uturuncoglu
Copy link
Collaborator

This PR aims to bring changes related to the new soil color dataset to the component model.

@uturuncoglu uturuncoglu mentioned this pull request Jun 14, 2023
Merged
35 tasks
@uturuncoglu
Copy link
Collaborator Author

@HelinWei-NOAA @barlage The build seems fine under action but run crashed due to missing INPUT/C96.soil_color.tile*.nc files which is expected. These files need to be push to the cloud once the PR is in.

@uturuncoglu
Copy link
Collaborator Author

@HelinWei-NOAA @barlage GitHub action test is passing now after syncing new soil color dataset with S3 bucket.

@FernandoAndrade-NOAA
Copy link

ufs-community/ufs-weather-model#1777 Testing has been completed successfully, please go ahead and approve and begin the merge process, thank you.

@jkbk2004
Copy link
Collaborator

@uturuncoglu @BarbaraStunder-NOAA can you hold a bit? We need to check ccpp pr.

@jkbk2004
Copy link
Collaborator

There is a syncing issue on ufs-community/ccpp-physics#78. We need to hold a bit.

@FernandoAndrade-NOAA
Copy link

FernandoAndrade-NOAA commented Jul 18, 2023 •
edited
Loading

Looks like ccpp #78 was a false alarm on the sync issue, please go ahead and continue.

@jkbk2004
Copy link
Collaborator

@uturuncoglu @barlage The issue on ccpp side was cleared. All sets now. Can you merge in this pr?

@barlage barlage merged commit 569e354 into develop Jul 19, 2023
@jkbk2004
Copy link
Collaborator

@barlage thanks for merging the pr!

@FernandoAndrade-NOAA FernandoAndrade-NOAA mentioned this pull request Jul 19, 2023
Merged
@uturuncoglu uturuncoglu deleted the feature/hr2_land1 branch August 11, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HelinWei-NOAA HelinWei-NOAA HelinWei-NOAA approved these changes

@barlage barlage barlage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@uturuncoglu @FernandoAndrade-NOAA @jkbk2004 @barlage @HelinWei-NOAA