-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first python test! #478
first python test! #478
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edwardhartnett Looks good to me, thanks! Just curious what is the purpose of the pyproject.toml file? I'm unfamiliar with .toml files.
The pyproject.toml is the standard python way to pass options to all the build tools. Used to be each tool kept it's own config files, but that was a giant mess, so current best practice is to organize all tool settings in pyproject.toml. You will see more settings go into this file as we improve the python project. For more info: |
@edwardhartnett After merging, I realized the pyproject.toml file is in the main level directory. Particularly for systems going to production, the main level directory should pretty sparse, filled mainly with various subdirectories (exec, fix, jobs, parm, scripts, sorc, ush, ...). Could it be tucked under the tests/ space, or is it critical to be within the main level directory? |
… location of the .toml file.
DESCRIPTION OF CHANGES:
Added the first (of many) python test.
This test is for the misc.py file under ush/python_utils. It's a nice simple code to start with.
TESTS CONDUCTED:
N/A
Machines/Platforms:
N/A
Test cases:
N/A
ISSUE:
Part of #456