Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed README and change CI to reflect new main branch #499

Merged
merged 7 commits into from
Sep 24, 2024

Conversation

edwardhartnett
Copy link
Contributor

@edwardhartnett edwardhartnett commented Sep 24, 2024

DESCRIPTION OF CHANGES:

Updated README, also changing CI system, to handle new branch main.

TESTS CONDUCTED:

N/A

Machines/Platforms:

N/A

Test cases:

N/A

ISSUE:

Part of #469

@edwardhartnett edwardhartnett marked this pull request as ready for review September 24, 2024 17:54
@edwardhartnett edwardhartnett changed the title changed README changed README and change CI to reflect new main branch Sep 24, 2024
@edwardhartnett
Copy link
Contributor Author

@MatthewPyle-NOAA after this is merged, go back to settings, and under branch protection you will be able to type in "docs" and "flake8" to make these required CI runs. That way, GitHub will enforce that these work.

Adds another bullet to point out the next steps that need to be taken after building the executables.
@MatthewPyle-NOAA
Copy link
Contributor

@edwardhartnett I made a small addition to the README file - let me know if it is/isn't okay with you.

Copy link
Contributor

@MatthewPyle-NOAA MatthewPyle-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the first PR to "main"...

@MatthewPyle-NOAA MatthewPyle-NOAA merged commit bd31e78 into NOAA-EMC:main Sep 24, 2024
2 checks passed
@MatthewPyle-NOAA
Copy link
Contributor

@MatthewPyle-NOAA after this is merged, go back to settings, and under branch protection you will be able to type in "docs" and "flake8" to make these required CI runs. That way, GitHub will enforce that these work.

@edwardhartnett Is this adding new branch protection rules? Not intuitive to me where I need to add "docs" and "flake8"

@edwardhartnett edwardhartnett deleted the ejh_doc_0924 branch September 24, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants