Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove references to G95 and other specific Fortrans #225

Closed
edwardhartnett opened this issue Aug 9, 2024 · 2 comments
Closed

remove references to G95 and other specific Fortrans #225

edwardhartnett opened this issue Aug 9, 2024 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@edwardhartnett
Copy link
Contributor

In wgrib2/New_grid.c we have:

#ifdef G95
        // initialize g95 runtime library
        if (g95_runstop == 0) { g95_runtime_start(0,NULL); g95_runstop = 1; }
#endif

What's this all about? I've never seen any other program that required this.

In our code there should be no reference to specific Fortran compilers. Fully standard Fortran runs on all compilers, and that's all we should be using.

@edwardhartnett edwardhartnett added the question Further information is requested label Aug 9, 2024
@webisu
Copy link
Collaborator

webisu commented Aug 9, 2024 via email

@webisu
Copy link
Collaborator

webisu commented Sep 18, 2024

Reference to G95 was eliminated when New_grid.c was rewritten for the new iplib.
The change also made the calling to fortran standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Status: Done
Development

No branches or pull requests

2 participants