Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build just one version of wgrib2 which handles rotated lat/lon #70

Open
edwardhartnett opened this issue Dec 18, 2023 · 7 comments
Open

build just one version of wgrib2 which handles rotated lat/lon #70

edwardhartnett opened this issue Dec 18, 2023 · 7 comments
Assignees
@edwardhartnett
Labels
build Relates to the build system

Comments

@edwardhartnett
Copy link
Contributor

Build just one version of wgrib2 which handles rotated lat/lon.
@edwardhartnett edwardhartnett added the build Relates to the build system label Dec 18, 2023
@edwardhartnett edwardhartnett mentioned this issue Dec 18, 2023
Closed
@edwardhartnett edwardhartnett self-assigned this Jun 26, 2024
@edwardhartnett
Copy link
Contributor Author

@webisu was this done as part of the recent ip changes?

@webisu
Copy link
Collaborator

webisu commented Jul 5, 2024 via email

@edwardhartnett
Copy link
Contributor Author

@AlexanderRichert-NOAA do you know the fix that @webisu needs?

@AlexanderRichert-NOAA
Copy link
Contributor

I believe so yes, it looks like another instance of reconciling ip's and ip2's different "ideas" of rotated lat-lon grids. I should have a candidate fix soon.

@AlexanderRichert-NOAA
Copy link
Contributor

The non-E grid is fixed. Right now I'm looking at the E grid code. The ip and ip2 repositories have some different logic from what's in the wgrib2 vendored copy of ip2. @webisu what version of ip2 is used in wgrib2? If I can figure out where/when the difference within ip2 came in between the two approaches for gdt=1 then hopefully it'll help me implement a clean fix that makes everybody happy.

@AlexanderRichert-NOAA
Copy link
Contributor

@webisu can you please take a look at my fork again (NOAA-EMC/NCEPLIBS-ip#241)? I've restricted the alternate rot lat lon scheme to only be used when gdtn=32769, which should hopefully take care of it. I also added an off switch for "unusing" that scheme. It may ultimately not be necessary if it's now differentating between gdtn=1 and gdtn=32769, but I'll leave it for now just to prevent risk of impact to other users. Anyway, please try the updated ip code again and let me know if it works.

@edwardhartnett
Copy link
Contributor Author

We believe this is working, testing is underway...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edwardhartnett edwardhartnett

Labels
build Relates to the build system
Projects
No open projects
wgrib2-3.4.0
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@webisu @edwardhartnett @AlexanderRichert-NOAA