Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spack-based CI workflow + recipe #157

Merged
merged 28 commits into from
Jul 12, 2024

Conversation

AlexanderRichert-NOAA
Copy link
Contributor

@AlexanderRichert-NOAA AlexanderRichert-NOAA commented Jul 1, 2024

This PR adds a Spack-based CI workflow, including an authoritative copy of the recipe (updated for CMake).

Fixes #112

@AlexanderRichert-NOAA
Copy link
Contributor Author

@edwardhartnett this is in pretty good shape, and I've tested a bunch of the spack variant related to dependencies. One thing that isn't working is if I enable the Fortran API and/or the library. I'm getting wgrib2/ftn_api/fort_wgrib2.c:43: undefined reference to 'wgrib2'. Any idea what that might be about?

@edwardhartnett
Copy link
Contributor

@webisu any clue as to the build problems @AlexanderRichert-NOAA reports?

@AlexanderRichert-NOAA I think we should get this merged without the broken options, so we have something...

@AlexanderRichert-NOAA AlexanderRichert-NOAA marked this pull request as ready for review July 5, 2024 18:41
@AlexanderRichert-NOAA
Copy link
Contributor Author

Okay, just updated. Users won't be able to apply build variants that aren't currently working.

@AlexanderRichert-NOAA
Copy link
Contributor Author

The one remaining issue I can see is that USE_IPOLATES is no longer getting defined for the preprocessor. Is it your intent to only ever use ip or nothing, and have it set as on/off? If so, I think we need to add something like list(APPEND definitions_list -DUSE_IPOLATES under the if(USE_IPOLATES) block in CMakeLists.txt. If that sounds good I can add it to this PR.

@AlysonStahl-NOAA AlysonStahl-NOAA merged commit a2fafdf into NOAA-EMC:develop Jul 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support spack build and testing
3 participants