[WIP] Proposed fix Gnu and Pgi issue with class(*) in send_data3d #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- MOM6 gnu tests seg fault when calling send_data3d under FMS2023.01-beta2 - These tests were passing under FMS2023.01-alpha4 - It is clear that gnu and pgi have issues with optional arguments declared as class(*) - Rather than having component models add kludge code to avoid these issues (probably compiler bugs) we can limit the kludge to a minimun by putting them inside FMS where these already exists (in send_data_1d and send_data_2d interfaces). - With this commit MOM6 tests passed under compilers Intel22, gnu11 and Nvhpc22.7 on c5
- MOM6 gnu tests seg fault when calling send_data3d under FMS2023.01-beta2 - These tests were passing under FMS2023.01-alpha4 - Slight changes in send_data3d has probably tickled some bugs in the Gnu compiler - It is clear that gnu and pgi both have issues with optional arguments declared as class(*) - Rather than having component models add kludge code to avoid these issues (probably compiler bugs) we can limit the kludge to a minimun by putting them inside FMS where these already exists (in send_data_1d and send_data_2d interfaces). - With this commit MOM6 tests passed under compilers Intel22, gnu11 and Nvhpc22.7 on c5
|
@nikizadehgfdl it looks like you have a line that's too long |
- MOM6 gnu tests seg fault when calling send_data3d under FMS2023.01-beta2 - These tests were passing under FMS2023.01-alpha4 - Slight changes in send_data3d has probably tickled some bugs in the Gnu compiler - It is clear that gnu and pgi both have issues with optional arguments declared as class(*) - Rather than having component models add kludge code to avoid these issues (probably compiler bugs) we can limit the kludge to a minimun by putting them inside FMS where these already exists (in send_data_1d and send_data_2d interfaces). - With this commit MOM6 tests passed under compilers Intel22, gnu11 and Nvhpc22.7 on c5 - Fixed line>121chars
|
Please suggest a better name for the new subroutine send_data_3d_class! |
- MOM6 gnu tests seg fault when calling send_data3d under FMS2023.01-beta2 - These tests were passing under FMS2023.01-alpha4 - Slight changes in send_data3d has probably tickled some bugs in the Gnu compiler - It is clear that gnu and pgi both have issues with optional arguments declared as class(*) - Rather than having component models add kludge code to avoid these issues (probably compiler bugs) we can limit the kludge to a minimun by putting them inside FMS where these already exists (in send_data_1d and send_data_2d interfaces). - With this commit MOM6 tests passed under compilers Intel22, gnu11 and Nvhpc22.7 on c5 - Fixed line>121chars
|
@thomas-robinson suggested diag_send_data. I pushed an update. |
rem1776
approved these changes
Mar 9, 2023
thomas-robinson
approved these changes
Mar 9, 2023
bensonr
approved these changes
Mar 9, 2023
nikizadehgfdl
added a commit
to nikizadehgfdl/FMS
that referenced
this pull request
Mar 10, 2023
- send_data3d is not calling diag_send_data correctly. - it has to check for presence of argument "mask" and call diag_send_data accordingly is
8 tasks
rem1776
pushed a commit
that referenced
this pull request
Mar 13, 2023
uramirez8707
added a commit
to uramirez8707/FMS
that referenced
this pull request
Apr 6, 2023
* fix - gnu and pgi issue with class(*) in send_data3d (NOAA-GFDL#1149) * feat: extend `string` interface in `fms_string_utils_mod` (NOAA-GFDL#1142) * fix: add omp directives for race condition in tridiagonal (NOAA-GFDL#1109) * fix: missing if statement in PR NOAA-GFDL#1149 (NOAA-GFDL#1155) * fix: time_manager missing changes from year to yr, month to mo, day to dy (NOAA-GFDL#1169) * chore: update changelog and version numbers for release (NOAA-GFDL#1167) * chore: append dev to version number post-release (NOAA-GFDL#1179) --------- Co-authored-by: Niki Zadeh <niki.zadeh@noaa.gov> Co-authored-by: Jesse Lentz <42011922+J-Lentz@users.noreply.github.com> Co-authored-by: ganganoaa <121043264+ganganoaa@users.noreply.github.com> Co-authored-by: MiKyung Lee <58964324+mlee03@users.noreply.github.com> Co-authored-by: Ryan Mulhall <35538242+rem1776@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes gnu and pgi issue with class(*) in send_data3d
issues (probably compiler bugs) we can limit the kludge to a minimum by
putting them inside FMS where these already exists (in send_data_1d and
send_data_2d interfaces).
Fixes # (issue)
How Has This Been Tested?
MOM6_solo test cases with Intel, Gnu and Pgi
Checklist:
make distcheckpasses