Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autotools check for HDF5 floating point exceptions #1455

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Feb 8, 2024

Description
Adds a check in autotools for hdf5 errors stemming from FPE traps.

Since this check uses a test program, it'll only get triggered when you would actually encounter the error. This means you'll need both the newest hdf5 version (1.14.3) and the FPE trap flag in your FCFLAGS (ie. -ftrapuv for intel, -ffpe-trap=invalid for gnu).

How Has This Been Tested?
tested with a container with hdf5 1.14.3 and on the amd box

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

thomas-robinson
thomas-robinson previously approved these changes Feb 9, 2024
@thomas-robinson
Copy link
Member

One of the tests failed that shouldn't have

@rem1776
Copy link
Contributor Author

rem1776 commented Feb 15, 2024

@thomas-robinson This is ready now, needed a slight change to work with the gfortran on the ci image.

@rem1776 rem1776 merged commit 5300c32 into NOAA-GFDL:main Feb 22, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants