update sat_vapor_pres
bad temperature output to use mpp_error
#1619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes a direct stdout write in
sat_vapor_pres
to anmpp_error
warning call and adds some tests to check the modified interface works properly with each dimension.This fixes the issue below since stdout only points to a file on the root pe (otherwise its /dev/null), while the mpp_error call will print to stderr on all PE's instead.
The one caveat is that the output will now prepend some info to the output, so instead of:
Bad temperature= 0.100E+03 at i= 1 j= 1 k= 1 pe= 1
it'll be:
WARNING from PE 1: Bad temperature= 0.100E+03 at i= 1 j= 1 k= 1
Fixes #1596
How Has This Been Tested?
tested on the amd box with oneapi 2024.2
Checklist:
make distcheck
passes