Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sat_vapor_pres bad temperature output to use mpp_error #1619

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Dec 3, 2024

Description
This PR changes a direct stdout write in sat_vapor_pres to an mpp_error warning call and adds some tests to check the modified interface works properly with each dimension.

This fixes the issue below since stdout only points to a file on the root pe (otherwise its /dev/null), while the mpp_error call will print to stderr on all PE's instead.

The one caveat is that the output will now prepend some info to the output, so instead of:
Bad temperature= 0.100E+03 at i= 1 j= 1 k= 1 pe= 1
it'll be:
WARNING from PE 1: Bad temperature= 0.100E+03 at i= 1 j= 1 k= 1

Fixes #1596

How Has This Been Tested?
tested on the amd box with oneapi 2024.2

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

bensonr
bensonr previously approved these changes Dec 3, 2024
uramirez8707
uramirez8707 previously approved these changes Dec 4, 2024
@rem1776 rem1776 dismissed stale reviews from uramirez8707 and bensonr via f83e434 December 12, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sat_vapor_pres does not output location of bad temperatures (unless it's on a root pe)
3 participants