Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Adding comments for documentation #98

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

nikizadehgfdl
Copy link
Contributor

@nikizadehgfdl
Copy link
Contributor Author

@bensonr this is an effort to address the user question #97 along with
FMS PR NOAA-GFDL/FMS#1428
Could you see if you agree with these comments and if they make sense and address the question? Thanks.

Copy link
Contributor

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this much needed documentation regarding the meaning of sea.

!1. The two arrays ex_frac_open_sea and ex_seawater are the same
! Their difference is that ex_frac_open_sea is a local array,
! but ex_seawater is a module array used outside this subroutine
!2. The xgrid array "ex_seawater" is either 0 or 1 and nothing else, just like the "ONC" grid array "sea"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix ONC typo.

@rem1776 rem1776 merged commit f4782c2 into NOAA-GFDL:main Jan 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants