-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ESMF field attributes using the same kind as field data values #236
Create ESMF field attributes using the same kind as field data values #236
Conversation
HI @DusanJovic-NOAA is there anyone from EMC or the UFS community that you would like to review this? |
@DusanJovic-NOAA Since the data buffer is in real(4) for dyn history outputs, can we just change line #106 to real(4)? |
|
I see. The changes look good to me. |
@laurenchilutti @bensonr all tests at ufs-community/ufs-weather-model#1566 are done. Can you go ahead to merge in this pr? |
Description
This PR updates
add_field_to_bundle
subroutine in driver/fvGFS/fv_nggps_diag.F90. The values used for esmf field attributes (_FillValue
andmissing_value
) must be the same real kind as the field data values, in this case REAL(4) in order to avoid type mismatch checks in PIO library which is used by ESMF I/O module.See: ufs-community/ufs-weather-model#1564
How Has This Been Tested?
Full usf-weather-model regression test on Hera.
Checklist:
Please check all whether they apply or not