Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix out-of-bounds access in module_diag_hailcast.F90 which crashes RRFS on WCOSS2. #308

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Fix out-of-bounds access in module_diag_hailcast.F90 which crashes RRFS on WCOSS2. #308

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0d81fd1
fix out-of-bounds write in module_diag_hailcast
SamuelTrahanNOAA Dec 23, 2023
be761b5
better fix
SamuelTrahanNOAA Dec 23, 2023
62b4100
change to the correct bug fix
SamuelTrahanNOAA Dec 27, 2023
281e304
only correct RWA_new where RWA_adiabat(k).ge.1.E-12
SamuelTrahanNOAA Jan 4, 2024
1ed328c
update comments; changes from @adams-selin
SamuelTrahanNOAA Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/module_diag_hailcast.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,7 @@ SUBROUTINE hailstone_driver ( ii,jj,TCA, h1d, ht, PA, rho1d,&
!ENDIF
ENDDO
!remove the height factor from RWA_new
DO k=KBAS,nz
DO k=KBAS+1,nz
RWA_new(k) = RWA_new(k) / (h1d(k)-h1d(k-1))
ENDDO

Expand Down