Fix mesh generation in init_grid() #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tile index to `grid_global` was not correct inside a loop over tiles.
|
@lharris4 will this fix be answer changing and under what conditions? |
|
My 0.02$: This will change the resulting lat/lon of the mesh, if mesh generation is done internally in the model. I am assuming that typically a INPUT/grid_spec.nc file is being read for mesh generation and mesh generation is only done internally for idealized model setups, but I might be wrong. Also, it could be that the next time somebody generates a grid_spec.nc file using the model after the fix, that the contents of that file will be different. |
|
This will affect the doubly periodic and aquaplanet then |
|
This would indeed change answers, but only if the grid is generated on-line
and any of the values are within the range (-1.d-10,1.d-10) and not
identically zero. In the unrotated cube this should not a problem but
someone should check.
Lucas
…On Thu, Apr 30, 2020 at 2:41 PM Tom Robinson ***@***.***> wrote:
This will affect the doubly periodic and aquaplanet then
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#39 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMUQRVG2JVYEQRCYYCSFWBTRPHA53ANCNFSM4MVV3EFQ>
.
|
|
#39 should fix this |
lharris4
approved these changes
May 1, 2020
bensonr
approved these changes
May 4, 2020
XiaqiongZhou-NOAA
added a commit
to XiaqiongZhou-NOAA/GFDL_atmos_cubed_sphere
that referenced
this pull request
Jun 15, 2020
* Fixes for mesh generation in init_grid (NOAA-GFDL#39) * Remove trailing whitespace and any tabs * Add default values for nest_*offsets in fv_control
DusanJovic-NOAA
pushed a commit
to NOAA-EMC/GFDL_atmos_cubed_sphere
that referenced
this pull request
Jun 22, 2020
* Fixes for GNU compilation issues (NOAA-GFDL#32) * Fixes for mesh generation in init_grid (NOAA-GFDL#39) * Remove trailing whitespace and any tabs * Add default values for nest_*offsets in fv_control * Remove the fix for mesh generation and it will be fixed later * fix GNU out-of-bound error in driver/fvGFS/atmosphere.F90 * Correct Z dimensions in driver/fvGFS/atmosphere.F90 Co-authored-by: Xiaqiong Zhou <Xiaqiong.Zhou@noaa.gov>
tsupinie
pushed a commit
to tsupinie/GFDL_atmos_cubed_sphere
that referenced
this pull request
Jul 20, 2020
* Fixes for GNU compilation issues (NOAA-GFDL#32) * Fixes for mesh generation in init_grid (NOAA-GFDL#39) * Remove trailing whitespace and any tabs * Add default values for nest_*offsets in fv_control * Remove the fix for mesh generation and it will be fixed later * fix GNU out-of-bound error in driver/fvGFS/atmosphere.F90 * Correct Z dimensions in driver/fvGFS/atmosphere.F90 Co-authored-by: Xiaqiong Zhou <Xiaqiong.Zhou@noaa.gov>
climbfuji
pushed a commit
to climbfuji/GFDL_atmos_cubed_sphere
that referenced
this pull request
Apr 24, 2024
Merge Geos/develop into geos/main for release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tile index to
grid_globalwas not correct inside a loop over tiles.@bensonr @lharris4 This fixes Issue 38.