Fix bugs in output files with rescaled heights #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed two minor bugs in the MOM6 output when run with Z_RESCALE_POWER not equal to 0. All solutions are bitwise identical, but some of the diagnostic output files have minor changes. With these corrections, several output files are now unaltered by internal dimensional rescaling. The specific bug fixes are: - Avoid using a rescaled depth as the vertical coordinate label in z-space output files. Only the coordinate label is impacted, but this bug fix avoids the chance of having silly values for this coordinate. - Rescale the depths back to mks units before taking their checksum for storage in the MOM_sum_output file. With this bug, the depth list file might be unnecessarily recreated with a new run with different scaling, but the file itself is fine.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #121 +/- ##
============================================
- Coverage 33.52% 33.51% -0.01%
============================================
Files 262 262
Lines 71175 71175
Branches 13284 13284
============================================
- Hits 23861 23856 -5
- Misses 42844 42847 +3
- Partials 4470 4472 +2
Continue to review full report at Codecov.
|
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15575 ✔️ |
marshallward
approved these changes
May 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed two minor bugs in the MOM6 output when run with Z_RESCALE_POWER not
equal to 0. All solutions are bitwise identical, but some of the diagnostic
output files have minor changes. With these corrections, several output files
are now unaltered by internal dimensional rescaling. The specific bug fixes
are:
Avoid using a rescaled depth as the vertical coordinate label in z-space
output files. Only the coordinate label is impacted, but this bug fix avoids
the chance of having silly values for this coordinate.
Rescale the depths back to mks units before taking their checksum for storage
in the MOM_sum_output file. With this bug, the depth list file might be
unnecessarily recreated with a new run with different scaling, but the file
itself is fine.