+Add and use optional unscale argument to log_param_real #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an optional unscale argument to the log_param_real interfaces. All answers and output are bitwise identical.
Use the new unscale optional argument in 10 log_param calls for real variables. All answers and output are bitwise identical.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #320 +/- ##
=========================================
Coverage 37.19% 37.20%
=========================================
Files 265 265
Lines 74428 74431 +3
Branches 13822 13822
=========================================
+ Hits 27687 27691 +4
+ Misses 41650 41649 -1
Partials 5091 5091
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
marshallward
approved these changes
Feb 11, 2023
This was referenced Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of two commits, the first of which adds the new optional argument unscale to the two interfaces wrapped by log_param for real variables. This argument allows for rescaled variables to be passed into these log_param
calls, without having to be multiplied by this unscaling factor, and it will allow the units and unscale arguments to be easily compared for consistency. The second commit uses this new optional argument in 10 calls to the log_param routines. All answers and output are bitwise identical.
The first of these two commits covers the non-controversial parts of MOM6 PR #300.
The commits in this PR include: