Autoconf configuration of Python #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #326 +/- ##
=========================================
Coverage 37.16% 37.16%
=========================================
Files 265 265
Lines 74505 74505
Branches 13837 13837
=========================================
+ Hits 27687 27690 +3
+ Misses 41724 41720 -4
- Partials 5094 5095 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
marshallward
force-pushed
the
ac_python_config
branch
from
4bbc365 to
e8386eb
Compare
The introduction of makedep means that Python is now a dependency of the MOM6 compilation. On some systems, we cannot assume that `python` is the name of the interpreter, and strictly should not even assume that it exists. This is notably an issue on the recent MacOS M1 systems, which use `python3` as its interpreter, and do not provide one named `python`. This patch adds macros to the MOM6 and FMS autoconf builds to detect if Python is on the system, and makes a few attempts to determine the name of the interpreter (python, python3, python2). Perhaps more can be done here, but this is probably sufficient in nearly all cases.
Hallberg-NOAA
force-pushed
the
ac_python_config
branch
from
e8386eb to
fd22b66
Compare
Hallberg-NOAA
approved these changes
Feb 24, 2023
There was a problem hiding this comment.
This PR seems sensible enough, and it has passed the TC testing. It has only partially passed the pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/18314 due to known ongoing issues with the Gaea file system. However, given the nature of this PR, it has passed enough tests that I am satisfied that there is no problem here.
This was referenced Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The introduction of makedep means that Python is now a dependency of the MOM6 compilation. On some systems, we cannot assume that
pythonis the name of the interpreter, and strictly should not even assume that it exists.This is notably an issue on the recent MacOS M1 systems, which use
python3as its interpreter, and do not provide one namedpython.This patch adds macros to the MOM6 and FMS autoconf builds to detect if Python is on the system, and makes a few attempts to determine the name of the interpreter (python, python3, python2). Perhaps more can be done here, but this is probably sufficient in nearly all cases.