+Add and use US%Pa_to_RL2_T2 and US%Pa_to_RLZ_T2 #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the combined unit scaling factors Pa_to_RL2_T2 and Pa_to_RLZ_T2 to the unit_scale_type to rescale pressures and wind stresses. All answers are bitwise identical, but there are two new elements in a public type.
Use the new combined unit scaling factor US%Pa_to_RL2_T2 to rescale input pressure fields and US%Pa_to_RLZ_T2 to rescale input wind stresses in various places in the MOM6 code, including in the solo_driver and FMS_cap drivers. Analogous changes could also be made to the mct and nuopc surface forcing files, but have been omitted for now. All answers are bitwise identical.
Added the new runtime parameter TAUX_MAGNITUDE to set the strength of the zonal wind stresses when WIND_CONFIG = "2gyre", "1gyre" or "Neverworld", with a default that matches the previous hard-coded dimensional parameters that were used to specify the wind stresses in these cases. Also use US%Pa_to_RLZ_T2 to rescale wind stresses throughout solo_driver/MOM_surface_forcing.F90. By default, all answers are bitwise identical, but there is a new runtime parameter in the MOM_parameter_doc files for some test cases.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #339 +/- ##
============================================
- Coverage 37.07% 37.07% -0.01%
============================================
Files 264 264
Lines 74347 74349 +2
Branches 13784 13787 +3
============================================
Hits 27567 27567
Misses 41684 41684
- Partials 5096 5098 +2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/18835 ✔️ 🟡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new elements Pa_to_RL2_T2 and Pa_to_RLZ_T2 to the unit_scale_type and then uses them to simplify the expressions rescaling various input pressures and wind stresses. I find this convenient in part because I find myself having to reconstruct the combination of basic mks units that are Pascals when evaluating the correctness of expressions using it, whereas I think that this combined scaling factor makes the consistency more readily apparent, while also making the code shorter. In addition the new runtime parameter TAUX_MAGNITUDE was added for several ocean-only configurations to replace some previously hard-coded dimensional constants, with default values that match those hard-coded constants in each case. By default, all answers are bitwise identical, but there are two new elements in a transparent public type, and there are new entries in some MOM_parameter_doc.short files.
The commits in this PR include: