Set logicals in MOM_tracer_advect.F90 #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcroft
force-pushed
the
bugfix-uninit-logicals-tracer-advect
branch
2 times, most recently
from
7983f5b to
78492d6
Compare
We had random behavior in the doc files because the logical `CS%useHuynh` was not set when using the PLM scheme.
adcroft
force-pushed
the
bugfix-uninit-logicals-tracer-advect
branch
from
78492d6 to
0ee31cb
Compare
marshallward
approved these changes
Jul 31, 2024
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two logicals can be unset when using PLM in MOM_tracer_advect.F90. This was leading to random behavior in the doc files because a third parameter was only being read and logged depending on whether PLM:H3 was used.
This commit sets
CS%usePPM = .false.andCS%useHuynh = .false.before processing the run-time parameter.