Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default of USE_POROUS_BARRIER to false #735

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

herrwang0
Copy link

This change should result in some speed up.

MOM_input in test cases are changed accordingly.

* subroutine initialize_MOM
* MOM_input in test cases
@adcroft
Copy link
Member

adcroft commented Oct 30, 2024

Tested at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/25323 and leads to changes in available_diags

diff gnu-all-dynamic_symmetric-repro-def-params/ocean_only/global_ALE/layer/available_diags.000000 MOM6-examples/ocean_only/global_ALE/layer/available_diags.000000
409a410,433
> "por_layer_widthU"  [Unused]
>     ! modules: {ocean_model,ocean_model_z,ocean_model_d2,ocean_model_z_d2}
>     ! long_name: Porous barrier open width fraction (at the layer interfaces) of the u-faces
>     ! units: nondim
>     ! cell_methods: xq:point yh:mean zi:point
>     ! variants: {por_layer_widthU,por_layer_widthU_xyave}
> "por_layer_widthV"  [Unused]
>     ! modules: {ocean_model,ocean_model_z,ocean_model_d2,ocean_model_z_d2}
>     ! long_name: Porous barrier open width fraction (at the layer interfaces) of the v-faces
>     ! units: nondim
>     ! cell_methods: xh:mean yq:point zi:point
>     ! variants: {por_layer_widthV,por_layer_widthV_xyave}
> "por_face_areaU"  [Unused]
>     ! modules: {ocean_model,ocean_model_z,ocean_model_d2,ocean_model_z_d2}
>     ! long_name: Porous barrier open area fraction (layer averaged) of U-faces
>     ! units: nondim
>     ! cell_methods: xq:point yh:mean zl:mean
>     ! variants: {por_face_areaU,por_face_areaU_xyave}
> "por_face_areaV"  [Unused]
>     ! modules: {ocean_model,ocean_model_z,ocean_model_d2,ocean_model_z_d2}
>     ! long_name: Porous barrier open area fraction (layer averaged) of V-faces
>     ! units: nondim
>     ! cell_methods: xh:mean yq:point zl:mean
>     ! variants: {por_face_areaV,por_face_areaV_xyave}

and doc strongs

diff gnu-all-dynamic_symmetric-repro-def-params/ocean_only/DOME/MOM_parameter_doc.short MOM6-examples/ocean_only/DOME/MOM_parameter_doc.short
248a249,250
> ! === module MOM_porous_barriers ===
> 
diff gnu-all-dynamic_symmetric-repro-def-params/ocean_only/lock_exchange/MOM_parameter_doc.all MOM6-examples/ocean_only/lock_exchange/MOM_parameter_doc.all
52c52
< USE_POROUS_BARRIER = False      !   [Boolean] default = False
---
> USE_POROUS_BARRIER = True       !   [Boolean] default = True
749a750,766
> 
> ! === module MOM_porous_barriers ===
> PORBAR_ANSWER_DATE = 99991231   ! default = 99991231
>                                 ! The vintage of the porous barrier weight function calculations.  Values below
>                                 ! 20220806 recover the old answers in which the layer averaged weights are not
>                                 ! strictly limited by an upper-bound of 1.0 .
> PORBAR_MASKING_DEPTH = 0.0      !   [m] default = 0.0
>                                 ! If the effective average depth at the velocity cell is shallower than this
>                                 ! number, then porous barrier is not applied at that location.
>                                 ! PORBAR_MASKING_DEPTH is assumed to be positive below the sea surface.
> PORBAR_ETA_INTERP = "MAX"       ! default = "MAX"
>                                 ! A string describing the method that decides how the interface heights at the
>                                 ! velocity points are calculated. Valid values are:
>                                 !    MAX (the default) - maximum of the adjacent cells
>                                 !    MIN - minimum of the adjacent cells
>                                 !    ARITHMETIC - arithmetic mean of the adjacent cells
>                                 !    HARMONIC - harmonic mean of the adjacent cells

@adcroft adcroft merged commit 3d37f13 into NOAA-GFDL:dev/gfdl Oct 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants